Merge branch 'dev_neo3' into 'dev'

Dev neo3

See merge request root/atms!103

atms-api/src/main/java/pwc/taxtech/atms/dao/FormulaAdminMapper.java

@@ -16,7 +16,6 @@ public interface FormulaAdminMapper  extends MyMapper {
             "    cell_template.ID AS cellTemplateID, " +
             "    template.ID AS reportTemplateID, " +
             "    template.template_group_id AS reportTemplateGroupID, " +
-            "    cell_template_config.formula AS formula, " +
             "    cell_template.row_index AS rowIndex, " +
             "    cell_template.column_index AS columnIndex, " +
             "    template.Code AS reportCode, " +
@@ -27,11 +26,8 @@ public interface FormulaAdminMapper  extends MyMapper {
             "    template " +
             "        JOIN " +
             "    cell_template ON template.id = cell_template.report_template_id " +
-            "        JOIN " +
-            "    cell_template_config ON cell_template.id = cell_template_config.cell_template_id " +
             "WHERE " +
-            "    cell_template_config.data_source_type = 1 " +
-            "        AND template.template_group_id = #{groupId}")
+            "    template.template_group_id = #{groupId}")
     List<CellTemplatePerGroupDto> getCellTemplatePerGroupDto(@Param("groupId") Long groupId);
 
 

atms-api/src/main/java/pwc/taxtech/atms/dto/vatdto/CellTemplatePerGroupDto.java

@@ -9,7 +9,6 @@ public class CellTemplatePerGroupDto {
     private String cellTemplateID ;
     private String reportTemplateID ;
     private String reportTemplateGroupID ;
-    private String formula ;
     private int rowIndex ;
     private int columnIndex ;
     private String reportCode ;

atms-api/src/main/java/pwc/taxtech/atms/vat/entity/PCTEntity.java

 package pwc.taxtech.atms.vat.entity;
 
-import java.math.BigDecimal;
-
 public class PCTEntity {
     Integer period;
     Long cellTemplateId;
-    BigDecimal data;
+    String data;
 
     public PCTEntity() {
     }
@@ -44,11 +42,11 @@ public class PCTEntity {
         this.cellTemplateId = cellTemplateId;
     }
 
-    public BigDecimal getData() {
+    public String getData() {
         return data;
     }
 
-    public void setData(BigDecimal data) {
+    public void setData(String data) {
         this.data = data;
     }
 }

atms-api/src/main/java/pwc/taxtech/atms/vat/service/impl/ReportGeneratorImpl.java

@@ -363,7 +363,7 @@ public class ReportGeneratorImpl extends VatAbstractService implements ReportGen
                                 data = EMPTY;
                             }
 
-                            if(StringUtils.isNotBlank(data)) {
+                            if (StringUtils.isNotBlank(data)) {
                                 Pattern pattern = Pattern.compile("[0-9.]*");
                                 Matcher isNum = pattern.matcher(data);
                                 if (isNum.matches()) {
@@ -371,8 +371,7 @@ public class ReportGeneratorImpl extends VatAbstractService implements ReportGen
                                 } else {
                                     cellData.setData(data);
                                 }
-                            }
-                            else{
+                            } else {
                                 cellData.setData(data);
                             }
 
@@ -585,7 +584,14 @@ public class ReportGeneratorImpl extends VatAbstractService implements ReportGen
             List<PCTEntity> pctResults = cellDataMapper.queryByPCTs(parameter);
             Map<PCTEntity, BigDecimal> pctCache = new HashMap<>();
             pctResults.forEach(m -> {
-                pctCache.put(m, m.getData());
+                BigDecimal data = null;
+                try {
+                    data = new BigDecimal(m.getData());
+                } catch (NumberFormatException e) {
+                    logger.warn("number format ecption for parameter {}", m);
+                    data = BigDecimal.ZERO;
+                }
+                pctCache.put(m, data);
             });
 
             configMapToPCTs.forEach((k, v) -> {