• Stefan Broekman's avatar
    Issue fix for spdlog #595. Conversion warning. · de4644b4
    Stefan Broekman authored
    See: https://github.com/gabime/spdlog/issues/595
    
    On line 85 in file sinks/wincolor_sink.h:
    back_color &= ~(FOREGROUND_RED | FOREGROUND_GREEN | FOREGROUND_BLUE |
    FOREGROUND_INTENSITY);
    
    'back_color' is of type 'WORD' (unsigned short) whereas a bitwise
    complement/NOT returns an int. This results in a conversion warning with
    -Wconversion enabled.
    
    85:20: warning: conversion to 'WORD {aka short unsigned int}' from 'int'
    may alter its value [-Wconversion] back_color &= ~(FOREGROUND_RED |
    FOREGROUND_GREEN | FOREGROUND_BLUE | FOREGROUND_INTENSITY);
    
    Possible solution:
    We know that the result of ~(FOREGROUND_RED | FOREGROUND_GREEN |
    FOREGROUND_BLUE | FOREGROUND_INTENSITY) is always within the limits of
    an unsigned short so a simple cast should suffice (correct me if I'm
    wrong):
    
    back_color &= static_cast<unsigned short>(~(FOREGROUND_RED |
    FOREGROUND_GREEN | FOREGROUND_BLUE | FOREGROUND_INTENSITY));
    de4644b4
Name
Last commit
Last update
bench Loading commit data...
cmake Loading commit data...
example Loading commit data...
include/spdlog Loading commit data...
tests Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
CMakeLists.txt Loading commit data...
INSTALL Loading commit data...
LICENSE Loading commit data...
README.md Loading commit data...
appveyor.yml Loading commit data...
astyle.sh Loading commit data...