Skip to content

S
spdlog
Unverified Commit 80740f0e authored by Gabi Melman's avatar Gabi Melman Committed by GitHub
Browse files
Options

Merge pull request #1105 from jktjkt/do-not-impose-extra-warnings 

Do not impose -Wextra -Wconversion etc on library users
parents e0b4ec54 c60f7907
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 6 deletions
CMakeLists.txt
View file @ 80740f0e
...@@ -80,12 +80,10 @@ target_link_libraries(spdlog_header_only INTERFACE Threads::Threads) ...@@ -80,12 +80,10 @@ target_link_libraries(spdlog_header_only INTERFACE Threads::Threads)
#--------------------------------------------------------------------------------------- #---------------------------------------------------------------------------------------
if(SPDLOG_MASTER_PROJECT) if(SPDLOG_MASTER_PROJECT)
if (CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang|AppleClang") if (CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang|AppleClang")
target_compile_options( spdlog PUBLIC -Wall -Wextra -Wconversion -pedantic -Wfatal-errors) target_compile_options( spdlog PRIVATE -Wall -Wextra -Wconversion -pedantic -Wfatal-errors)
target_compile_options( spdlog_header_only INTERFACE -Wall -Wextra -Wconversion -pedantic -Wfatal-errors)
endif() endif()
if (CMAKE_CXX_COMPILER_ID MATCHES "MSVC") if (CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
target_compile_options( spdlog PUBLIC /W3 /WX ) target_compile_options( spdlog PRIVATE /W3 /WX )
target_compile_options( spdlog_header_only INTERFACE /W3 /WX)
endif() endif()
include(cmake/sanitizers.cmake) include(cmake/sanitizers.cmake)
...@@ -162,4 +160,4 @@ if (SPDLOG_INSTALL) ...@@ -162,4 +160,4 @@ if (SPDLOG_INSTALL)
#--------------------------------------------------------------------------------------- #---------------------------------------------------------------------------------------
include(cmake/spdlogCPack.cmake) include(cmake/spdlogCPack.cmake)
endif () endif ()
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment