Merge pull request #1105 from jktjkt/do-not-impose-extra-warnings

Do not impose -Wextra -Wconversion etc on library users

Merge pull request #1105 from jktjkt/do-not-impose-extra-warnings
Do not impose -Wextra -Wconversion etc on library users
80740f0e · Gabi Melman · GitHub · e0b4ec54 · c60f7907 · 80740f0e
Unverified Commit 80740f0e authored Jun 10, 2019 by Gabi Melman Committed by GitHub Jun 10, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 6 deletions

CMakeLists.txt CMakeLists.txt +3 -6

No files found.
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -80,12 +80,10 @@ target_link_libraries(spdlog_header_only INTERFACE Threads::Threads)
 #---------------------------------------------------------------------------------------
 if(SPDLOG_MASTER_PROJECT)
    if (CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang|AppleClang")
-        target_compile_options( spdlog PUBLIC -Wall -Wextra -Wconversion -pedantic -Wfatal-errors)
-        target_compile_options( spdlog_header_only INTERFACE -Wall -Wextra -Wconversion -pedantic -Wfatal-errors)
+        target_compile_options( spdlog PRIVATE -Wall -Wextra -Wconversion -pedantic -Wfatal-errors)
    endif()
    if (CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
-        target_compile_options( spdlog PUBLIC /W3 /WX )
-        target_compile_options( spdlog_header_only INTERFACE /W3 /WX)
+        target_compile_options( spdlog PRIVATE /W3 /WX )
    endif()

    include(cmake/sanitizers.cmake)
@@ -162,4 +160,4 @@ if (SPDLOG_INSTALL)
    #---------------------------------------------------------------------------------------
    include(cmake/spdlogCPack.cmake)

-endif ()
\ No newline at end of file
+endif ()