added test for parsing 0e100

f7d2cd22 · John Stiles · 532cba14 · f7d2cd22 · f7d2cd22
Commit f7d2cd22 authored May 11, 2018 by John Stiles
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

diyfp.h include/rapidjson/internal/diyfp.h +1 -0

readertest.cpp test/unittest/readertest.cpp +1 -0

No files found.
--- a/include/rapidjson/internal/diyfp.h
+++ b/include/rapidjson/internal/diyfp.h
@@ -99,6 +99,7 @@ struct DiyFp {
    }

    DiyFp Normalize() const {
+        RAPIDJSON_ASSERT(f != 0); // https://stackoverflow.com/a/26809183/291737
 #if defined(_MSC_VER) && defined(_M_AMD64)
        unsigned long index;
        _BitScanReverse64(&index, f);

--- a/test/unittest/readertest.cpp
+++ b/test/unittest/readertest.cpp
@@ -207,6 +207,7 @@ static void TestParseDouble() {

    TEST_DOUBLE(fullPrecision, "0.0", 0.0);
    TEST_DOUBLE(fullPrecision, "-0.0", -0.0); // For checking issue #289
+    TEST_DOUBLE(fullPrecision, "0e100", 0.0); // Normalize() must not invoke __builtin_clzll(0)
    TEST_DOUBLE(fullPrecision, "1.0", 1.0);
    TEST_DOUBLE(fullPrecision, "-1.0", -1.0);
    TEST_DOUBLE(fullPrecision, "1.5", 1.5);