Skip to content

R
rapidjson
Unverified Commit c511ce30 authored by Milo Yip's avatar Milo Yip Committed by GitHub
Browse files
Options

Merge pull request #1250 from StilesCrisis/issue-1249-test 

Unit Test: Parsing "0e100" in full precision mode causes UB
parents 6cc3910a cad38057
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 0 deletions
include/rapidjson/internal/diyfp.h
View file @ c511ce30
...@@ -100,6 +100,7 @@ struct DiyFp { ...@@ -100,6 +100,7 @@ struct DiyFp {
} }
DiyFp Normalize() const { DiyFp Normalize() const {
RAPIDJSON_ASSERT(f != 0); // https://stackoverflow.com/a/26809183/291737
#if defined(_MSC_VER) && defined(_M_AMD64) #if defined(_MSC_VER) && defined(_M_AMD64)
unsigned long index; unsigned long index;
_BitScanReverse64(&index, f); _BitScanReverse64(&index, f);
......
test/unittest/readertest.cpp
View file @ c511ce30
...@@ -207,6 +207,7 @@ static void TestParseDouble() { ...@@ -207,6 +207,7 @@ static void TestParseDouble() {
TEST_DOUBLE(fullPrecision, "0.0", 0.0); TEST_DOUBLE(fullPrecision, "0.0", 0.0);
TEST_DOUBLE(fullPrecision, "-0.0", -0.0); // For checking issue #289 TEST_DOUBLE(fullPrecision, "-0.0", -0.0); // For checking issue #289
TEST_DOUBLE(fullPrecision, "0e100", 0.0); // For checking issue #1249
TEST_DOUBLE(fullPrecision, "1.0", 1.0); TEST_DOUBLE(fullPrecision, "1.0", 1.0);
TEST_DOUBLE(fullPrecision, "-1.0", -1.0); TEST_DOUBLE(fullPrecision, "-1.0", -1.0);
TEST_DOUBLE(fullPrecision, "1.5", 1.5); TEST_DOUBLE(fullPrecision, "1.5", 1.5);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment