Improve comment parsing code coverage

b8a27370 · Milo Yip · efe41402 · b8a27370
Commit b8a27370 authored Feb 03, 2016 by Milo Yip
Hide whitespace changes
Inline Side-by-side

Showing with 20 additions and 0 deletions

readertest.cpp test/unittest/readertest.cpp +20 -0

No files found.
--- a/test/unittest/readertest.cpp
+++ b/test/unittest/readertest.cpp
@@ -1459,6 +1459,26 @@ TEST(Reader, IncompleteMultilineComment) {
    EXPECT_EQ(kParseErrorUnspecificSyntaxError, reader.GetParseErrorCode());
 }

+TEST(Reader, IncompleteMultilineComment2) {
+    const char* json = "{\"hello\" : \"world\" /* *\0 */}";
+
+    StringStream s(json);
+    ParseObjectHandler h;
+    Reader reader;
+    EXPECT_FALSE(reader.Parse<kParseCommentsFlag>(s, h));
+    EXPECT_EQ(kParseErrorUnspecificSyntaxError, reader.GetParseErrorCode());
+}
+
+TEST(Reader, UnrecognizedComment) {
+    const char* json = "{\"hello\" : \"world\" /! }";
+
+    StringStream s(json);
+    ParseObjectHandler h;
+    Reader reader;
+    EXPECT_FALSE(reader.Parse<kParseCommentsFlag>(s, h));
+    EXPECT_EQ(kParseErrorUnspecificSyntaxError, reader.GetParseErrorCode());
+}
+
 #ifdef __GNUC__
 RAPIDJSON_DIAG_POP
 #endif