Skip to content

R
rapidjson
Commit 44f2f9aa authored by Étienne Dupuis's avatar Étienne Dupuis
Browse files
Options

Added relevant unit tests for issue #1108 suggested improvement.

parent 86e280f6
Hide whitespace changes
Inline Side-by-side
Showing with 7 additions and 2 deletions
test/unittest/pointertest.cpp
View file @ 44f2f9aa
...@@ -462,7 +462,8 @@ TEST(Pointer, ConstructorWithToken) { ...@@ -462,7 +462,8 @@ TEST(Pointer, ConstructorWithToken) {
TEST(Pointer, CopyConstructor) { TEST(Pointer, CopyConstructor) {
{ {
Pointer p("/foo/0"); CrtAllocator allocator;
Pointer p("/foo/0", &allocator);
Pointer q(p); Pointer q(p);
EXPECT_TRUE(q.IsValid()); EXPECT_TRUE(q.IsValid());
EXPECT_EQ(2u, q.GetTokenCount()); EXPECT_EQ(2u, q.GetTokenCount());
...@@ -471,6 +472,7 @@ TEST(Pointer, CopyConstructor) { ...@@ -471,6 +472,7 @@ TEST(Pointer, CopyConstructor) {
EXPECT_EQ(1u, q.GetTokens()[1].length); EXPECT_EQ(1u, q.GetTokens()[1].length);
EXPECT_STREQ("0", q.GetTokens()[1].name); EXPECT_STREQ("0", q.GetTokens()[1].name);
EXPECT_EQ(0u, q.GetTokens()[1].index); EXPECT_EQ(0u, q.GetTokens()[1].index);
EXPECT_EQ(&p.GetAllocator(), &q.GetAllocator());
} }
// Static tokens // Static tokens
...@@ -489,7 +491,8 @@ TEST(Pointer, CopyConstructor) { ...@@ -489,7 +491,8 @@ TEST(Pointer, CopyConstructor) {
TEST(Pointer, Assignment) { TEST(Pointer, Assignment) {
{ {
Pointer p("/foo/0"); CrtAllocator allocator;
Pointer p("/foo/0", &allocator);
Pointer q; Pointer q;
q = p; q = p;
EXPECT_TRUE(q.IsValid()); EXPECT_TRUE(q.IsValid());
...@@ -499,6 +502,7 @@ TEST(Pointer, Assignment) { ...@@ -499,6 +502,7 @@ TEST(Pointer, Assignment) {
EXPECT_EQ(1u, q.GetTokens()[1].length); EXPECT_EQ(1u, q.GetTokens()[1].length);
EXPECT_STREQ("0", q.GetTokens()[1].name); EXPECT_STREQ("0", q.GetTokens()[1].name);
EXPECT_EQ(0u, q.GetTokens()[1].index); EXPECT_EQ(0u, q.GetTokens()[1].index);
EXPECT_NE(&p.GetAllocator(), &q.GetAllocator());
q = q; q = q;
EXPECT_TRUE(q.IsValid()); EXPECT_TRUE(q.IsValid());
EXPECT_EQ(2u, q.GetTokenCount()); EXPECT_EQ(2u, q.GetTokenCount());
...@@ -507,6 +511,7 @@ TEST(Pointer, Assignment) { ...@@ -507,6 +511,7 @@ TEST(Pointer, Assignment) {
EXPECT_EQ(1u, q.GetTokens()[1].length); EXPECT_EQ(1u, q.GetTokens()[1].length);
EXPECT_STREQ("0", q.GetTokens()[1].name); EXPECT_STREQ("0", q.GetTokens()[1].name);
EXPECT_EQ(0u, q.GetTokens()[1].index); EXPECT_EQ(0u, q.GetTokens()[1].index);
EXPECT_NE(&p.GetAllocator(), &q.GetAllocator());
} }
// Static tokens // Static tokens
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment