• Jon Skeet's avatar
    Ensure that FieldMask, Timestamp and Duration ToString() calls don't throw · dd43dcca
    Jon Skeet authored
    The usage of ICustomDiagnosticMessage here is non-essential - ToDiagnosticString
    doesn't actually get called by ToString() in this case, due to JsonFormatter code. It was
    intended to make it clearer that it *did* have a custom format... but then arguably I should
    do the same for Value, Struct, Any etc.
    
    Moving some of the code out of JsonFormatter and into Duration/Timestamp/FieldMask likewise
    feels somewhat nice, somewhat nasty... basically there are JSON-specific bits of formatting, but
    also domain-specific bits of computation. <sigh>
    
    Thoughts welcome.
    dd43dcca
Name
Last commit
Last update
..
Collections Loading commit data...
Compatibility Loading commit data...
Properties Loading commit data...
Reflection Loading commit data...
WellKnownTypes Loading commit data...
ByteArray.cs Loading commit data...
ByteString.cs Loading commit data...
CodedInputStream.cs Loading commit data...
CodedOutputStream.ComputeSize.cs Loading commit data...
CodedOutputStream.cs Loading commit data...
FieldCodec.cs Loading commit data...
FrameworkPortability.cs Loading commit data...
Google.Protobuf.csproj Loading commit data...
Google.Protobuf.nuspec Loading commit data...
ICustomDiagnosticMessage.cs Loading commit data...
IDeepCloneable.cs Loading commit data...
IMessage.cs Loading commit data...
InvalidJsonException.cs Loading commit data...
InvalidProtocolBufferException.cs Loading commit data...
JsonFormatter.cs Loading commit data...
JsonParser.cs Loading commit data...
JsonToken.cs Loading commit data...
JsonTokenizer.cs Loading commit data...
LimitedInputStream.cs Loading commit data...
MessageExtensions.cs Loading commit data...
MessageParser.cs Loading commit data...
Preconditions.cs Loading commit data...
WireFormat.cs Loading commit data...
packages.config Loading commit data...