• Jon Skeet's avatar
    Ensure that FieldMask, Timestamp and Duration ToString() calls don't throw · dd43dcca
    Jon Skeet authored
    The usage of ICustomDiagnosticMessage here is non-essential - ToDiagnosticString
    doesn't actually get called by ToString() in this case, due to JsonFormatter code. It was
    intended to make it clearer that it *did* have a custom format... but then arguably I should
    do the same for Value, Struct, Any etc.
    
    Moving some of the code out of JsonFormatter and into Duration/Timestamp/FieldMask likewise
    feels somewhat nice, somewhat nasty... basically there are JSON-specific bits of formatting, but
    also domain-specific bits of computation. <sigh>
    
    Thoughts welcome.
    dd43dcca
Name
Last commit
Last update
benchmarks Loading commit data...
cmake Loading commit data...
conformance Loading commit data...
csharp Loading commit data...
editors Loading commit data...
examples Loading commit data...
java Loading commit data...
javanano Loading commit data...
js Loading commit data...
m4 Loading commit data...
more_tests Loading commit data...
objectivec Loading commit data...
protoc-artifacts Loading commit data...
python Loading commit data...
ruby Loading commit data...
src Loading commit data...
util/python Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
BUILD Loading commit data...
CHANGES.txt Loading commit data...
CONTRIBUTORS.txt Loading commit data...
LICENSE Loading commit data...
Makefile.am Loading commit data...
Protobuf.podspec Loading commit data...
README.md Loading commit data...
WORKSPACE Loading commit data...
appveyor.bat Loading commit data...
appveyor.yml Loading commit data...
autogen.sh Loading commit data...
configure.ac Loading commit data...
generate_descriptor_proto.sh Loading commit data...
gmock.BUILD Loading commit data...
post_process_dist.sh Loading commit data...
protobuf-lite.pc.in Loading commit data...
protobuf.bzl Loading commit data...
protobuf.pc.in Loading commit data...
six.BUILD Loading commit data...
travis.sh Loading commit data...
update_file_lists.sh Loading commit data...