• Paul Yang's avatar
    Php 7.3 fix (#5434) · d7c44095
    Paul Yang authored
    * Inherit from message instead of implement
    
    When regestering class (implmenets other class) during MINIT, zend_class_implements
    would call zend_class_entry->interface_gets_implemented(). In PHP-7.3 interface_gets_implemented shares the same location with create_object.
    However, during MINIT, the global object storeage hasn't been initialized. And thus, caused segment fault in php 7.3.
    
    * Use zend_string_init where interned string may be the value.
    zend_string_dup will keep using the existing interned string.
    In php 7.3, interned string cannot be destroyed from user's code.
    
    * Uncommment debug code
    
    * Use latest phpunit for each php versions
    
    * Revert change in Dockerfile
    
    * Update php test to use the new docker image
    
    * Update composer
    
    * Change docker organization
    
    * Update phpunit
    
    * Debug phpunit
    
    * Store phpunit into bin dir in docker image
    
    * Install valgrind to docker
    
    * Fix compatibility test
    
    * Remove generated_service_test from compatibility c extension test
    
    * Update 32bit php test to the new docker image
    
    * Install bison
    
    * Fix build.sh
    
    * Fix DOCKERIMAGE_PREFIX
    
    * Fix basename
    
    * Add comment to build_and_run_docker2.sh
    
    * Remove commented code
    
    * Fix comments
    d7c44095
Name
Last commit
Last update
.github/ISSUE_TEMPLATE Loading commit data...
benchmarks Loading commit data...
cmake Loading commit data...
conformance Loading commit data...
csharp Loading commit data...
docs Loading commit data...
editors Loading commit data...
examples Loading commit data...
java Loading commit data...
js Loading commit data...
kokoro Loading commit data...
m4 Loading commit data...
objectivec Loading commit data...
php Loading commit data...
protoc-artifacts Loading commit data...
python Loading commit data...
ruby Loading commit data...
src Loading commit data...
third_party Loading commit data...
util/python Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
BUILD Loading commit data...
CHANGES.txt Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS.txt Loading commit data...
LICENSE Loading commit data...
Makefile.am Loading commit data...
Protobuf.podspec Loading commit data...
README.md Loading commit data...
WORKSPACE Loading commit data...
appveyor.bat Loading commit data...
appveyor.yml Loading commit data...
autogen.sh Loading commit data...
compiler_config_setting.bzl Loading commit data...
composer.json Loading commit data...
configure.ac Loading commit data...
generate_changelog.py Loading commit data...
generate_descriptor_proto.sh Loading commit data...
post_process_dist.sh Loading commit data...
protobuf-lite.pc.in Loading commit data...
protobuf.bzl Loading commit data...
protobuf.pc.in Loading commit data...
six.BUILD Loading commit data...
tests.sh Loading commit data...
update_file_lists.sh Loading commit data...
update_version.py Loading commit data...