• Jon Skeet's avatar
    Implemented Jan's suggestion of FieldCollection, replacing FieldAccessorCollection. · c1c6b2d0
    Jon Skeet authored
    I think Jan was actually suggesting keeping both, but that feels redundant to me. The test diff is misleading here IMO, because I wouldn't expect real code using reflection to use several accessors one after another like this, unless it was within a loop. Evidence to the contrary would be welcome :)
    
    This change also incidentally goes part way to fixing the issue of the JSON formatter not writing out the fields in field number order - with this change, it does except for oneofs, which we can fix in a follow-up change.
    
    I haven't actually added a test with a message with fields deliberately out of order - I'm happy to do so though. It feels like it would make sense to be in google/src/protobuf, but it's not entirely clear what the rules of engagement are for adding new messages there. (unittest_proto3.proto?)
    c1c6b2d0
Name
Last commit
Last update
..
Collections Loading commit data...
Properties Loading commit data...
Reflection Loading commit data...
TestProtos Loading commit data...
WellKnownTypes Loading commit data...
ByteStringTest.cs Loading commit data...
CodedInputStreamExtensions.cs Loading commit data...
CodedInputStreamTest.cs Loading commit data...
CodedOutputStreamTest.cs Loading commit data...
DeprecatedMemberTest.cs Loading commit data...
EqualityTester.cs Loading commit data...
FieldCodecTest.cs Loading commit data...
GeneratedMessageTest.cs Loading commit data...
Google.Protobuf.Test.csproj Loading commit data...
IssuesTest.cs Loading commit data...
JsonFormatterTest.cs Loading commit data...
SampleEnum.cs Loading commit data...
SampleMessages.cs Loading commit data...
TestCornerCases.cs Loading commit data...
packages.config Loading commit data...