• Andrei-Florin BENCSIK's avatar
    Remove unused function and add more UTs · 97b18021
    Andrei-Florin BENCSIK authored
    When browsing around the strutil files I found a function
    that was never referenced inside the code base
    "void StripString(string* s, const char* remove,
    -                                 char replacewith);"
    
    The name was kind of misleading as well and it seems like
    it's a carbon copy of
    "void ReplaceCharacters(string* s, const char* remove,
                                           char replacewith);"
    (even the parameter names are the same, the code is the same..)
    
    Is it intentional? Maybe for compatibility reasons? If so,
    let's make it deprecated and use the ReplaceCharacters method inside
    or the other way around.
    
    Also, noticed there were no tests for "StripString" or "Replace".
    Added some for both and planning on maybe making it more C++ish (?)
    in another commit.
    97b18021
Name
Last commit
Last update
.github Loading commit data...
benchmarks Loading commit data...
cmake Loading commit data...
conformance Loading commit data...
csharp Loading commit data...
docs Loading commit data...
editors Loading commit data...
examples Loading commit data...
java Loading commit data...
js Loading commit data...
kokoro Loading commit data...
m4 Loading commit data...
objectivec Loading commit data...
php Loading commit data...
protoc-artifacts Loading commit data...
python Loading commit data...
ruby Loading commit data...
src Loading commit data...
third_party Loading commit data...
util/python Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
BUILD Loading commit data...
CHANGES.txt Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS.txt Loading commit data...
LICENSE Loading commit data...
Makefile.am Loading commit data...
Protobuf-C++.podspec Loading commit data...
Protobuf.podspec Loading commit data...
README.md Loading commit data...
WORKSPACE Loading commit data...
appveyor.bat Loading commit data...
appveyor.yml Loading commit data...
autogen.sh Loading commit data...
build_files_updated_unittest.sh Loading commit data...
compiler_config_setting.bzl Loading commit data...
composer.json Loading commit data...
configure.ac Loading commit data...
generate_changelog.py Loading commit data...
generate_descriptor_proto.sh Loading commit data...
global.json Loading commit data...
post_process_dist.sh Loading commit data...
protobuf-lite.pc.in Loading commit data...
protobuf.bzl Loading commit data...
protobuf.pc.in Loading commit data...
protobuf_deps.bzl Loading commit data...
tests.sh Loading commit data...
update_compatibility_version.py Loading commit data...
update_file_lists.sh Loading commit data...
update_version.py Loading commit data...