• Paul Yang's avatar
    Php 7.3 fix (#5434) · d7c44095
    Paul Yang authored
    * Inherit from message instead of implement
    
    When regestering class (implmenets other class) during MINIT, zend_class_implements
    would call zend_class_entry->interface_gets_implemented(). In PHP-7.3 interface_gets_implemented shares the same location with create_object.
    However, during MINIT, the global object storeage hasn't been initialized. And thus, caused segment fault in php 7.3.
    
    * Use zend_string_init where interned string may be the value.
    zend_string_dup will keep using the existing interned string.
    In php 7.3, interned string cannot be destroyed from user's code.
    
    * Uncommment debug code
    
    * Use latest phpunit for each php versions
    
    * Revert change in Dockerfile
    
    * Update php test to use the new docker image
    
    * Update composer
    
    * Change docker organization
    
    * Update phpunit
    
    * Debug phpunit
    
    * Store phpunit into bin dir in docker image
    
    * Install valgrind to docker
    
    * Fix compatibility test
    
    * Remove generated_service_test from compatibility c extension test
    
    * Update 32bit php test to the new docker image
    
    * Install bison
    
    * Fix build.sh
    
    * Fix DOCKERIMAGE_PREFIX
    
    * Fix basename
    
    * Add comment to build_and_run_docker2.sh
    
    * Remove commented code
    
    * Fix comments
    d7c44095
Name
Last commit
Last update
..
Dockerfile Loading commit data...
build.sh Loading commit data...
continuous.cfg Loading commit data...
presubmit.cfg Loading commit data...