• Peter Kasting's avatar
    Fix compile failures building protobuf DLLs on MSVC in Chromium's codebase. · 6e549997
    Peter Kasting authored
    When trying to compile the protobuf code as a DLL, and then compile other DLLs
    with generated .pb.cc/h files that reference
    InternalMetadataWithArena::InternalMetadataWithArena(Arena*), MSVC gives an
    "unresolved external symbol" error.  This seems to be due to the function being
    simultaneously exported and inline.  Moving it out-of-line fixes things.
    
    There are other functions exported and inline as well but de-inlining them
    doesn't seem to be necessary to get the build working, and I'd rather de-inline
    as few functions as possible.
    6e549997
Name
Last commit
Last update
benchmarks Loading commit data...
cmake Loading commit data...
conformance Loading commit data...
csharp Loading commit data...
editors Loading commit data...
examples Loading commit data...
java Loading commit data...
javanano Loading commit data...
m4 Loading commit data...
more_tests Loading commit data...
objectivec Loading commit data...
protoc-artifacts Loading commit data...
python Loading commit data...
ruby Loading commit data...
src Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
BUILD Loading commit data...
CHANGES.txt Loading commit data...
CONTRIBUTORS.txt Loading commit data...
INSTALL.txt Loading commit data...
LICENSE Loading commit data...
Makefile.am Loading commit data...
Protobuf.podspec Loading commit data...
README.md Loading commit data...
WORKSPACE Loading commit data...
appveyor.bat Loading commit data...
appveyor.yml Loading commit data...
autogen.sh Loading commit data...
configure.ac Loading commit data...
generate_descriptor_proto.sh Loading commit data...
gmock.BUILD Loading commit data...
post_process_dist.sh Loading commit data...
protobuf-lite.pc.in Loading commit data...
protobuf.pc.in Loading commit data...
travis.sh Loading commit data...
update_file_lists.sh Loading commit data...