• Thomas Van Lenten's avatar
    Rename methods to avoid ObjC KVC collisions. (#1699) · a230b5d2
    Thomas Van Lenten authored
    Note: Breaking API change on the Dictionary classes.
    
    The numeric value classes were using "Value" in the naming, but this silently
    collided with the KVC category on NSObject; meaning KVC code could break up a
    keypath and call these selectors with the wrong types leading to crashes (even
    though the code all would compile cleanly).
    
    - Rename the methods to use the "type" instead of literal "Value".
    - Update all the impls and tests.
    - Enable the warning that will catch issues like this in the future.
    
    Fixes https://github.com/google/protobuf/issues/1616
    a230b5d2
Name
Last commit
Last update
..
CocoaPods Loading commit data...
iOSTestHarness Loading commit data...
GPBARCUnittestProtos.m Loading commit data...
GPBArrayTests.m Loading commit data...
GPBCodedInputStreamTests.m Loading commit data...
GPBCodedOuputStreamTests.m Loading commit data...
GPBConcurrencyTests.m Loading commit data...
GPBDescriptorTests.m Loading commit data...
GPBDictionaryTests+Bool.m Loading commit data...
GPBDictionaryTests+Int32.m Loading commit data...
GPBDictionaryTests+Int64.m Loading commit data...
GPBDictionaryTests+String.m Loading commit data...
GPBDictionaryTests+UInt32.m Loading commit data...
GPBDictionaryTests+UInt64.m Loading commit data...
GPBDictionaryTests.pddm Loading commit data...
GPBMessageTests+Merge.m Loading commit data...
GPBMessageTests+Runtime.m Loading commit data...
GPBMessageTests+Serialization.m Loading commit data...
GPBMessageTests.m Loading commit data...
GPBObjectiveCPlusPlusTest.mm Loading commit data...
GPBPerfTests.m Loading commit data...
GPBSwiftTests.swift Loading commit data...
GPBTestUtilities.h Loading commit data...
GPBTestUtilities.m Loading commit data...
GPBUnittestProtos.m Loading commit data...
GPBUnknownFieldSetTest.m Loading commit data...
GPBUtilitiesTests.m Loading commit data...
GPBWellKnownTypesTest.m Loading commit data...
GPBWireFormatTests.m Loading commit data...
UnitTests-Bridging-Header.h Loading commit data...
UnitTests-Info.plist Loading commit data...
golden_message Loading commit data...
golden_packed_fields_message Loading commit data...
text_format_map_unittest_data.txt Loading commit data...
text_format_unittest_data.txt Loading commit data...
unittest_cycle.proto Loading commit data...
unittest_objc.proto Loading commit data...
unittest_objc_startup.proto Loading commit data...
unittest_runtime_proto2.proto Loading commit data...
unittest_runtime_proto3.proto Loading commit data...