• Andrei-Florin BENCSIK's avatar
    Remove unused function and add more UTs · 97b18021
    Andrei-Florin BENCSIK authored
    When browsing around the strutil files I found a function
    that was never referenced inside the code base
    "void StripString(string* s, const char* remove,
    -                                 char replacewith);"
    
    The name was kind of misleading as well and it seems like
    it's a carbon copy of
    "void ReplaceCharacters(string* s, const char* remove,
                                           char replacewith);"
    (even the parameter names are the same, the code is the same..)
    
    Is it intentional? Maybe for compatibility reasons? If so,
    let's make it deprecated and use the ReplaceCharacters method inside
    or the other way around.
    
    Also, noticed there were no tests for "StripString" or "Replace".
    Added some for both and planning on maybe making it more C++ish (?)
    in another commit.
    97b18021
Name
Last commit
Last update
..
google/protobuf Loading commit data...
solaris Loading commit data...
Makefile.am Loading commit data...
README.md Loading commit data...
libprotobuf-lite.map Loading commit data...
libprotobuf.map Loading commit data...
libprotoc.map Loading commit data...