1. 11 Jun, 2018 1 commit
  2. 06 Jun, 2018 1 commit
  3. 04 Jun, 2018 1 commit
  4. 01 Jun, 2018 1 commit
  5. 30 May, 2018 1 commit
  6. 24 May, 2018 1 commit
  7. 23 May, 2018 1 commit
    • Calder Coalson's avatar
      Declare 'google' namespace when importing Python protobuf via Bazel. · 142cbe0d
      Calder Coalson authored
      `python/google/__init__.py` declares the top-level 'google' namespace so that
      `google.protobuf` can be imported alongside other Google Python modules like
      `google.auth`.
      
      This works well when installing protobuf via Pip, but the Bazel `//:python_srcs`
      rule doesn't include this file in its `srcs`. Bazel implicitly creates an empty
      `google/__init__.py`, which does *not* set up a namespace. The result is that
      consuming Python protobuf via Bazel breaks all other Google Python libraries.
      
      This fixes #4658.
      142cbe0d
  8. 22 May, 2018 1 commit
  9. 26 Mar, 2018 1 commit
  10. 23 Mar, 2018 1 commit
  11. 22 Mar, 2018 2 commits
  12. 09 Mar, 2018 1 commit
  13. 02 Mar, 2018 1 commit
  14. 24 Feb, 2018 2 commits
  15. 31 Jan, 2018 1 commit
    • David Ostrovsky's avatar
      Bazel: Support building with Java 9 · 85b488f7
      David Ostrovsky authored
      Fixes: #4256.
      
      Bazel@HEAD supports Java 9.
      
      The current code has one single issue with Java 9 compliance: the usage
      of sun.misc package. We add jdk.unsupported module with --add-modules
      compiler option for now. Long term, the usage of non public API should
      be avoided.
      
      To build with Java 9, build custom bazel version and issue:
      
        $ bazel --host_javabase=/usr/lib64/jvm/java-9-openjdk build \
          --javacopt='--release 9' \
          --java_toolchain=@bazel_tools//tools/jdk:toolchain_jdk9 \
         :protobuf_java
      85b488f7
  16. 25 Jan, 2018 1 commit
  17. 07 Dec, 2017 1 commit
  18. 18 Nov, 2017 1 commit
    • Justine Tunney's avatar
      Remove unhelpful build warnings · ac5371d1
      Justine Tunney authored
      -Wno-writable-strings removes 230 "ISO C++11 does not allow conversion from
      string literal to 'char *'" warnings from TensorFlow test / build output.
      These happen because pyext/ sources pass string literals to Python C API data
      structures, e.g. PyGetSetDef, which for some reason were designed to not have
      the const qualifier.
      ac5371d1
  19. 18 Oct, 2017 1 commit
  20. 16 Oct, 2017 2 commits
    • Param Reddy's avatar
      Fix iOS cc_library build for protobuf. · 3130ce03
      Param Reddy authored
      The SDK and os versions were hard coded.  Archs were mixed up.
      Because of this,  Was getting errors with latest SDK:
      clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
      clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
      clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
      In file included from external/com_google_protobuf/src/google/protobuf/io/printer.cc:35:
      In file included from external/com_google_protobuf/src/google/protobuf/io/printer.h:40:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string:470:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string_view:171:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__string:56:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/algorithm:638:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/cstring:61:
      /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string.h:61:15: fatal error: 'string.h' file not found
                    ^~~~~~~~~~
                    1 error generated.
      
      Currently none of these are needed when using bazel with https://github.com/bazelbuild/rules_apple.
      -target arm64-apple-ios is passed properly to clang.  So -arch armv7 etc are not needed.
      OS_IOS is not used anywhere.
      Sources have:  GOOGLE_PROTOBUF_NO_THREADLOCAL defined in src/google/protobuf/stubs/platform_macros.h for iOS.  So __thread= is not needed.  In fact now that bazel is using C++11 by default,  __thread should ideally be moved to thread_local.
      -miphoneos-version-min is passed by rules_apple.
      3130ce03
    • Param Reddy's avatar
      Fix iOS cc_library build for protobuf. · 16792c62
      Param Reddy authored
      The SDK and os versions were hard coded.  Archs were mixed up.
      Because of this,  Was getting errors with latest SDK:
      clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
      clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
      clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
      In file included from external/com_google_protobuf/src/google/protobuf/io/printer.cc:35:
      In file included from external/com_google_protobuf/src/google/protobuf/io/printer.h:40:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string:470:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string_view:171:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__string:56:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/algorithm:638:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/cstring:61:
      /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string.h:61:15: fatal error: 'string.h' file not found
                    ^~~~~~~~~~
                    1 error generated.
      
      Currently none of these are needed when using bazel with https://github.com/bazelbuild/rules_apple.
      -target arm64-apple-ios is passed properly to clang.  So -arch armv7 etc are not needed.
      OS_IOS is not used anywhere.
      Sources have:  GOOGLE_PROTOBUF_NO_THREADLOCAL defined in src/google/protobuf/stubs/platform_macros.h for iOS.  So __thread= is not needed.  In fact now that bazel is using C++11 by default,  __thread should ideally be moved to thread_local.
      -miphoneos-version-min is passed by rules_apple.
      16792c62
  21. 10 Oct, 2017 1 commit
  22. 14 Sep, 2017 1 commit
  23. 12 Sep, 2017 1 commit
  24. 05 Sep, 2017 1 commit
    • Jakob Buchgraber's avatar
      bazel: Add proto_library rules for well known types. Fixes #2763 · 699c0eb9
      Jakob Buchgraber authored
      Adds a proto_library rule for each well known type proto:
      
      $ bazel query "filter(\".*_proto$\", \"...\")"
      //:wrappers_proto
      //:timestamp_proto
      //:struct_proto
      //:field_mask_proto
      //:empty_proto
      //:duration_proto
      //:compiler_plugin_proto
      //:descriptor_proto
      //:api_proto
      //:type_proto
      //:source_context_proto
      //:any_proto
      
      Bazel users can reference these proto_library rules for their own
      language specific rules i.e.
      
      java_proto_library(
        name = "any_java_proto",
        deps = ["@com_google_protobuf//:any_proto"],
      )
      
      Also set the workspace name to "com_google_protobuf", as proto_library
      rules reference protobuf that way.
      699c0eb9
  25. 25 Jul, 2017 3 commits
  26. 19 Jul, 2017 1 commit
  27. 11 Jul, 2017 1 commit
  28. 16 Jun, 2017 1 commit
  29. 31 May, 2017 1 commit
  30. 04 May, 2017 1 commit
  31. 01 May, 2017 1 commit
  32. 29 Mar, 2017 2 commits
  33. 22 Mar, 2017 1 commit
  34. 20 Mar, 2017 1 commit