1. 18 Oct, 2019 2 commits
  2. 16 Oct, 2019 1 commit
  3. 15 Oct, 2019 3 commits
  4. 14 Oct, 2019 2 commits
  5. 12 Oct, 2019 1 commit
    • Alan Wu's avatar
      Remove unused argument to avoid UB · c1ba7c64
      Alan Wu authored
      `OneOfDescriptor_each` is registered as a Ruby method which takes zero
      parameters, which means it should take one argument.
      
      When Ruby invokes `OneOfDescriptor_each`, it calls it with one parameter
      only, which is one less than what `OneOfDescriptor_each` takes before
      this commit. Calling a function with the wrong number of argument is
      technically undefined behavior.
      
      See also: §6.5.2.2, N1256
      c1ba7c64
  6. 11 Oct, 2019 2 commits
  7. 10 Oct, 2019 2 commits
  8. 08 Oct, 2019 1 commit
  9. 07 Oct, 2019 1 commit
  10. 04 Oct, 2019 2 commits
  11. 03 Oct, 2019 5 commits
  12. 30 Sep, 2019 7 commits
  13. 27 Sep, 2019 3 commits
    • Andrei-Florin BENCSIK's avatar
      Remove unused function and add more UTs · 97b18021
      Andrei-Florin BENCSIK authored
      When browsing around the strutil files I found a function
      that was never referenced inside the code base
      "void StripString(string* s, const char* remove,
      -                                 char replacewith);"
      
      The name was kind of misleading as well and it seems like
      it's a carbon copy of
      "void ReplaceCharacters(string* s, const char* remove,
                                             char replacewith);"
      (even the parameter names are the same, the code is the same..)
      
      Is it intentional? Maybe for compatibility reasons? If so,
      let's make it deprecated and use the ReplaceCharacters method inside
      or the other way around.
      
      Also, noticed there were no tests for "StripString" or "Replace".
      Added some for both and planning on maybe making it more C++ish (?)
      in another commit.
      97b18021
    • Changming Sun's avatar
      Fix #6098 · 95a1c4fb
      Changming Sun authored
      95a1c4fb
    • Sigurd Meldgaard's avatar
      Add option for dart · f4a3e061
      Sigurd Meldgaard authored
      f4a3e061
  14. 26 Sep, 2019 3 commits
  15. 25 Sep, 2019 2 commits
  16. 20 Sep, 2019 3 commits