1. 10 Jan, 2014 1 commit
    • Max Cai's avatar
      Extension overhaul. · e3714f00
      Max Cai authored
      - Get rid of TypeLiteral<T>. It was introduced to read the component
        type of a List<T> at runtime. But we use arrays everywhere else,
        and we can always read the component type of an array type at
        runtime.
      - Properly read/write "minor" types (e.g. sint32, sfixed32). The old
        implementation could only read/write data as the "typical" types
        (one per Java type), e.g. java.lang.Integer -> int32, java.lang.Long
        -> int64. So if e.g. an extension specifies sfixed32 as the type, it
        would be read/written in the totally incompatible int32 format.
      - Properly serialize repeated packed fields. The old implementation
        doesn't do packed serialization. As an added bonus, and to be more
        aligned with the rest of protobuf nano / main, repeated packable
        extensions can deserialize both packed and non-packed data.
      - Split Extension class into a hierarchy so under typical usage a
        large chunk of code dealing with primitive type extensions can be
        removed by ProGuard.
      
      Bug: https://code.google.com/p/android/issues/detail?id=62586
      Change-Id: I0d692f35cc2a8ad3a5a1cb3ce001282b2356b041
      e3714f00
  2. 19 Dec, 2013 1 commit
  3. 12 Dec, 2013 1 commit
    • Andrew Flynn's avatar
      Fix MessageNanoPrinter for accessors · 02a9ea00
      Andrew Flynn authored
      accessors mode switches proto fields away from being public fields (which is
      how MessageNanoPrinter found which fields to print via reflection). Add a
      pass through the methods looking for generated accessor methods to print
      those as well.
      
      Change-Id: I7c47853ecbd5534086f44b25a89dbbe56f63ed03
      02a9ea00
  4. 10 Dec, 2013 3 commits
    • Max Cai's avatar
      b3bc6095
    • Max Cai's avatar
      Avoid class initializers to help ProGuard. · 04feb76f
      Max Cai authored
      Class initializers prevent ProGuard from inlining any methods
      because it thinks the class initializer may have side effects.
      This is true for static methods, but instance methods can still
      be inlined, because to have an instance you will have touched
      the class and any class initializers would have run. But
      ProGuard only starts inlining instance methods of classes with
      class initializers from v4.11b6, and Android uses v4.4 now.
      
      This change tries to avoid the class initializers as much as
      possible, by delaying the initialization of the empty array and
      some fields' saved defaults until when they're needed. However,
      if the message hosts any extensions, they must be public static
      final and therefore introducing the class initializer. In that
      case we won't bother with lazy initialization.
      
      Change-Id: I00d8296f6eb0023112b93ee135cdb28dbd52b0b8
      04feb76f
    • Max Cai's avatar
  5. 09 Dec, 2013 1 commit
    • Andrew Flynn's avatar
      Nano: don't generate accessor methods for nested methods · c997c136
      Andrew Flynn authored
      For nested message objects, don't generate accessor methods because they have
      a default value that is not a valid value (null), so there is no reason to have
      get/set/has/clear methods for them. Clients and protos (while serializing) can
      check against the invalid value to see if it's been set.
      
      Change-Id: Ic63400889581271b8cbcd9c45c84519d4921fd4b
      c997c136
  6. 05 Dec, 2013 1 commit
  7. 22 Nov, 2013 1 commit
  8. 18 Nov, 2013 2 commits
  9. 15 Nov, 2013 5 commits
  10. 13 Nov, 2013 1 commit
  11. 12 Nov, 2013 2 commits
  12. 11 Nov, 2013 1 commit
    • Tom Chao's avatar
      Minimize method count for nanoproto. · 28b4dec7
      Tom Chao authored
      - Migrates getCachedSize to the MessageNano parent class to save one method per message.
      - Create ExtendableMessageNano parent class for protos with extensions, this saves the
      getExtension and setExtension methods on the relevant messages.
      - getSerializedSize's default case (with no fields to serialize) also migrate to the
      parent class, which saves methods on empty messages.
      - Container classes become interfaces to save the constructor.
      
      Change-Id: I81f1a1b6d6a660096835e9df3ea20456655aab4a
      28b4dec7
  13. 07 Nov, 2013 1 commit
  14. 06 Nov, 2013 1 commit
  15. 05 Nov, 2013 1 commit
    • Aurash Mahbod's avatar
      Allow for ref-type arrays containing null elements. · 3f0c3480
      Aurash Mahbod authored
      Strip the null elements out before serializing the array.
      This is helpful in the cases where the user wants to construct
      an array of an inexact size for serialization. For example:
      User constructs array of size 5 because they anticipate adding
      more than 1 element before serialization. Only 3 get added, so
      the array looks like [Obj, Obj, Obj, null, null]. This would
      curently crash without this CL.
      
      All repeated fields of ref-type elements can contain null
      elements: repeated strings, repeated bytes, and repeated
      messages/groups.
      
      Change-Id: I117391c868c9a436536d70d6151780e9cc7e8227
      
      Conflicts:
      	src/google/protobuf/compiler/javanano/javanano_message_field.cc
      3f0c3480
  16. 25 Oct, 2013 3 commits
  17. 16 Oct, 2013 8 commits
  18. 15 Oct, 2013 5 commits
  19. 11 Oct, 2013 1 commit