1. 06 Apr, 2017 1 commit
  2. 17 Mar, 2017 1 commit
    • Adam Cozzette's avatar
      Ruby: only link against specific version of memcpy if we're using glibc · ea5ef14a
      Adam Cozzette authored
      We have some special code in wrap_memcpy.c to ensure that we use the
      2.2.5 version of memcpy, for compatibility with older versions of glibc.
      However, we need to make sure we only attempt to do this when we are
      actually building with glibc, so that the code can also build
      successfully against other libc implementations such as musl.
      ea5ef14a
  3. 15 Mar, 2017 4 commits
  4. 14 Mar, 2017 1 commit
  5. 09 Mar, 2017 1 commit
    • Adam Cozzette's avatar
      Ruby: wrap calls to memcpy so that gem is compatible with pre-2.14 glibc · 9fa40314
      Adam Cozzette authored
      This commit adds a __wrap_memcpy function and a linker flag to use that
      in place of memcpy for our Ruby gem C extension. This allows us to
      always use the 2.2.5 version of memcpy, making it possible to use the
      gem on distributions with pre-2.14 versions of glibc.
      
      Before this change:
      $ objdump -T protobuf_c.so | grep memcpy
      0000000000000000      DF *UND*  0000000000000000  GLIBC_2.3.4 __memcpy_chk
      0000000000000000      DF *UND*  0000000000000000  GLIBC_2.14  memcpy
      
      After:
      $ objdump -T protobuf_c.so | grep memcpy
      0000000000000000      DF *UND*  0000000000000000  GLIBC_2.2.5 memcpy
      0000000000000000      DF *UND*  0000000000000000  GLIBC_2.3.4 __memcpy_chk
      0000000000042450 g    DF .text  0000000000000005  Base __wrap_memcpy
      
      This is based on gRPC's solution to a similar problem:
      https://github.com/grpc/grpc/blob/5098508d2d41a116113f7e333c516cd9ef34a943/src/core/lib/support/wrap_memcpy.c
      
      This fixes issue #2783.
      9fa40314
  6. 28 Feb, 2017 3 commits
  7. 31 Jan, 2017 1 commit
    • Paul Yang's avatar
      Merge 3.2.x branch into master (#2648) · 7f3e2370
      Paul Yang authored
      * Down-integrate internal changes to github.
      
      * Update conformance test failure list.
      
      * Explicitly import used class in nano test to avoid random test fail.
      
      * Update _GNUC_VER to use the correct implementation of atomic operation
      on Mac.
      
      * maps_test.js: check whether Symbol is defined before using it (#2524)
      
      Symbol is not yet available on older versions of Node.js and so this
      test fails with them. This change just directly checks whether Symbol is
      available before we try to use it.
      
      * Added well_known_types_embed.cc to CLEANFILES so that it gets cleaned up
      
      * Updated Makefile.am to fix out-of-tree builds
      
      * Added Bazel genrule for generating well_known_types_embed.cc
      
      In pull request #2517 I made this change for the CMake and autotools
      builds but forgot to do it for the Bazel build.
      
      * Update _GNUC_VER to use the correct implementation of atomic operation on Mac.
      
      * Add new js file in extra dist.
      
      * Bump version number to 3.2.0
      
      * Fixed issue with autoloading - Invalid paths (#2538)
      
      * PHP fix int64 decoding (#2516)
      
      * fix int64 decoding
      
      * fix int64 decoding + tests
      
      * Fix int64 decoding on 32-bit machines.
      
      * Fix warning in compiler/js/embed.cc
      
      embed.cc: In function ‘std::string CEscape(const string&)’:
      embed.cc:51:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
         for (int i = 0; i < str.size(); ++i) {
                                      ^
      
      * Fix include in auto-generated well_known_types_embed.cc
      
      Restore include style fix (e3da722b) that has been trampled by
      auto-generation of well_known_types_embed.cc
      
      * Fixed cross compilations with the Autotools build
      
      Pull request #2517 caused cross compilations to start failing, because
      the js_embed binary was being built to run on the target platform
      instead of on the build machine. This change updates the Autotools build
      to use the AX_PROG_CXX_FOR_BUILD macro to find a suitable compiler for
      the build machine and always use that when building js_embed.
      
      * Minor fix for autocreated object repeated fields and maps.
      
      - If setting/clearing a repeated field/map that was objects, check the class
        before checking the autocreator.
      - Just to be paranoid, don’t mutate within copy/mutableCopy for the autocreated
        classes to ensure there is less chance of issues if someone does something
        really crazy threading wise.
      - Some more tests for the internal AutocreatedArray/AutocreatedDictionary
        classes to ensure things are working as expected.
      - Add Xcode 8.2 to the full_mac_build.sh supported list.
      
      * Fix generation of extending nested messages in JavaScript (#2439)
      
      * Fix generation of extending nested messages in JavaScript
      
      * Added missing test8.proto to build
      
      * Fix generated code when there is no namespace but there is enum definition.
      
      * Decoding unknown field should succeed.
      
      * Add embed.cc in src/Makefile.am to fix dist check.
      
      * Fixed "make distcheck" for the Autotools build
      
      To make the test pass I needed to fix out-of-tree builds and update
      EXTRA_DIST and CLEANFILES.
      
      * Remove redundent embed.cc from src/Makefile.am
      
      * Update version number to 3.2.0-rc.1 (#2578)
      
      * Change protoc-artifacts version to 3.2.0-rc.1
      
      * Update version number to 3.2.0rc2
      
      * Update change logs for 3.2.0 release.
      
      * Update php README
      
      * Update upb, fixes some bugs (including a hash table problem). (#2611)
      
      * Update upb, fixes some bugs (including a hash table problem).
      
      * Ruby: added a test for the previous hash table corruption.
      
      Verified that this triggers the bug in the currently released
      version.
      
      * Ruby: bugfix for SEGV.
      
      * Ruby: removed old code for dup'ing defs.
      
      * Reverting deployment target to 7.0 (#2618)
      
      The Protobuf library doesn’t require the 7.1 deployment target so
      reverting it back to 7.0
      
      * Fix typo that breaks builds on big-endian (#2632)
      
      * Bump version number to 3.2.0
      7f3e2370
  8. 07 Dec, 2016 1 commit
  9. 03 Dec, 2016 1 commit
    • Joshua Haberman's avatar
      Factored Conformance and Benchmark test messages into shared test schema. (#1971) · f1ce60e7
      Joshua Haberman authored
      * Factored Conformance test messages into shared test schema.
      
      * Updated benchmarks to use new proto3 message locations.
      
      * Fixed include path.
      
      * Conformance: fixed include of Python test messages.
      
      * Make maven in Rakefile use --batch-mode.
      
      * Revert changes to benchmarks.
      
      On second thought I think a separate schema for
      CPU benchmarking makes sense.
      
      * Try regenerating C# protos for new test protos.
      
      * Removed benchmark messages from test proto.
      
      * Added Jon Skeet's fixes for C#.
      
      * Removed duplicate/old test messages C# file.
      
      * C# fixes for test schema move.
      
      * Fixed C# to use the correct TestAllTypes message.
      
      * Fixes for Objective C test schema move.
      
      * Added missing EXTRA_DIST file.
      f1ce60e7
  10. 23 Nov, 2016 1 commit
    • Adam Cozzette's avatar
      Fixed Ruby tests for JRuby 1.7 · 65479cb7
      Adam Cozzette authored
      This makes a couple of changes to fix the tests for JRuby 1.7:
      - Avoid using assert_false since that assertion seems not to exist in
        older versions
      - Disable a test related to respond_to? for JRuby. It's hard to tell
        what is going wrong here but it looks like probably a JRuby bug that
        has been fixed in more recent versions.
      65479cb7
  11. 14 Nov, 2016 1 commit
  12. 03 Nov, 2016 2 commits
  13. 14 Oct, 2016 1 commit
  14. 10 Oct, 2016 3 commits
  15. 29 Sep, 2016 3 commits
  16. 23 Sep, 2016 1 commit
  17. 22 Sep, 2016 1 commit
    • Brendan Ribera's avatar
      Fix hash computation for JRuby's RubyMessage · 525c6327
      Brendan Ribera authored
      `System.identityHashCode` returns a hash that does not consider a
      Message's values. This means two Messages with identical values will not
      have identical hashCodes.
      
      This patch uses the pattern from RubyMap to combine the hashCodes from
      all values in a given message and produce a unique, consistent,
      value-based hash.
      525c6327
  18. 21 Sep, 2016 1 commit
  19. 20 Sep, 2016 2 commits
  20. 02 Sep, 2016 1 commit
  21. 30 Aug, 2016 3 commits
  22. 29 Aug, 2016 1 commit
  23. 26 Aug, 2016 1 commit
  24. 24 Aug, 2016 1 commit
  25. 01 Aug, 2016 1 commit
  26. 29 Jul, 2016 2 commits