1. 19 Nov, 2018 2 commits
    • Joshua Haberman's avatar
      Merge pull request #5368 from haberman/objc · db96ab00
      Joshua Haberman authored
      Some changes to the ObjC code generator to support importing into Google.
      db96ab00
    • Thomas Van Lenten's avatar
      ObjC: small improvement to extension serialization. · ffa6bfc0
      Thomas Van Lenten authored
      For messages that have multiple extension ranges, this will improve things
      by avoiding repeated work.  For messages with a single range, it should
      be a wash.
      
      - Sort the list of set extensions once during serialization and reuse the list.
      - Break out of the serialization loop as soon as the loop has moved pasted at
        accepted range for field ids.
      ffa6bfc0
  2. 18 Nov, 2018 1 commit
  3. 16 Nov, 2018 3 commits
  4. 15 Nov, 2018 1 commit
  5. 14 Nov, 2018 9 commits
  6. 13 Nov, 2018 5 commits
  7. 12 Nov, 2018 5 commits
  8. 09 Nov, 2018 9 commits
  9. 08 Nov, 2018 2 commits
    • Adam Cozzette's avatar
      Merge pull request #5316 from zmodem/dllexport_build_fix · ce72041c
      Adam Cozzette authored
      Add wire_format_lite_inl.h include to implicit_weak_message.cc
      ce72041c
    • Dave MacLachlan's avatar
      Fix bugs in our keyword conversion support for objectivec · be83b29b
      Dave MacLachlan authored
      We have code for converting C/C++/Objc keywords that appear in protos
      to convert them so that they can be compiled.
      One of the things we need to be careful of is accidentally overriding methods
      that Apple declares in NSObject. It turns out that we have run into issues
      where we conflict with "hidden" methods in NSObject or methods added by
      categories. method_dump.sh collects all of the methods we care about for
      macOS and iOS and dumps them into objectivec_nsobject_methods.h which
      is then included in objectivec_helpers.cc as part of the build.
      
      Added a pile of tests to verify that conversions are happening as expected.
      be83b29b
  10. 06 Nov, 2018 3 commits
    • gerben-s's avatar
      Merge pull request #5261 from szakarias/dartExample · cd95c791
      gerben-s authored
      Add Dart example.
      cd95c791
    • James DeFelice's avatar
      options: reserved extension range for CSI · 4358133b
      James DeFelice authored
      4358133b
    • Hans Wennborg's avatar
      Add wire_format_lite_inl.h include to implicit_weak_message.cc · 5d8dd6b0
      Hans Wennborg authored
      This unbreaks the Windows shared-library build of Chrome when using
      Clang versions based on r344987 or later, see https://crbug.com/901776
      
      implicit_weak_message.cc is part of protobuf_lite.dll, and it includes
      wire_format_lite.h, which includes the dllexport inline function
      WireFormatLite::WriteGroupToArray which will therefore be emitted.
      
      WriteGroupToArray in turn calls the inline function
      InternalWriteGroupToArray, however that definition is provided in the
      _inl file. To make sure the definition is available, the _inl file must
      be included.
      
      Before Clang r344987 the build worked anyway due to luck, because
      InternalWriteGroupToArray was emitted into other object files (e.g. in
      wire_format_lite.obj). After that Clang revision, those definitions
      started getting inlined, and so are longer available and cause a link
      failure for the reference from implicit_weak_message.obj.
      5d8dd6b0