- 05 Dec, 2018 1 commit
-
-
Thomas Van Lenten authored
Just like fields, some extension fieldnames can be named such that they appear to have meaning to ARC. Add the annotation to the compiler will get things correct. Add a bunch of extensions to allow inspection on generation to ensure things are correct.
-
- 03 Dec, 2018 1 commit
-
-
Stephane Moore authored
For deprecated fields, identify the deprecated field and source file in the deprecation message. For deprecated files, identify the deprecated file in deprecation messages of generated interfaces. This additional context in deprecation messages will help provide developers with more context which could help them seek recommended alternatives to deprecated interfaces.
-
- 29 Nov, 2018 1 commit
-
-
michaelbausor authored
* adds string-to-int and int-to-string methods to enums * remove check for valueToName property in EnumTrait * Remove unused imports * Update to avoid using EnumTrait * Remove EnumTrait * Update enum types * Move name and value methods into generated classes * Remove functions from GPBUtil * Test well known enums * Implement enum value to/from name in c extension * Only generate use statement when namespace is present
-
- 27 Nov, 2018 1 commit
-
-
Dave MacLachlan authored
In some cases proto files that want/need to use the objc_class_prefix option have types that already have the prefix on a subset of their names. In this case we don't want to duplicate the prefix. Added tests for this (and prefixes in general).
-
- 26 Nov, 2018 1 commit
-
-
Brian Silverman authored
The code now matches what the comment above it actually generates. Also tweak that code so it actually compiles for me, and to avoid embedding /* and */ in comments because that's generally a reasonable thing to trigger warnings.
-
- 19 Nov, 2018 1 commit
-
-
Stephane Moore authored
Instead of using DEPRECATED_ATTRIBUTE from AvailabilityMacros.h, we should introduce a Google-specific Objective-C protobuf deprecation annotation. This helps address IWYU issues with using DEPRECATED_ATTRIBUTE and also enables allows clients to redefine the macro to treat protobuf warnings differently than other types of warnings (e.g., treating protobuf deprecation warnings as errors or ignoring them).
-
- 18 Nov, 2018 1 commit
-
-
Arun Olappamanna Vasudevan authored
-
- 16 Nov, 2018 1 commit
-
-
Josh Haberman authored
- removed use of GOOGLE_DISALLOW_EVIL_CONSTRUCTORS in favor of deleting them C++11 style. - removed forward declarations of protobuf core types. - ensured that namespaces "google" and "protobuf" are always opened/closed together.
-
- 14 Nov, 2018 1 commit
-
-
Adam Cozzette authored
Generated code now pulls in this header transitively, so it needs to be installed.
-
- 13 Nov, 2018 3 commits
-
-
Allen Webb authored
Previously --cpp_out:lite was available to force the optimization mode to the lite runtime. This adds --cpp_out=speed:... which is needed to override the file specific options in cases where libprotobuf-mutator is used for fuzzing since it depends on reflection. Signed-off-by:
Allen Webb <allenwebb@google.com>
-
Aleix Conchillo Flaque authored
This avoids compiler errors/warnings if zero-as-null-pointer-constant is considered an error or warning.
-
Adam Cozzette authored
This header is no longer used, so we can delete it. I also tweaked Makefile.am to fix the distcheck test.
-
- 12 Nov, 2018 1 commit
-
-
Michał Janiszewski authored
-
- 09 Nov, 2018 3 commits
-
-
Adam Cozzette authored
-
Adam Cozzette authored
-
Adam Cozzette authored
-
- 08 Nov, 2018 1 commit
-
-
Dave MacLachlan authored
We have code for converting C/C++/Objc keywords that appear in protos to convert them so that they can be compiled. One of the things we need to be careful of is accidentally overriding methods that Apple declares in NSObject. It turns out that we have run into issues where we conflict with "hidden" methods in NSObject or methods added by categories. method_dump.sh collects all of the methods we care about for macOS and iOS and dumps them into objectivec_nsobject_methods.h which is then included in objectivec_helpers.cc as part of the build. Added a pile of tests to verify that conversions are happening as expected.
-
- 06 Nov, 2018 1 commit
-
-
Hans Wennborg authored
This unbreaks the Windows shared-library build of Chrome when using Clang versions based on r344987 or later, see https://crbug.com/901776 implicit_weak_message.cc is part of protobuf_lite.dll, and it includes wire_format_lite.h, which includes the dllexport inline function WireFormatLite::WriteGroupToArray which will therefore be emitted. WriteGroupToArray in turn calls the inline function InternalWriteGroupToArray, however that definition is provided in the _inl file. To make sure the definition is available, the _inl file must be included. Before Clang r344987 the build worked anyway due to luck, because InternalWriteGroupToArray was emitted into other object files (e.g. in wire_format_lite.obj). After that Clang revision, those definitions started getting inlined, and so are longer available and cause a link failure for the reference from implicit_weak_message.obj.
-
- 05 Nov, 2018 1 commit
-
-
Sydney Acksman authored
Add group support for proto2
-
- 01 Nov, 2018 1 commit
-
-
Thomas Van Lenten authored
-
- 29 Oct, 2018 2 commits
-
-
Brian Silverman authored
They're not doing anything, so might as well get rid of them.
-
Michał Janiszewski authored
-
- 18 Oct, 2018 1 commit
-
-
Thomas BARBIER authored
-
- 16 Oct, 2018 1 commit
-
-
Adam Cozzette authored
-
- 11 Oct, 2018 1 commit
-
-
Sebastian Lövdahl authored
-
- 08 Oct, 2018 1 commit
-
-
Ben Wolsieffer authored
-
- 07 Oct, 2018 1 commit
-
-
michaelbausor authored
* Add support for primitive types in setters * Update to address PR feedback * Add tests and fixes for repeated fields * Remove repeated field code, add getters * Cleanup, test getters and oneofs * Move boxing logic into separate class * Add tests for wrapper type constructor args * Update to add new setXXXValue methods * Fix tests for invalid values * Fix c extension for wrapper accessors * Fix the bug that well known types didn't call Message_construct * Address PR comments * Refactoring init message with array logic * Add include path to protoc * Add missing TSRM_LS defintion * Fix TSRM_LS * Fix dist check
-
- 05 Oct, 2018 1 commit
-
-
Sydney Acksman authored
-
- 04 Oct, 2018 1 commit
-
-
Paul Yang authored
* Fix dist check for ruby * Fix dist check
-
- 03 Oct, 2018 1 commit
-
-
cburdick authored
-
- 02 Oct, 2018 2 commits
-
-
Cliff Burdick authored
-
GregTho authored
The former is the proper converse of _open, which is used in ::google::protobuf::internal::win32::open. This resolves issue #5209.
-
- 01 Oct, 2018 1 commit
-
-
Nazarbek Altybay authored
-
- 27 Sep, 2018 1 commit
-
-
Harshit Chopra authored
This change only adds basic proto2 support without advanced features like extensions, custom options, maps, etc. The protoc binary now generates ruby code for proto2 syntax. However, for now, it is restricted to proto2 files without advanced features like extensions, in which case it still errors out. This change also modifies the DSL to add proto messages to the DescriptorPool. There is a new DSL Builder#add_file to create a new FileDescriptor. With this, the generated ruby DSL looks something like: Google::Protobuf::DescriptorPool.generated_pool.build do add_file "test.proto" do add_message "foo" do optional :val, :int32, 1 end end end
-
- 24 Sep, 2018 1 commit
-
-
Sydney Acksman authored
* Compiler changes * Generated code changes * Library changes * Compiler style changes * Generated style changes * Fix Windows build errors * Implement changes from review * Reintroduce proto2 check * Compiler changes (required handling review) * Generated code changes (required handling review) * Library changes (required handling review * Field presence rewrite (compiler changes) * Field presence rewrite (generated code changes) * Compiler comment * IFieldAccessor.HasValue library implementation * Remove Clear methods and default values from proto3 code (Compiler) * Remove Clear methods and default values from proto3 code (Generated) * Remove Clear methods and default values from proto3 code (Library) * Fix distcheck error * Rewrite default string values to use base64 and convert * Library changes (IMessage2) * Compiler changes (IMessage2) * Generated changes (IMessage2) * Rebased and regenerated * Compiler changes (initialized extension) * Generated changes (initialized extension) * Library changes (initialized extension) * Refactor MessageExtensions.IsRequired * Move string default value creator and bytes default value creator back to seperate methods * Dead code cleanup * Fixed segmentation fault Removed unused header method declarations
-
- 19 Sep, 2018 1 commit
-
-
Michael Shields authored
Fixes #1890.
-
- 13 Sep, 2018 2 commits
-
-
Jeffrey Walton authored
-
Jeffrey Walton authored
-
- 04 Sep, 2018 1 commit
-
-
Josh Haberman authored
-
- 03 Sep, 2018 1 commit
-
-
Sigurd Meldgaard authored
This will find .bat files as well as .exe. Only affects the case when plugins are invoked from PATH. This does not change behaviour when compiled under Cygwin..
-