1. 05 Dec, 2018 1 commit
    • Thomas Van Lenten's avatar
      [ObjC] Properly annotate extensions for ARC. · 1484b580
      Thomas Van Lenten authored
      Just like fields, some extension fieldnames can be named such that they appear
      to have meaning to ARC. Add the annotation to the compiler will get things
      correct.
      
      Add a bunch of extensions to allow inspection on generation to ensure things
      are correct.
      1484b580
  2. 03 Dec, 2018 1 commit
    • Stephane Moore's avatar
      [protos/objc] Include more context in deprecation messages :warning: · 74fa8745
      Stephane Moore authored
      For deprecated fields, identify the deprecated field and source file in the deprecation message. For deprecated files, identify the deprecated file in deprecation messages of generated interfaces. This additional context in deprecation messages will help provide developers with more context which could help them seek recommended alternatives to deprecated interfaces.
      74fa8745
  3. 29 Nov, 2018 1 commit
    • michaelbausor's avatar
      PHP: Add Enum methods for converting to/from strings (#5342) · 0b9af83d
      michaelbausor authored
      * adds string-to-int and int-to-string methods to enums
      
      * remove check for valueToName property in EnumTrait
      
      * Remove unused imports
      
      * Update to avoid using EnumTrait
      
      * Remove EnumTrait
      
      * Update enum types
      
      * Move name and value methods into generated classes
      
      * Remove functions from GPBUtil
      
      * Test well known enums
      
      * Implement enum value to/from name in c extension
      
      * Only generate use statement when namespace is present
      0b9af83d
  4. 27 Nov, 2018 1 commit
  5. 26 Nov, 2018 1 commit
    • Brian Silverman's avatar
      Avoid octal constants in strutil.cc · dd614b77
      Brian Silverman authored
      The code now matches what the comment above it actually generates.
      
      Also tweak that code so it actually compiles for me, and to avoid
      embedding /* and */ in comments because that's generally a reasonable
      thing to trigger warnings.
      dd614b77
  6. 19 Nov, 2018 1 commit
    • Stephane Moore's avatar
      [protobuf/objc] Introduce a protobuf-specific deprecation annotation :warning: · b323b136
      Stephane Moore authored
      Instead of using DEPRECATED_ATTRIBUTE from AvailabilityMacros.h, we should introduce a Google-specific Objective-C protobuf deprecation annotation. This helps address IWYU issues with using DEPRECATED_ATTRIBUTE and also enables allows clients to redefine the macro to treat protobuf warnings differently than other types of warnings (e.g., treating protobuf deprecation warnings as errors or ignoring them).
      b323b136
  7. 18 Nov, 2018 1 commit
  8. 16 Nov, 2018 1 commit
  9. 14 Nov, 2018 1 commit
  10. 13 Nov, 2018 3 commits
  11. 12 Nov, 2018 1 commit
  12. 09 Nov, 2018 3 commits
  13. 08 Nov, 2018 1 commit
    • Dave MacLachlan's avatar
      Fix bugs in our keyword conversion support for objectivec · be83b29b
      Dave MacLachlan authored
      We have code for converting C/C++/Objc keywords that appear in protos
      to convert them so that they can be compiled.
      One of the things we need to be careful of is accidentally overriding methods
      that Apple declares in NSObject. It turns out that we have run into issues
      where we conflict with "hidden" methods in NSObject or methods added by
      categories. method_dump.sh collects all of the methods we care about for
      macOS and iOS and dumps them into objectivec_nsobject_methods.h which
      is then included in objectivec_helpers.cc as part of the build.
      
      Added a pile of tests to verify that conversions are happening as expected.
      be83b29b
  14. 06 Nov, 2018 1 commit
    • Hans Wennborg's avatar
      Add wire_format_lite_inl.h include to implicit_weak_message.cc · 5d8dd6b0
      Hans Wennborg authored
      This unbreaks the Windows shared-library build of Chrome when using
      Clang versions based on r344987 or later, see https://crbug.com/901776
      
      implicit_weak_message.cc is part of protobuf_lite.dll, and it includes
      wire_format_lite.h, which includes the dllexport inline function
      WireFormatLite::WriteGroupToArray which will therefore be emitted.
      
      WriteGroupToArray in turn calls the inline function
      InternalWriteGroupToArray, however that definition is provided in the
      _inl file. To make sure the definition is available, the _inl file must
      be included.
      
      Before Clang r344987 the build worked anyway due to luck, because
      InternalWriteGroupToArray was emitted into other object files (e.g. in
      wire_format_lite.obj). After that Clang revision, those definitions
      started getting inlined, and so are longer available and cause a link
      failure for the reference from implicit_weak_message.obj.
      5d8dd6b0
  15. 05 Nov, 2018 1 commit
  16. 01 Nov, 2018 1 commit
  17. 29 Oct, 2018 2 commits
  18. 18 Oct, 2018 1 commit
  19. 16 Oct, 2018 1 commit
  20. 11 Oct, 2018 1 commit
  21. 08 Oct, 2018 1 commit
  22. 07 Oct, 2018 1 commit
    • michaelbausor's avatar
      PHP: Add support for primitive types in setters (#5126) · 6a51c038
      michaelbausor authored
      * Add support for primitive types in setters
      
      * Update to address PR feedback
      
      * Add tests and fixes for repeated fields
      
      * Remove repeated field code, add getters
      
      * Cleanup, test getters and oneofs
      
      * Move boxing logic into separate class
      
      * Add tests for wrapper type constructor args
      
      * Update to add new setXXXValue methods
      
      * Fix tests for invalid values
      
      * Fix c extension for wrapper accessors
      
      * Fix the bug that well known types didn't call Message_construct
      
      * Address PR comments
      
      * Refactoring init message with array logic
      
      * Add include path to protoc
      
      * Add missing TSRM_LS defintion
      
      * Fix TSRM_LS
      
      * Fix dist check
      6a51c038
  23. 05 Oct, 2018 1 commit
  24. 04 Oct, 2018 1 commit
  25. 03 Oct, 2018 1 commit
  26. 02 Oct, 2018 2 commits
  27. 01 Oct, 2018 1 commit
  28. 27 Sep, 2018 1 commit
    • Harshit Chopra's avatar
      Adds support for proto2 syntax for Ruby gem. · d0535cc0
      Harshit Chopra authored
      This change only adds basic proto2 support without advanced features
      like extensions, custom options, maps, etc.
      
      The protoc binary now generates ruby code for proto2 syntax.
      However, for now, it is restricted to proto2 files without advanced features
      like extensions, in which case it still errors out.
      
      This change also modifies the DSL to add proto messages to the DescriptorPool.
      There is a new DSL Builder#add_file to create a new FileDescriptor. With this,
      the generated ruby DSL looks something like:
      
      Google::Protobuf::DescriptorPool.generated_pool.build do
        add_file "test.proto" do
          add_message "foo" do
            optional :val, :int32, 1
          end
        end
      end
      d0535cc0
  29. 24 Sep, 2018 1 commit
    • Sydney Acksman's avatar
      C# Proto2 feature : Field presence and default values (#4642) · 54176b26
      Sydney Acksman authored
      * Compiler changes
      
      * Generated code changes
      
      * Library changes
      
      * Compiler style changes
      
      * Generated style changes
      
      * Fix Windows build errors
      
      * Implement changes from review
      
      * Reintroduce proto2 check
      
      * Compiler changes (required handling review)
      
      * Generated code changes (required handling review)
      
      * Library changes (required handling review
      
      * Field presence rewrite (compiler changes)
      
      * Field presence rewrite (generated code changes)
      
      * Compiler comment
      
      * IFieldAccessor.HasValue library implementation
      
      * Remove Clear methods and default values from proto3 code (Compiler)
      
      * Remove Clear methods and default values from proto3 code (Generated)
      
      * Remove Clear methods and default values from proto3 code (Library)
      
      * Fix distcheck error
      
      * Rewrite default string values to use base64 and convert
      
      * Library changes (IMessage2)
      
      * Compiler changes (IMessage2)
      
      * Generated changes (IMessage2)
      
      * Rebased and regenerated
      
      * Compiler changes (initialized extension)
      
      * Generated changes (initialized extension)
      
      * Library changes (initialized extension)
      
      * Refactor MessageExtensions.IsRequired
      
      * Move string default value creator and bytes default value creator back to seperate methods
      
      * Dead code cleanup
      
      * Fixed segmentation fault
      Removed unused header method declarations
      54176b26
  30. 19 Sep, 2018 1 commit
  31. 13 Sep, 2018 2 commits
  32. 04 Sep, 2018 1 commit
  33. 03 Sep, 2018 1 commit