1. 12 Oct, 2019 1 commit
    • Alan Wu's avatar
      Remove unused argument to avoid UB · c1ba7c64
      Alan Wu authored
      `OneOfDescriptor_each` is registered as a Ruby method which takes zero
      parameters, which means it should take one argument.
      
      When Ruby invokes `OneOfDescriptor_each`, it calls it with one parameter
      only, which is one less than what `OneOfDescriptor_each` takes before
      this commit. Calling a function with the wrong number of argument is
      technically undefined behavior.
      
      See also: §6.5.2.2, N1256
      c1ba7c64
  2. 20 Aug, 2019 1 commit
  3. 16 Aug, 2019 1 commit
  4. 14 Aug, 2019 1 commit
    • Joshua Haberman's avatar
      Roll forward Ruby upb changes now that protobuf Ruby build is fixed (#5866) · 63f324a9
      Joshua Haberman authored
      * Rolled forward again with "Updated upb from defcleanup branch..."
      
      Revert "Revert "Updated upb from defcleanup branch and modified Ruby to use it (#5539)" (#5848)"
      
      This reverts commit 1568deab.
      
      * A few more merge fixes.
      
      * Updated for defcleanup2 branch.
      
      * Fixed upb to define upb_decode().
      
      * Fixed names of nested messages.
      
      * Revert submodule.
      
      * Set -std=gnu90 and fixed warnings/errors.
      
      Some of our Kokoro tests seem to run with this level of warnings,
      and the source strives to be gnu90 compatible.  Enforcing it for
      every build removes the possibility of some errors showing up in
      Kokoro/Travis tests only.
      
      * Fixed remaining warnings with gnu90 mode.
      
      I tried to match warning flags with what Ruby appears to do
      in our Kokoro tests.
      
      * Initialize values registered by rb_gc_register_address().
      
      * Fixed subtle GC bug.
      
      We need to initialize this marked value before creating the instance.
      
      * Truly fix the GC bug.
      
      * Updated upb for mktime() fix.
      
      * Removed XOPEN_SOURCE as we are not using strptime().
      
      * Removed fixed tests from the conformance failure list for Ruby.
      
      * Fixed memory error related to oneof def names.
      
      * Picked up new upb changes re: JSON printing.
      
      * Uncomment concurrent decoding test.
      63f324a9
  5. 06 Mar, 2019 2 commits
  6. 21 Feb, 2019 1 commit
  7. 18 Oct, 2018 1 commit
    • Paul Yang's avatar
      Add ruby 2.3, 2.4 and 2.5 test for linux. (#5256) · 333b3cea
      Paul Yang authored
      * Add ruby 2.3, 2.4 and 2.5 test for linux.
      
      * Update kokoro files
      
      * Add back commented gc test
      
      * Fix gc_test failure
      
      * Remove unused code
      
      * Update ruby 2.5.0 to 2.5.1
      
      * Update ruby 2.3 to 2.3.8
      
      * Remove useless comment
      333b3cea
  8. 27 Sep, 2018 1 commit
    • Harshit Chopra's avatar
      Adds support for proto2 syntax for Ruby gem. · d0535cc0
      Harshit Chopra authored
      This change only adds basic proto2 support without advanced features
      like extensions, custom options, maps, etc.
      
      The protoc binary now generates ruby code for proto2 syntax.
      However, for now, it is restricted to proto2 files without advanced features
      like extensions, in which case it still errors out.
      
      This change also modifies the DSL to add proto messages to the DescriptorPool.
      There is a new DSL Builder#add_file to create a new FileDescriptor. With this,
      the generated ruby DSL looks something like:
      
      Google::Protobuf::DescriptorPool.generated_pool.build do
        add_file "test.proto" do
          add_message "foo" do
            optional :val, :int32, 1
          end
        end
      end
      d0535cc0
  9. 27 Jun, 2018 1 commit
    • Erik Benoist's avatar
      Adds a base class for all explicitly raised TypeErrors (#4255) · 74f8e242
      Erik Benoist authored
      * This allows for ruby code to catch and handle Protobuf
          TypeErrors separately from the standard Ruby TypeError
      
        * Maintains backwards compatibility by having the new
          Google::Protobuf::TypeError inherit from the base
          TypeError. Any code that was catching TypeError should
          continue to work.
      74f8e242
  10. 08 Dec, 2017 1 commit
  11. 04 Oct, 2017 1 commit
    • Paul Yang's avatar
      Fix ruby segment fault (#3708) · cd5f49d0
      Paul Yang authored
      * Fix ruby segment fault
      
      1) rb_ary_new cannot be called during allocate function. During allocate
      fucntion, the containing object hasn't been marked and rb_ary_new may
      invoke gc to collect containing object.
      2) The global map should be marked before allocating it. Otherwise it
      may be garbage collected.
      
      * Add test
      
      * Remove commented code
      
      * Fix grammer error
      cd5f49d0
  12. 31 Jan, 2017 1 commit
    • Paul Yang's avatar
      Merge 3.2.x branch into master (#2648) · 7f3e2370
      Paul Yang authored
      * Down-integrate internal changes to github.
      
      * Update conformance test failure list.
      
      * Explicitly import used class in nano test to avoid random test fail.
      
      * Update _GNUC_VER to use the correct implementation of atomic operation
      on Mac.
      
      * maps_test.js: check whether Symbol is defined before using it (#2524)
      
      Symbol is not yet available on older versions of Node.js and so this
      test fails with them. This change just directly checks whether Symbol is
      available before we try to use it.
      
      * Added well_known_types_embed.cc to CLEANFILES so that it gets cleaned up
      
      * Updated Makefile.am to fix out-of-tree builds
      
      * Added Bazel genrule for generating well_known_types_embed.cc
      
      In pull request #2517 I made this change for the CMake and autotools
      builds but forgot to do it for the Bazel build.
      
      * Update _GNUC_VER to use the correct implementation of atomic operation on Mac.
      
      * Add new js file in extra dist.
      
      * Bump version number to 3.2.0
      
      * Fixed issue with autoloading - Invalid paths (#2538)
      
      * PHP fix int64 decoding (#2516)
      
      * fix int64 decoding
      
      * fix int64 decoding + tests
      
      * Fix int64 decoding on 32-bit machines.
      
      * Fix warning in compiler/js/embed.cc
      
      embed.cc: In function ‘std::string CEscape(const string&)’:
      embed.cc:51:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
         for (int i = 0; i < str.size(); ++i) {
                                      ^
      
      * Fix include in auto-generated well_known_types_embed.cc
      
      Restore include style fix (e3da722b) that has been trampled by
      auto-generation of well_known_types_embed.cc
      
      * Fixed cross compilations with the Autotools build
      
      Pull request #2517 caused cross compilations to start failing, because
      the js_embed binary was being built to run on the target platform
      instead of on the build machine. This change updates the Autotools build
      to use the AX_PROG_CXX_FOR_BUILD macro to find a suitable compiler for
      the build machine and always use that when building js_embed.
      
      * Minor fix for autocreated object repeated fields and maps.
      
      - If setting/clearing a repeated field/map that was objects, check the class
        before checking the autocreator.
      - Just to be paranoid, don’t mutate within copy/mutableCopy for the autocreated
        classes to ensure there is less chance of issues if someone does something
        really crazy threading wise.
      - Some more tests for the internal AutocreatedArray/AutocreatedDictionary
        classes to ensure things are working as expected.
      - Add Xcode 8.2 to the full_mac_build.sh supported list.
      
      * Fix generation of extending nested messages in JavaScript (#2439)
      
      * Fix generation of extending nested messages in JavaScript
      
      * Added missing test8.proto to build
      
      * Fix generated code when there is no namespace but there is enum definition.
      
      * Decoding unknown field should succeed.
      
      * Add embed.cc in src/Makefile.am to fix dist check.
      
      * Fixed "make distcheck" for the Autotools build
      
      To make the test pass I needed to fix out-of-tree builds and update
      EXTRA_DIST and CLEANFILES.
      
      * Remove redundent embed.cc from src/Makefile.am
      
      * Update version number to 3.2.0-rc.1 (#2578)
      
      * Change protoc-artifacts version to 3.2.0-rc.1
      
      * Update version number to 3.2.0rc2
      
      * Update change logs for 3.2.0 release.
      
      * Update php README
      
      * Update upb, fixes some bugs (including a hash table problem). (#2611)
      
      * Update upb, fixes some bugs (including a hash table problem).
      
      * Ruby: added a test for the previous hash table corruption.
      
      Verified that this triggers the bug in the currently released
      version.
      
      * Ruby: bugfix for SEGV.
      
      * Ruby: removed old code for dup'ing defs.
      
      * Reverting deployment target to 7.0 (#2618)
      
      The Protobuf library doesn’t require the 7.1 deployment target so
      reverting it back to 7.0
      
      * Fix typo that breaks builds on big-endian (#2632)
      
      * Bump version number to 3.2.0
      7f3e2370
  13. 15 Apr, 2016 1 commit
  14. 18 Feb, 2016 1 commit
  15. 12 Jan, 2016 2 commits
  16. 16 Jul, 2015 1 commit
    • Josh Haberman's avatar
      Added Ruby to conformance tests. · 181c7f26
      Josh Haberman authored
      This involved fixing a few important bugs in the
      Ruby implementation -- mostly cases of mixing
      upb field types and descriptor types (upb field
      types do not distinguish between int/sint/fixed/sfixed
      like descriptor types do).
      
      Also added protobuf-specific exceptions so parse
      errors can be caught specifically.
      
      Change-Id: Ib49d3db976900b2c6f3455c8b88af52cfb86e036
      181c7f26
  17. 10 Jul, 2015 1 commit
    • Josh Haberman's avatar
      Conform to C89/C90 variable declaration rules. · a1daeaba
      Josh Haberman authored
      While we are C99 in general, the Ruby build system
      for building C extensions enables several flags that
      throw warnings for C89/C90 variable ordering rules.
      To avoid spewing a million warnings (or trying to
      specifically override these warnings with command-line
      flags, which would be tricky and possibly fragile)
      we conform to Ruby's world of C89/C90.
      
      Change-Id: I0e03e62d95068dfdfde112df0fb16a248a2f32a0
      a1daeaba
  18. 09 Jun, 2015 1 commit
  19. 19 May, 2015 1 commit
  20. 13 Apr, 2015 1 commit
  21. 26 Jan, 2015 1 commit
  22. 15 Jan, 2015 1 commit
  23. 14 Jan, 2015 1 commit
  24. 09 Jan, 2015 1 commit
  25. 07 Jan, 2015 1 commit
  26. 06 Jan, 2015 1 commit
    • Chris Fallin's avatar
      Support for maps in the MRI C Ruby extension. · fd1a3ff1
      Chris Fallin authored
      This adds the Map container and support for parsing and serializing maps
      in the protobuf wire format (as defined by the C++ implementation, with
      MapEntry submessages in a repeated field). JSON map
      serialization/parsing are not yet supported as these will require some
      changes to upb as well.
      fd1a3ff1
  27. 12 Dec, 2014 1 commit
  28. 10 Dec, 2014 1 commit
    • Chris Fallin's avatar
      Provide a Ruby extension. · 973f4257
      Chris Fallin authored
      This adds a Ruby extension in ruby/ that is based on the 'upb' library
      (now included as a submodule), and adds support for Ruby code generation
      to the protoc compiler.
      973f4257