Skip to content

P
protobuf
Switch branch/tag
  1. 20 Oct, 2017 1 commit
  3. 18 Oct, 2017 2 commits
  5. 16 Oct, 2017 1 commit
    • Param Reddy's avatar
      Fix iOS cc_library build for protobuf. · 3130ce03
      Param Reddy authored 
      The SDK and os versions were hard coded.  Archs were mixed up.
Because of this,  Was getting errors with latest SDK:
clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
In file included from external/com_google_protobuf/src/google/protobuf/io/printer.cc:35:
In file included from external/com_google_protobuf/src/google/protobuf/io/printer.h:40:
In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string:470:
In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string_view:171:
In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__string:56:
In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/algorithm:638:
In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/cstring:61:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string.h:61:15: fatal error: 'string.h' file not found
              ^~~~~~~~~~
              1 error generated.

Currently none of these are needed when using bazel with https://github.com/bazelbuild/rules_apple.
-target arm64-apple-ios is passed properly to clang.  So -arch armv7 etc are not needed.
OS_IOS is not used anywhere.
Sources have:  GOOGLE_PROTOBUF_NO_THREADLOCAL defined in src/google/protobuf/stubs/platform_macros.h for iOS.  So __thread= is not needed.  In fact now that bazel is using C++11 by default,  __thread should ideally be moved to thread_local.
-miphoneos-version-min is passed by rules_apple.
      3130ce03
  7. 02 Oct, 2017 1 commit
  9. 29 Sep, 2017 1 commit
  11. 27 Sep, 2017 3 commits
  13. 15 Sep, 2017 3 commits
  15. 14 Sep, 2017 3 commits
  17. 13 Sep, 2017 5 commits
  19. 12 Sep, 2017 2 commits
  21. 11 Sep, 2017 2 commits
  23. 08 Sep, 2017 1 commit
  25. 07 Sep, 2017 1 commit
  27. 05 Sep, 2017 1 commit
  29. 31 Aug, 2017 3 commits
  31. 30 Aug, 2017 1 commit
  33. 24 Aug, 2017 2 commits
  35. 23 Aug, 2017 5 commits
  37. 22 Aug, 2017 2 commits