1. 25 Oct, 2017 1 commit
  2. 24 Oct, 2017 2 commits
  3. 20 Oct, 2017 2 commits
  4. 19 Oct, 2017 3 commits
  5. 18 Oct, 2017 16 commits
  6. 16 Oct, 2017 4 commits
    • Feng Xiao's avatar
      Merge pull request #3760 from jmillikin-stripe/descriptor-memset-ub · c4f59dcc
      Feng Xiao authored
      Fix undefined memory management found by Clang's sanitizers.
      c4f59dcc
    • John Millikin's avatar
    • Param Reddy's avatar
      Fix iOS cc_library build for protobuf. · 3130ce03
      Param Reddy authored
      The SDK and os versions were hard coded.  Archs were mixed up.
      Because of this,  Was getting errors with latest SDK:
      clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
      clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
      clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
      In file included from external/com_google_protobuf/src/google/protobuf/io/printer.cc:35:
      In file included from external/com_google_protobuf/src/google/protobuf/io/printer.h:40:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string:470:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string_view:171:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__string:56:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/algorithm:638:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/cstring:61:
      /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string.h:61:15: fatal error: 'string.h' file not found
                    ^~~~~~~~~~
                    1 error generated.
      
      Currently none of these are needed when using bazel with https://github.com/bazelbuild/rules_apple.
      -target arm64-apple-ios is passed properly to clang.  So -arch armv7 etc are not needed.
      OS_IOS is not used anywhere.
      Sources have:  GOOGLE_PROTOBUF_NO_THREADLOCAL defined in src/google/protobuf/stubs/platform_macros.h for iOS.  So __thread= is not needed.  In fact now that bazel is using C++11 by default,  __thread should ideally be moved to thread_local.
      -miphoneos-version-min is passed by rules_apple.
      3130ce03
    • Param Reddy's avatar
      Fix iOS cc_library build for protobuf. · 16792c62
      Param Reddy authored
      The SDK and os versions were hard coded.  Archs were mixed up.
      Because of this,  Was getting errors with latest SDK:
      clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
      clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
      clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
      In file included from external/com_google_protobuf/src/google/protobuf/io/printer.cc:35:
      In file included from external/com_google_protobuf/src/google/protobuf/io/printer.h:40:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string:470:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string_view:171:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__string:56:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/algorithm:638:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/cstring:61:
      /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string.h:61:15: fatal error: 'string.h' file not found
                    ^~~~~~~~~~
                    1 error generated.
      
      Currently none of these are needed when using bazel with https://github.com/bazelbuild/rules_apple.
      -target arm64-apple-ios is passed properly to clang.  So -arch armv7 etc are not needed.
      OS_IOS is not used anywhere.
      Sources have:  GOOGLE_PROTOBUF_NO_THREADLOCAL defined in src/google/protobuf/stubs/platform_macros.h for iOS.  So __thread= is not needed.  In fact now that bazel is using C++11 by default,  __thread should ideally be moved to thread_local.
      -miphoneos-version-min is passed by rules_apple.
      16792c62
  7. 14 Oct, 2017 1 commit
  8. 13 Oct, 2017 2 commits
  9. 12 Oct, 2017 3 commits
  10. 11 Oct, 2017 3 commits
  11. 10 Oct, 2017 2 commits
  12. 09 Oct, 2017 1 commit
    • Paul Yang's avatar
      Reserve unknown fields in php (#3659) · 60327468
      Paul Yang authored
      * Reserve unknown fields in upb
      1) For decoding, an unknownfields will be lazily created on message,
      which contains bytes of unknown fields.
      2) For encoding, if the unknownfields is present on message, all bytes
      contained in it will be serialized.
      
      * Register the function to encode unknown field at decode time.
      
      * Remove upb_handlers_setaddunknown
      
      * Use upb_sink_putunknown in decoder
      
      * Remove upb_pb_encoder_encode_unknown
      
      * Do not expose encode_unknown
      
      * Implement reserve unknown field in php Implement.
      
      * Make buffer private to CodedInputStream
      60327468