1. 05 Sep, 2016 1 commit
  2. 04 Feb, 2016 1 commit
    • Jon Skeet's avatar
      Rename GeneratedCodeInfo to GeneratedClrTypeInfo · a3ea9d12
      Jon Skeet authored
      Recently, descriptor.proto gained a GeneratedCodeInfo message, which means the generated code conflicts with our type.
      Unfortunately this affects codegen as well, although this is a part of the public API which is very unlikely to affect hand-written code.
      
      Generated code changes in next commit.
      a3ea9d12
  3. 22 Nov, 2015 1 commit
    • Jon Skeet's avatar
      Tidy up reflection in advance of attempting to implement DynamicMessage. · 72ec3367
      Jon Skeet authored
      There are corner cases where MessageDescriptor.{ClrType,Parser} will return null, and these are now documented. However, normally they *should* be implemented, even for descriptors of for dynamic messages. Ditto FieldDescriptor.Accessor.
      We'll still need a fair amount of work to implement dynamic messages, but this change means that the public API will be remain intact.
      
      Additionally, this change starts making use of C# 6 features in the files that it touches. This is far from exhaustive, and later PRs will have more.
      
      Generated code changes coming in the next commit.
      72ec3367
  4. 09 Nov, 2015 1 commit
  5. 26 Aug, 2015 1 commit
    • Jon Skeet's avatar
      Change where we rename Descriptor.cs to DescriptorProtoFile.cs. · 3c74a0c9
      Jon Skeet authored
      We now do this in protoc instead of the generation simpler.
      
      Benefits:
      - Generation script is simpler
      - Detection is simpler as we now only need to care about one filename
      - The embedded descriptor knows itself as "google/protobuf/descriptor.proto" avoiding dependency issues
      
      This PR also makes the "invalid dependency" exception clearer in terms of expected and actual dependencies.
      3c74a0c9
  6. 25 Aug, 2015 1 commit
    • Jon Skeet's avatar
      Change where we rename Descriptor.cs to DescriptorProtoFile.cs. · ca89a1a1
      Jon Skeet authored
      We now do this in protoc instead of the generation simpler.
      
      Benefits:
      - Generation script is simpler
      - Detection is simpler as we now only need to care about one filename
      - The embedded descriptor knows itself as "google/protobuf/descriptor.proto" avoiding dependency issues
      
      This PR also makes the "invalid dependency" exception clearer in terms of expected and actual dependencies.
      ca89a1a1
  7. 13 Aug, 2015 1 commit
    • Jon Skeet's avatar
      Allow public access to descriptor.proto as a dependency. · a39ababb
      Jon Skeet authored
      With this in place, generating APIs on github.com/google/googleapis works - previously annotations.proto failed.
      Currently there's no access to the annotations (stored as extensions) but we could potentially expose those at a later date.
      a39ababb
  8. 08 Aug, 2015 1 commit
  9. 04 Aug, 2015 1 commit
  10. 25 Jul, 2015 1 commit
  11. 22 Jul, 2015 2 commits
  12. 21 Jul, 2015 2 commits
    • Jon Skeet's avatar
      Fix comment typo · 8d115298
      Jon Skeet authored
      8d115298
    • Jon Skeet's avatar
      Revamp to reflection. · 53c399a1
      Jon Skeet authored
      Changes in brief:
      1. Descriptor is now the entry point for all reflection.
      2. IReflectedMessage has gone; there's now a Descriptor property in IMessage, which is explicitly implemented (due to the static property).
      3. FieldAccessorTable has gone away
      4. IFieldAccessor and OneofFieldAccessor still exist; we *could* put the functionality straight into FieldDescriptor and OneofDescriptor... I'm unsure about that.
      5. There's a temporary property MessageDescriptor.FieldAccessorsByFieldNumber to make the test changes small - we probably want this to go away
      6. Discovery for delegates is now via attributes applied to properties and the Clear method of a oneof
      
      I'm happy with 1-3.
      4 I'm unsure about - feedback welcome.
      5 will go away
      6 I'm unsure about, both in design and implementation. Should we have a ProtobufMessageAttribute too? Should we find all the relevant attributes in MessageDescriptor and pass them down, to avoid an O(N^2) scenario?
      
      Generated code changes coming in the next commit.
      53c399a1
  13. 17 Jul, 2015 1 commit
  14. 14 Jul, 2015 2 commits
  15. 09 Jul, 2015 2 commits
    • Jon Skeet's avatar
      Fix descriptor reflection in various ways · af259b77
      Jon Skeet authored
      - The protos are no longer publicly exposed at all
      - Oneof detection now works (as we default to -1, not 0)
      - OneofDescriptor exposes the fields in the oneof
      - Removed unnecessary code for replacing protos - remnant of extensions
      - There's now just the non-generic form of IDescriptor
      af259b77
    • Jon Skeet's avatar
      Implement reflection properly for fields. · 78ea98f5
      Jon Skeet authored
      - FieldAccessorTable is now non-generic
      - We don't have a static field per message type in the umbrella class. (Message descriptors are accessed via the file descriptor.)
      - Removed the "descriptor assigner" complication from the descriptor fixup; without extensions, we don't need it
      - MapField implements IDictionary (more tests would be good...)
      - RepeatedField implements IList (more tests would be good)
      - Use expression trees to build accessors. (Will need to test this on various platforms... probably need a fallback strategy just using reflection directly.)
      - Added FieldDescriptor.IsMap
      - Added tests for reflection with generated messages
      
      Changes to generated code coming in next commit.
      78ea98f5
  16. 30 Jun, 2015 1 commit
  17. 26 Jun, 2015 1 commit
  18. 09 Jun, 2015 1 commit
  19. 01 May, 2015 2 commits
  20. 29 Apr, 2015 1 commit
  21. 28 Apr, 2015 1 commit
    • Jon Skeet's avatar
      First part of making the C# runtime work with the new codegen. · f3504cf3
      Jon Skeet authored
      1) Remove CSharpOptions
      2) A new version of DescriptorProtoFile (with manual changes from codegen - it would otherwise be Descriptor.cs)
      3) Turn off CLS compliance (which we'll remove from the codebase entirely; I don't think it's actually relevant these days)
      4) Add "public imports" to FileDescriptor, with code broadly copied from the Java codebase.
      Lots more changes to commit before it will build and tests run, but one step at a time...
      f3504cf3