1. 24 Oct, 2017 1 commit
  2. 20 Oct, 2017 1 commit
  3. 19 Oct, 2017 3 commits
  4. 18 Oct, 2017 14 commits
  5. 16 Oct, 2017 3 commits
    • Feng Xiao's avatar
      Merge pull request #3760 from jmillikin-stripe/descriptor-memset-ub · c4f59dcc
      Feng Xiao authored
      Fix undefined memory management found by Clang's sanitizers.
      c4f59dcc
    • John Millikin's avatar
    • Param Reddy's avatar
      Fix iOS cc_library build for protobuf. · 16792c62
      Param Reddy authored
      The SDK and os versions were hard coded.  Archs were mixed up.
      Because of this,  Was getting errors with latest SDK:
      clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
      clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
      clang: warning: no such sysroot directory: '/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.2.sdk/' [-Wmissing-sysroot]
      In file included from external/com_google_protobuf/src/google/protobuf/io/printer.cc:35:
      In file included from external/com_google_protobuf/src/google/protobuf/io/printer.h:40:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string:470:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string_view:171:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__string:56:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/algorithm:638:
      In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/cstring:61:
      /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/string.h:61:15: fatal error: 'string.h' file not found
                    ^~~~~~~~~~
                    1 error generated.
      
      Currently none of these are needed when using bazel with https://github.com/bazelbuild/rules_apple.
      -target arm64-apple-ios is passed properly to clang.  So -arch armv7 etc are not needed.
      OS_IOS is not used anywhere.
      Sources have:  GOOGLE_PROTOBUF_NO_THREADLOCAL defined in src/google/protobuf/stubs/platform_macros.h for iOS.  So __thread= is not needed.  In fact now that bazel is using C++11 by default,  __thread should ideally be moved to thread_local.
      -miphoneos-version-min is passed by rules_apple.
      16792c62
  6. 14 Oct, 2017 1 commit
  7. 13 Oct, 2017 2 commits
  8. 12 Oct, 2017 3 commits
  9. 11 Oct, 2017 3 commits
  10. 10 Oct, 2017 2 commits
  11. 09 Oct, 2017 2 commits
    • Paul Yang's avatar
      Reserve unknown fields in php (#3659) · 60327468
      Paul Yang authored
      * Reserve unknown fields in upb
      1) For decoding, an unknownfields will be lazily created on message,
      which contains bytes of unknown fields.
      2) For encoding, if the unknownfields is present on message, all bytes
      contained in it will be serialized.
      
      * Register the function to encode unknown field at decode time.
      
      * Remove upb_handlers_setaddunknown
      
      * Use upb_sink_putunknown in decoder
      
      * Remove upb_pb_encoder_encode_unknown
      
      * Do not expose encode_unknown
      
      * Implement reserve unknown field in php Implement.
      
      * Make buffer private to CodedInputStream
      60327468
    • Zearen Wover's avatar
      Update third_party.md · d2a5f8b3
      Zearen Wover authored
      d2a5f8b3
  12. 06 Oct, 2017 1 commit
    • Paul Yang's avatar
      Add well known types to php runtime. (#3697) · 77f64bb7
      Paul Yang authored
      * Add well known types to php runtime.
      
      * Fix php7.0 tests
      
      * No longer generate empty.proto in test as it has been included in
      runtime.
      
      * Fix zts build
      
      * Clean code
      
      * Rename g_p_b_empty to empty.
      
      * Don't generate code for empty.proto in compatibility test
      
      * Fix 32-bit
      
      * Fix mac build
      
      * Fix Makefile.am to add new files
      77f64bb7
  13. 04 Oct, 2017 1 commit
    • Paul Yang's avatar
      Fix ruby segment fault (#3708) · cd5f49d0
      Paul Yang authored
      * Fix ruby segment fault
      
      1) rb_ary_new cannot be called during allocate function. During allocate
      fucntion, the containing object hasn't been marked and rb_ary_new may
      invoke gc to collect containing object.
      2) The global map should be marked before allocating it. Otherwise it
      may be garbage collected.
      
      * Add test
      
      * Remove commented code
      
      * Fix grammer error
      cd5f49d0
  14. 03 Oct, 2017 3 commits