1. 20 Feb, 2018 1 commit
    • Dave Tapuska's avatar
      Rename a shadowed variable. · af3813cd
      Dave Tapuska authored
      Shadowed variables can cause readability issues. Ensure a shadowed
      variable isn't used in header files which may be used in a dependent
      project that explicitly disables them.
      af3813cd
  2. 09 Feb, 2018 3 commits
  3. 08 Feb, 2018 2 commits
  4. 07 Feb, 2018 2 commits
    • Thomas Van Lenten's avatar
      07f02318
    • Nico Weber's avatar
      Remove use of GOOGLE_FALLTHROUGH_INTENDED from protobuf. · c66dd6c2
      Nico Weber authored
      Chrome is running into two issues with the use of this macro
      in open-source protobuf (https://crbug.com/809157):
      
      1. GOOGLE_FALLTHROUGH_INTENDED is defined to nothing on __APPLE__
         platforms, which blocks us from enabling -Wimplicit-fallthrough
         on Mac and iOS. (We use a hermetic self-built modern clang,
         so whatever Xcode bug that exclusion might be for doesn't apply
         to us.)
      
      2. It's in a public header file, and it's included in a public header file.
         When clang suggests adding [[clang::fallthrough]], it checks if it knows of
         a macro expanding to that and if so, suggests inserting that. Since lots of
         chrome code includes protobuf headers, it often suggests inserting
         GOOGLE_FALLTHROUGH_INTENDED (from protobuf) instead of the correct
         FALLTHROUGH (from chrome's base).
      
      Since the fallthrough doens't do anyting useful, just remove it.
      Long ago, this might have had perf impact, but d64a2d99 added a
      parsing fast path that calls this switch as slow fallback, so it should
      be off the hot path nowadays.
      
      No intended behavior change.
      
      This is the public version of internal change 184824132.
      c66dd6c2
  5. 02 Feb, 2018 1 commit
  6. 01 Feb, 2018 9 commits
  7. 31 Jan, 2018 7 commits
  8. 30 Jan, 2018 8 commits
  9. 29 Jan, 2018 1 commit
  10. 27 Jan, 2018 2 commits
  11. 26 Jan, 2018 2 commits
  12. 25 Jan, 2018 2 commits
    • Feng Xiao's avatar
      Merge pull request #3934 from xfxyjwf/builtsources · ed14fe42
      Feng Xiao authored
      Remove the use of BUILT_SOURCES
      ed14fe42
    • Jon Skeet's avatar
      Update .NET SDK to 2.0.3 · 0c523355
      Jon Skeet authored
      This will allow SourceLink as per #4179, and mean that we can use C#
      7.0 language features in the library (but not in generated code).
      This does not affect which platforms we're *targeting*, so end users
      won't see any difference.
      
      It would be nice to update to 2.1.4, but AppVeyor's "Visual Studio
      2017" environment is only 2.0.3.
      0c523355