1. 01 Jun, 2017 2 commits
  2. 05 Jan, 2017 1 commit
    • Thomas Van Lenten's avatar
      Minor fix for autocreated object repeated fields and maps. · 988ffe0a
      Thomas Van Lenten authored
      - If setting/clearing a repeated field/map that was objects, check the class
        before checking the autocreator.
      - Just to be paranoid, don’t mutate within copy/mutableCopy for the autocreated
        classes to ensure there is less chance of issues if someone does something
        really crazy threading wise.
      - Some more tests for the internal AutocreatedArray/AutocreatedDictionary
        classes to ensure things are working as expected.
      - Add Xcode 8.2 to the full_mac_build.sh supported list.
      988ffe0a
  3. 21 Jun, 2016 1 commit
    • Thomas Van Lenten's avatar
      Rename methods to avoid ObjC KVC collisions. (#1699) · a230b5d2
      Thomas Van Lenten authored
      Note: Breaking API change on the Dictionary classes.
      
      The numeric value classes were using "Value" in the naming, but this silently
      collided with the KVC category on NSObject; meaning KVC code could break up a
      keypath and call these selectors with the wrong types leading to crashes (even
      though the code all would compile cleanly).
      
      - Rename the methods to use the "type" instead of literal "Value".
      - Update all the impls and tests.
      - Enable the warning that will catch issues like this in the future.
      
      Fixes https://github.com/google/protobuf/issues/1616
      a230b5d2
  4. 27 May, 2016 1 commit
  5. 25 May, 2016 1 commit
    • Thomas Van Lenten's avatar
      Add more warnings to for the ObjC runtime build · c8a440df
      Thomas Van Lenten authored
      Working on https://github.com/google/protobuf/issues/1599, specifically:
      - Turn on more warnings that the Xcode UI calls out with individual controls.
      - Manually add:
        -Wundef
        -Wswitch-enum
      - Manually add and then diable in the unittests because of XCTest's headers:
        -Wreserved-id-macro
        -Wdocumentation-unknown-command
      - Manually add -Wdirect-ivar-access, but disable it for the unittests and in
        the library code (via #pragmas to suppress it). This is done so proto users
        can enable the warning.
      c8a440df
  6. 07 Mar, 2016 1 commit
  7. 10 Dec, 2015 1 commit
    • Thomas Van Lenten's avatar
      Update the min toolchain for iOS/OS X to be Xcode 7 · 938ba410
      Thomas Van Lenten authored
      - Let Xcode update the projects, schemes, and info.plists.
      - Add workaround for shallow analyzer issues in current Xcode versions (deep analyze gets things correct).
      - Tweak the Swift based tests to avoid warnings from Xcode 7's XCTest using optionals for autoenclosure results.
      - No longer tag the ObjC iOS travis test as flaky, xctool seems to manage the simulator pretty well.
      938ba410
  8. 02 Dec, 2015 1 commit
  9. 29 Sep, 2015 1 commit
    • Thomas Van Lenten's avatar
      Cleanups for newer Xcodes · 1383d53e
      Thomas Van Lenten authored
      - Move up to 8.4 as the high simulator (assuming Xcode 6.4).
      - Add cast to NSMutableDictionary so clang and resolve the selector.
      - Add case for the newer static analyzer so it won't trigger a false warning.
      - Update the "dictionary" interface to use "object" naming. Xcode 7+ has gotten
        more strict on the use of nonnull/nullable; combining that with the generic
        collection support; and the "dictionary" classes we created now collide with
        what the generic KeyValueCoding in the system headers triggering
        warnings/errors. Fix this and hopefully all future issue by renaming the
        methods to use "object" for the classes that have data types as objects
        instead of PODs. Taking this renaming hit now while ObjC is still in beta
        because it is a breaking change for any existing code.
      1383d53e
  10. 08 Jun, 2015 1 commit
    • Thomas Van Lenten's avatar
      Beta quality drop of Objective C Support. · d846b0b0
      Thomas Van Lenten authored
      - Add more to the ObjC dir readme.
      - Merge the ExtensionField and ExtensionDescriptor to reduce overhead.
      - Fix an initialization race.
      - Clean up the Xcode schemes.
      - Remove the class/enum filter.
      - Remove some forced inline that were bloating things without proof of performance wins.
      - Rename some internal types to avoid conflicts with the well know types protos.
      - Drop the use of ApplyFunctions to the compiler/optimizer can do what it wants.
      - Better document some possible future improvements.
      - Add missing support for parsing repeated primitive fields in packed or unpacked forms.
      - Improve -hash.
      - Add *Count for repeated and map<> fields to avoid auto create when checking for them being set.
      d846b0b0
  11. 22 May, 2015 1 commit
    • Thomas Van Lenten's avatar
      Objective C Second Alpha Drop · 1dcc3294
      Thomas Van Lenten authored
      - Style fixups in the code.
      - map<> serialization fixes and more tests.
      - Autocreation of map<> fields (to match repeated fields).
      - @@protoc_insertion_point(global_scope|imports).
      - Fixup proto2 syntax extension support.
      - Move all startup code to +initialize so it happen on class usage and not app startup.
      - Have generated headers use forward declarations and move imports into generated code, reduces what is need at compile time to speed up compiled and avoid pointless rippling of rebuilds.
      1dcc3294
  12. 06 May, 2015 1 commit