1. 02 Mar, 2017 1 commit
    • Thomas Van Lenten's avatar
      Handing threading race resolving methods. · 2d1c5e26
      Thomas Van Lenten authored
      - Don't prune the extension registry as that can lead to failures when two
        threads are racing.
      - If adding the method fails, check and see if it already is bound to decide
        the return result. Deals with threading races binding the methods.
      2d1c5e26
  2. 23 Feb, 2017 1 commit
  3. 05 Jan, 2017 1 commit
    • Thomas Van Lenten's avatar
      Minor fix for autocreated object repeated fields and maps. · 988ffe0a
      Thomas Van Lenten authored
      - If setting/clearing a repeated field/map that was objects, check the class
        before checking the autocreator.
      - Just to be paranoid, don’t mutate within copy/mutableCopy for the autocreated
        classes to ensure there is less chance of issues if someone does something
        really crazy threading wise.
      - Some more tests for the internal AutocreatedArray/AutocreatedDictionary
        classes to ensure things are working as expected.
      - Add Xcode 8.2 to the full_mac_build.sh supported list.
      988ffe0a
  4. 15 Sep, 2016 1 commit
    • Thomas Van Lenten's avatar
      Update the ObjC version checks to support a min and current version. · 1aa65000
      Thomas Van Lenten authored
      - Capture the version used to generated.
      - Check at compile time and runtime that generated code isn't from a newer
        version, also check that the min version required is also supported.
      - Keep the old constants/macros/functions to special case the last version
        that was working so those generated sources still work until we decide
        otherwise.
      1aa65000
  5. 17 Aug, 2016 2 commits
    • Thomas Van Lenten's avatar
      Record zero for "has" for proto3 if in a oneof. · a877fdfa
      Thomas Van Lenten authored
      If a message is proto3, then the zero values still count as being set one the
      field is in a oneof.
      
      Add tests to confirm oneofs work as expected in both syntaxes.
      a877fdfa
    • Thomas Van Lenten's avatar
      Never use strlen on utf8 runs so null characters work. · 116596a4
      Thomas Van Lenten authored
      Fixes https://github.com/google/protobuf/issues/1933
      
      Add a new test that forces strings into two different implementations from the
      NSString class cluster to help confirm we're exercising both paths by which
      CodedOutputStream will extract data from an NSString.
      
      Move the old +load test (that was flawed because the behavior really depends on
      the type of string from the NSString class cluster); into a unittest that
      targets the specific case we're adding a behavior confirmation on.
      
      As a bonus, improve the TextFormat generation of string characters < 0x20.
      116596a4
  6. 11 Aug, 2016 1 commit
  7. 09 Aug, 2016 1 commit
    • Thomas Van Lenten's avatar
      Never use strlen on utf8 runs so null characters work. · 1a6c1d09
      Thomas Van Lenten authored
      Fixes https://github.com/google/protobuf/issues/1933
      
      Add a new test that forces strings into two different implementations from the
      NSString class cluster to help confirm we're exercising both paths by which
      CodedOutputStream will extract data from an NSString.
      
      Move the old +load test (that was flawed because the behavior really depends on
      the type of string from the NSString class cluster); into a unittest that
      targets the specific case we're adding a behavior confirmation on.
      
      As a bonus, improve the TextFormat generation of string characters < 0x20.
      1a6c1d09
  8. 15 Jul, 2016 1 commit
  9. 28 Jun, 2016 1 commit
  10. 26 May, 2016 1 commit
  11. 25 May, 2016 1 commit
    • Thomas Van Lenten's avatar
      Add more warnings to for the ObjC runtime build · c8a440df
      Thomas Van Lenten authored
      Working on https://github.com/google/protobuf/issues/1599, specifically:
      - Turn on more warnings that the Xcode UI calls out with individual controls.
      - Manually add:
        -Wundef
        -Wswitch-enum
      - Manually add and then diable in the unittests because of XCTest's headers:
        -Wreserved-id-macro
        -Wdocumentation-unknown-command
      - Manually add -Wdirect-ivar-access, but disable it for the unittests and in
        the library code (via #pragmas to suppress it). This is done so proto users
        can enable the warning.
      c8a440df
  12. 21 Mar, 2016 1 commit
    • Thomas Van Lenten's avatar
      Only create the readonlySemaphore on demand. · bd41a39f
      Thomas Van Lenten authored
      This will lower the amount of dispatch_semaphores created per Message when the
      full object tree isn't walked in a way that would require them to be created.
      Uses a dispatch_once_t for one time init of the dispatch_semaphore.
      bd41a39f
  13. 17 Mar, 2016 1 commit
    • Thomas Van Lenten's avatar
      Shrink ObjC overhead (generated size and some runtime sizes) · 79a23c43
      Thomas Van Lenten authored
      NOTE: This is a binary breaking change as structure sizes have changed size
      and/or order.
      
      - Drop capturing field options, no other options were captured and other mobile
        targeted languages don't try to capture this sort information (saved 8
        bytes for every field defined (in static data and again in field descriptor
        instance size data).
      - No longer generate/compile in the messages/enums in descriptor.proto. If
        developers need it, they should generate it and compile it in. Reduced the
        overhead of the core library.
      - Compute the number of has_bits actually needs to avoid over reserving.
      - Let the boolean single fields store via a has_bit to avoid storage, makes
        the common cases of the instance size smaller.
      - Reorder some flags and down size the enums to contain the bits needed.
      - Reorder the items in the structures to manually ensure they are are packed
        better (especially when generating 64bit code - 8 bytes for every field,
        16 bytes for every extension, instance sizes 8 bytes also).
      - Split off the structure initialization so when the default is zero, the
        generated static storage doesn't need to reserve the space. This is batched
        at the message level, so all the fields for the message have to have zero
        defaults to get the saves. By definition all proto3 syntax  files fall into
        this case but it also saves space for the proto2 that use the standard
        defaults. (saves 8 bytes of static data for every field that had a zero
        default)
      - Don't track the enums defined by a message. Nothing in the runtime needs it
        and it was just generation and runtime overhead. (saves 8 bytes per enum)
      - Ensure EnumDescriptors are started up threadsafe in all cases.
      - Split some of the Descriptor initialization into multiple methods so the
        generated code isn't padded with lots of zero/nil args.
      - Change how oneof info is feed to the runtime enabling us to generate less
        static data (8 bytes saved per oneof for 64bit).
      - Change how enum value informat is capture to pack the data and only decode
        it if it ends up being needed. Avoids padding issues causing bloat of 64bit,
        and removes the needs for extra pointers in addition to the data (just the
        data and one pointer now).
      79a23c43
  14. 03 Feb, 2016 1 commit
  15. 17 Dec, 2015 1 commit
  16. 16 Jun, 2015 1 commit
  17. 08 Jun, 2015 1 commit
    • Thomas Van Lenten's avatar
      Beta quality drop of Objective C Support. · d846b0b0
      Thomas Van Lenten authored
      - Add more to the ObjC dir readme.
      - Merge the ExtensionField and ExtensionDescriptor to reduce overhead.
      - Fix an initialization race.
      - Clean up the Xcode schemes.
      - Remove the class/enum filter.
      - Remove some forced inline that were bloating things without proof of performance wins.
      - Rename some internal types to avoid conflicts with the well know types protos.
      - Drop the use of ApplyFunctions to the compiler/optimizer can do what it wants.
      - Better document some possible future improvements.
      - Add missing support for parsing repeated primitive fields in packed or unpacked forms.
      - Improve -hash.
      - Add *Count for repeated and map<> fields to avoid auto create when checking for them being set.
      d846b0b0
  18. 22 May, 2015 1 commit
    • Thomas Van Lenten's avatar
      Objective C Second Alpha Drop · 1dcc3294
      Thomas Van Lenten authored
      - Style fixups in the code.
      - map<> serialization fixes and more tests.
      - Autocreation of map<> fields (to match repeated fields).
      - @@protoc_insertion_point(global_scope|imports).
      - Fixup proto2 syntax extension support.
      - Move all startup code to +initialize so it happen on class usage and not app startup.
      - Have generated headers use forward declarations and move imports into generated code, reduces what is need at compile time to speed up compiled and avoid pointless rippling of rebuilds.
      1dcc3294
  19. 06 May, 2015 1 commit