- 18 Nov, 2014 3 commits
-
-
Tres Seaver authored
google/protobuf/map_test.cc:88:16: error: expected ‘;’ at end of member declaration google/protobuf/map_test.cc:88:18: error: ‘override’ does not name a type .
-
Tres Seaver authored
-
Tres Seaver authored
Incorporates feedback from @xfxyjwf: https://github.com/google/protobuf/pull/84#discussion_r20474781.
-
- 17 Nov, 2014 1 commit
-
-
Tres Seaver authored
Define safe constants to use when padding enums. Fixes #80.
-
- 14 Nov, 2014 1 commit
-
-
Feng Xiao authored
-
- 11 Nov, 2014 3 commits
-
-
Andrew Paprocki authored
- `int64` typedef collision with `sys/inttypes.h` - `xlC` complains about `int` and pointer comparisons without casts
-
Andrew Paprocki authored
-
Feng Xiao authored
-
- 08 Nov, 2014 2 commits
-
-
-
Feng Xiao authored
-
- 04 Nov, 2014 1 commit
-
-
acidtonic authored
There is an example at the top of the page which contains code that appears to show a user how to create and serialize a message to a file. However the flags to open the file lack the O_CREAT flag which allows creating the file if it doesn't exist. I was troubleshooting a situation where this snippet was used and compiled, but never created a file.
-
- 03 Nov, 2014 2 commits
-
-
Fabrice de Gans-Riberi authored
Upstreaming patch used by Chromium in https://codereview.chromium.org/693773003/
-
abyss7 authored
-
- 01 Nov, 2014 1 commit
-
-
Austin Schuh authored
-
- 31 Oct, 2014 2 commits
-
-
Austin Schuh authored
-
Andrew Paprocki authored
-
- 22 Oct, 2014 1 commit
-
-
Feng Xiao authored
-
- 21 Oct, 2014 1 commit
-
-
Feng Xiao authored
-
- 09 Oct, 2014 5 commits
-
-
Feng Xiao authored
-
Antoni Buszta authored
-
Feng Xiao authored
-
Feng Xiao authored
-
Feng Xiao authored
-
- 08 Oct, 2014 1 commit
-
-
Antoni Buszta authored
-
- 03 Oct, 2014 1 commit
-
-
Feng Xiao authored
-
- 01 Oct, 2014 1 commit
-
-
Feng Xiao authored
-
- 23 Sep, 2014 1 commit
-
-
Dinis Rosário authored
-
- 22 Sep, 2014 1 commit
-
-
William Orr authored
-
- 20 Sep, 2014 1 commit
-
-
William Orr authored
This patch adds support for atomic operations on Solaris, on any platform. It makes use of the atomic functions made available in Solaris' atomic.h header.
-
- 19 Sep, 2014 2 commits
-
-
Robert Edmonds authored
__atomic_store_n() cannot take a memory model argument of __ATOMIC_ACQUIRE, and __atomic_load_n() cannot take a memory model argument of __ATOMIC_RELEASE, per the GCC documentation: https://gcc.gnu.org/onlinedocs/gcc-4.9.1/gcc/_005f_005fatomic-Builtins.html On Clang this generates a -Watomic-memory-ordering warning. Promote the fences in Acquire_Store() and Release_Load() to the stronger __ATOMIC_SEQ_CST memory model, which ought to be safe. Note that there are no actual uses of Acquire_Store() or Release_Load() in protobuf, though. This follows the TSAN atomicops implementation, which also uses SEQ_CST fences for these functions. (Fixes #25.)
-
Robert Edmonds authored
-
- 18 Sep, 2014 1 commit
-
-
Robert Edmonds authored
We cannot use Clang's __has_extension macro unless we really are compiling on Clang, which means we cannot use this expression: #if (defined(__clang__) && __has_extension(c_atomic))) // ... #endif On GCC, this generates the following errors: In file included from ./google/protobuf/stubs/atomicops.h:59:0, from google/protobuf/stubs/atomicops_internals_x86_gcc.cc:36: ./google/protobuf/stubs/platform_macros.h:67:41: error: missing binary operator before token "(" (defined(__clang__) && __has_extension(c_atomic))) ^ In file included from google/protobuf/stubs/atomicops_internals_x86_gcc.cc:36:0: ./google/protobuf/stubs/atomicops.h:196:40: error: missing binary operator before token "(" (defined(__clang__) && __has_extension(c_atomic)) ^ Instead, we have to protect the __has_extension expression by only executing it when __clang__ is defined: #if defined(__clang__) # if __has_extension(c_atomic) // ... # endif #endif
-
- 14 Sep, 2014 1 commit
-
-
Robert S. Edmonds authored
The generic atomicops implementation is only exposed if GCC >= 4.7 is available, but Clang, where the underlying __atomic built-ins are also available, typically only claims to be GCC 4.2. This causes build failures when compiling protobuf or the output of protoc's C++ code generator on an architecture that needs the generic atomicops implementation with Clang. Clang has a "c_atomic" extension which can be tested for which almost does what we want: C11 atomic operations Use __has_feature(c_atomic) or __has_extension(c_atomic) to determine if support for atomic types using _Atomic is enabled. Clang also provides a set of builtins which can be used to implement the <stdatomic.h> operations on _Atomic types. I'm not sure if this guarantees that the GNU atomic builtins (the ones with the __atomic prefix) are also available, but in practice this should guarantee that Clang is new enough. With this change in place, Clang generates several diagnostics when compiling the generic atomicops implementation. These appear to be bugs in the generic atomicops implementation and are not Clang-specific.
-
- 13 Sep, 2014 1 commit
-
-
Robert S. Edmonds authored
The macro GOOGLE_PROTOBUF_ARCH_PPC is not used anywhere in the protobuf source; there is no Power-specific atomics implementation, etc. Funnily enough, the macro __ppc__ is not actually defined on 32-bit Power on GCC/Linux, according to the following webpage: http://nadeausoftware.com/articles/2012/02/c_c_tip_how_detect_processor_type_using_compiler_predefined_macros#POWER and verified on a 32-bit Debian sid 'powerpc' chroot: (sid_powerpc-dchroot)edmonds@partch:~$ gcc -dM -E - < /dev/null | grep -c __ppc__ 0 (sid_powerpc-dchroot)edmonds@partch:~$ gcc -dM -E - < /dev/null | grep -c __LP64__ 0
-
- 04 Sep, 2014 1 commit
-
-
huahang authored
-
- 03 Sep, 2014 1 commit
-
-
huahang authored
This change fixes the following compiler warning: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
-
- 27 Aug, 2014 1 commit
-
-
David Hirschfeld authored
-
- 25 Aug, 2014 1 commit
-
-
jieluo@google.com authored
-
- 20 Aug, 2014 1 commit
-
-
jieluo@google.com authored
patch Issue 130740043 to trunk for other atomicops patches: [MIPS64] Add support for MIPS64 in protobuf
-
- 14 Aug, 2014 1 commit
-
-
jieluo@google.com authored
make dist complains the file name is too long and refuse to put it to tar. Change the file to a shorter name
-