- 06 Aug, 2019 1 commit
-
-
Paul Beusterien authored
Fix #3218
-
- 19 Jul, 2019 1 commit
-
-
Paul Yang authored
* Down integrate to GitHub * Fix broken tests
-
- 06 Jun, 2019 4 commits
-
-
Thomas Van Lenten authored
-
Thomas Van Lenten authored
-
Julien Poumailloux authored
Follow up on https://github.com/protocolbuffers/protobuf/pull/6221
-
Andrzej Hunt authored
This avoids hitting the following warning when including GPBDescriptor.h in ARC projects with stricter warning settings: error: 'assign' property of object type may become a dangling reference; consider using 'unsafe_unretained' [-Werror,-Wobjc-property-assign-on-object-type We first hit this in XCode 11, it's unclear whether it simply got stricter about enforcing this warning or whether the flags enabled with -Wall or -Weverything have been expanded.
-
- 09 Apr, 2019 1 commit
-
-
Hao Nguyen authored
-
- 25 Mar, 2019 1 commit
-
-
Benjamin Peterson authored
-
- 11 Mar, 2019 1 commit
-
-
Thomas Van Lenten authored
For reasons I don't follow, when passing CXXFLAGS to configure, the build ends up breaking because something along the way fails to detect C++11 support within the third_party/googletest part of the build.
-
- 21 Feb, 2019 1 commit
-
-
Xiang Dai authored
Signed-off-by:
Xiang Dai <764524258@qq.com>
-
- 08 Jan, 2019 2 commits
-
-
Thomas Van Lenten authored
The CocoaPod (and source) have always support tvOS, but adding the project makes it easier to run the tests and debug if there ever were an issue. (not adding a watchOS project at the moment because Apple doesn't provide XCTest, so all it could do is build the library. We still support that, just can't "test" it.)
-
Thomas Van Lenten authored
-
- 18 Dec, 2018 2 commits
-
-
Thomas Van Lenten authored
Some protos have enum values of "FOO" and "Foo", which the ObjC generation then makes into the same thing. Just skip generating the enum element for the duplicate as it would be a compile error because of the name collision. The descriptors are still generated to support reflection and TextFormat more completely.
-
Thomas Van Lenten authored
Don't look up the TextFormat for the value as aliases can trip that up, instead check the TextFormat names directly and then fetch the value.
-
- 13 Dec, 2018 1 commit
-
-
Dave MacLachlan authored
By putting the NSAssert behind a DEBUG flag we aren't copying filepaths into release builds.
-
- 05 Dec, 2018 3 commits
-
-
Thomas Van Lenten authored
Just like fields, some extension fieldnames can be named such that they appear to have meaning to ARC. Add the annotation to the compiler will get things correct. Add a bunch of extensions to allow inspection on generation to ensure things are correct.
-
Thomas Van Lenten authored
This should help the Swift compiler if these apis are used because it changes the codegen to not need copies/retains.
-
Thomas Van Lenten authored
This should help the Swift compiler if these apis are used because it changes the codegen to not need copies/retains.
-
- 03 Dec, 2018 1 commit
-
-
Stephane Moore authored
For deprecated fields, identify the deprecated field and source file in the deprecation message. For deprecated files, identify the deprecated file in deprecation messages of generated interfaces. This additional context in deprecation messages will help provide developers with more context which could help them seek recommended alternatives to deprecated interfaces.
-
- 27 Nov, 2018 1 commit
-
-
Dave MacLachlan authored
In some cases proto files that want/need to use the objc_class_prefix option have types that already have the prefix on a subset of their names. In this case we don't want to duplicate the prefix. Added tests for this (and prefixes in general).
-
- 19 Nov, 2018 2 commits
-
-
Stephane Moore authored
Instead of using DEPRECATED_ATTRIBUTE from AvailabilityMacros.h, we should introduce a Google-specific Objective-C protobuf deprecation annotation. This helps address IWYU issues with using DEPRECATED_ATTRIBUTE and also enables allows clients to redefine the macro to treat protobuf warnings differently than other types of warnings (e.g., treating protobuf deprecation warnings as errors or ignoring them).
-
Thomas Van Lenten authored
For messages that have multiple extension ranges, this will improve things by avoiding repeated work. For messages with a single range, it should be a wash. - Sort the list of set extensions once during serialization and reuse the list. - Break out of the serialization loop as soon as the loop has moved pasted at accepted range for field ids.
-
- 14 Nov, 2018 6 commits
-
-
Thomas Van Lenten authored
-
Thomas Van Lenten authored
If a proto has multiple extension ranges back to back, don't double print the first items as they also are the ending range of the previous.
-
Thomas Van Lenten authored
-
Thomas Van Lenten authored
-
Thomas Van Lenten authored
Using NSCoding with a Message that has extensions is risky because when reloaded, there is no way to provide a registry through the NSCoding plumbing, so output a warnings to atleast give developers a hint about the potential issues.
-
Thomas Van Lenten authored
The builds were failing under Xcode 10 because of the new build system. Even when reverted to the old build system, the build was failing on the analyzer and swift bridging header, so it seems the general logic for searching for things was changed in a way the setting does not always cover. - Disable HeaderMaps. - Set user header search paths instead of system search paths. - Turn off always search user paths (now recommended). Tested in Xcode 10.1 and 9.4.1; both are able to build/pass with this.
-
- 09 Nov, 2018 1 commit
-
-
Adam Cozzette authored
-
- 08 Nov, 2018 1 commit
-
-
Dave MacLachlan authored
We have code for converting C/C++/Objc keywords that appear in protos to convert them so that they can be compiled. One of the things we need to be careful of is accidentally overriding methods that Apple declares in NSObject. It turns out that we have run into issues where we conflict with "hidden" methods in NSObject or methods added by categories. method_dump.sh collects all of the methods we care about for macOS and iOS and dumps them into objectivec_nsobject_methods.h which is then included in objectivec_helpers.cc as part of the build. Added a pile of tests to verify that conversions are happening as expected.
-
- 04 Nov, 2018 1 commit
-
-
Parveen Bhatia authored
-
- 02 Nov, 2018 1 commit
-
-
Thomas Van Lenten authored
No changes were needed, but since the Xcode projects pick up the updated setting, the tests require a newer Xcode that supports Swift 4. This is being done because Xcode 10 starting warning about Swift 3 support going away in the future, so we might as well do the updates since most folks shouldn't be on those really old Xcode versions any more.
-
- 01 Nov, 2018 1 commit
-
-
Thomas Van Lenten authored
-
- 02 Oct, 2018 4 commits
-
-
Thomas Van Lenten authored
-
Thomas Van Lenten authored
Follow ObjC conventions and how the generated header labels things by copying NSStrings/NSData fields when setting them.
-
Thomas Van Lenten authored
Causes a warning in newer Xcodes.
-
Thomas Van Lenten authored
-
- 19 Sep, 2018 1 commit
-
-
Michael Shields authored
-
- 07 Sep, 2018 1 commit
-
-
Josh Haberman authored
-
- 22 Aug, 2018 1 commit
-
-
Feng Xiao authored
-