1. 30 Aug, 2019 2 commits
  2. 26 Aug, 2019 1 commit
    • Thomas Van Lenten's avatar
      Fix enum writing. · b273cba1
      Thomas Van Lenten authored
      Enums use varint, so if the value is negative it should end up being longer.
      
      This was caught my new conformance test cases.
      b273cba1
  3. 06 Jun, 2019 1 commit
  4. 18 Dec, 2018 1 commit
    • Thomas Van Lenten's avatar
      If enum aliases overlap in ObjC names skip generating the extras. · d529720e
      Thomas Van Lenten authored
      Some protos have enum values of "FOO" and "Foo", which the ObjC generation
      then makes into the same thing. Just skip generating the enum element for
      the duplicate as it would be a compile error because of the name collision.
      
      The descriptors are still generated to support reflection and TextFormat
      more completely.
      d529720e
  5. 05 Dec, 2018 1 commit
    • Thomas Van Lenten's avatar
      [ObjC] Properly annotate extensions for ARC. · 1484b580
      Thomas Van Lenten authored
      Just like fields, some extension fieldnames can be named such that they appear
      to have meaning to ARC. Add the annotation to the compiler will get things
      correct.
      
      Add a bunch of extensions to allow inspection on generation to ensure things
      are correct.
      1484b580
  6. 27 Nov, 2018 1 commit
  7. 14 Nov, 2018 1 commit
  8. 08 Nov, 2018 1 commit
    • Dave MacLachlan's avatar
      Fix bugs in our keyword conversion support for objectivec · be83b29b
      Dave MacLachlan authored
      We have code for converting C/C++/Objc keywords that appear in protos
      to convert them so that they can be compiled.
      One of the things we need to be careful of is accidentally overriding methods
      that Apple declares in NSObject. It turns out that we have run into issues
      where we conflict with "hidden" methods in NSObject or methods added by
      categories. method_dump.sh collects all of the methods we care about for
      macOS and iOS and dumps them into objectivec_nsobject_methods.h which
      is then included in objectivec_helpers.cc as part of the build.
      
      Added a pile of tests to verify that conversions are happening as expected.
      be83b29b
  9. 02 Oct, 2018 1 commit
  10. 22 Aug, 2018 1 commit
  11. 11 Jul, 2018 1 commit
  12. 29 May, 2018 1 commit
    • leovitch's avatar
      [ObjC] Add ability to introspect list of enum values (#4678) · 28049024
      leovitch authored
      Added new API to GPBEnumDescriptor to enable introspection of enum values.
      
      Refactored implementation so that this contains a minimum of added code.
      
      Clarified comments regarding behavior in the presence of the alias_allowed option.
      
      Added unit tests for new functionality and for the alias case.
      28049024
  13. 20 Apr, 2018 1 commit
    • Thomas Van Lenten's avatar
      Remove the iOS Test App. · b59da6d0
      Thomas Van Lenten authored
      The tests can run as what Apple calls a Logic Test (under xctest), which means
      it doesn't have to load an full UI App under the simulator, which speeds things
      up a fair amount.
      b59da6d0
  14. 02 Apr, 2018 1 commit
    • Thomas Van Lenten's avatar
      Add compile test sources for to test include order. · e998b8ff
      Thomas Van Lenten authored
      To ensure all headers aren't dependent on other things being imported
      before/after them, make a source that just imports each header and add
      it to the unittesting target, that way we ensure it can be included on
      its own with ordering issues.
      
      Also do this testing with a few generated headers that aren't part of
      the library to help ensure the different generated imports needed are
      complete.
      e998b8ff
  15. 08 Mar, 2018 1 commit
  16. 31 Jan, 2018 1 commit
  17. 03 Jan, 2018 1 commit
  18. 16 Nov, 2017 1 commit
  19. 15 Nov, 2017 2 commits
  20. 14 Nov, 2017 1 commit
  21. 24 Oct, 2017 1 commit
  22. 03 Oct, 2017 1 commit
  23. 02 Oct, 2017 1 commit
  24. 06 Jun, 2017 2 commits
  25. 01 Jun, 2017 1 commit
  26. 23 May, 2017 1 commit
  27. 17 May, 2017 1 commit
    • Thomas Van Lenten's avatar
      Fix ExtensionRegistry copying and add tests. · 49e4ba60
      Thomas Van Lenten authored
      - Fix up -copyWithZone: to not leave the two registries sharing
        some of the storage by using -addExtensions:.
      - Improve -addExtensions: to clone the sub dict when there is
        nothing to merge into.
      - A ExtensionRegistry unittests.
      - Update project schemes to not have extra things in perf scheme.
      49e4ba60
  28. 28 Mar, 2017 1 commit
  29. 23 Feb, 2017 1 commit
  30. 13 Jan, 2017 1 commit
    • Thomas Van Lenten's avatar
      Timestamp helper fix, Duration helper cleanup. · d0bc096b
      Thomas Van Lenten authored
      - The Timestamp proto does not allow for negative nanos fields, so the seconds
        must be shifted and a positive nanos then applied.
      - Tweak the helpers on Duration to make it clear there is no "base" time
        involved.
      - Update the unittests for duration and timestamp to cover positive and
        negative NSTimeIntervals and what their impact is on the protos.
      d0bc096b
  31. 12 Jan, 2017 2 commits
  32. 05 Jan, 2017 1 commit
    • Thomas Van Lenten's avatar
      Minor fix for autocreated object repeated fields and maps. · 988ffe0a
      Thomas Van Lenten authored
      - If setting/clearing a repeated field/map that was objects, check the class
        before checking the autocreator.
      - Just to be paranoid, don’t mutate within copy/mutableCopy for the autocreated
        classes to ensure there is less chance of issues if someone does something
        really crazy threading wise.
      - Some more tests for the internal AutocreatedArray/AutocreatedDictionary
        classes to ensure things are working as expected.
      - Add Xcode 8.2 to the full_mac_build.sh supported list.
      988ffe0a
  33. 08 Dec, 2016 1 commit
    • Thomas Van Lenten's avatar
      Improve ObjC deprecated annotation support. · dad775b7
      Thomas Van Lenten authored
      - Check the parent file options for deprecation when deciding to tag Messages
        and Enums as deprecated.
      - Within the generated source push/pop the warning for implementing deprecated
        things around a deprecated class implementation.
      - Annotate the methods generated for extension fields as deprecated.
      - Add a testing .proto file that covers deprecated fields, messages, enums,
        enum values and compile it into the unittests to confirm things compile
        cleanly.
      - Add a testing .proto file that uses the file level option to make everything
        deprecated and compile it into the unittests to confirm things compile
        cleanly.
      dad775b7
  34. 03 Oct, 2016 1 commit
    • Thomas Van Lenten's avatar
      Update the ObjC projects for Xcode 8 · 297449aa
      Thomas Van Lenten authored
      - Let Xcode 8 update settings on the projects/schemes.
      - Migrate Swift tests to Swift 3 syntax.
      - Update the build/test script:
        - Require Xcode 8 (because of the Swift 3 requirement for tests)
        - Update the devices to what Xcode 8 has (8.x simulator seem to fail even
          though they can be downloaded in Xcode 8)
      - Update the travis images to ones with Xcode 8.
      297449aa
  35. 08 Sep, 2016 2 commits