1. 09 Mar, 2018 1 commit
  2. 06 Mar, 2018 2 commits
  3. 05 Mar, 2018 2 commits
  4. 26 Feb, 2018 5 commits
  5. 24 Feb, 2018 3 commits
  6. 22 Feb, 2018 1 commit
  7. 21 Feb, 2018 2 commits
  8. 20 Feb, 2018 3 commits
  9. 12 Feb, 2018 1 commit
  10. 09 Feb, 2018 3 commits
  11. 08 Feb, 2018 2 commits
  12. 07 Feb, 2018 2 commits
    • Thomas Van Lenten's avatar
      07f02318
    • Nico Weber's avatar
      Remove use of GOOGLE_FALLTHROUGH_INTENDED from protobuf. · c66dd6c2
      Nico Weber authored
      Chrome is running into two issues with the use of this macro
      in open-source protobuf (https://crbug.com/809157):
      
      1. GOOGLE_FALLTHROUGH_INTENDED is defined to nothing on __APPLE__
         platforms, which blocks us from enabling -Wimplicit-fallthrough
         on Mac and iOS. (We use a hermetic self-built modern clang,
         so whatever Xcode bug that exclusion might be for doesn't apply
         to us.)
      
      2. It's in a public header file, and it's included in a public header file.
         When clang suggests adding [[clang::fallthrough]], it checks if it knows of
         a macro expanding to that and if so, suggests inserting that. Since lots of
         chrome code includes protobuf headers, it often suggests inserting
         GOOGLE_FALLTHROUGH_INTENDED (from protobuf) instead of the correct
         FALLTHROUGH (from chrome's base).
      
      Since the fallthrough doens't do anyting useful, just remove it.
      Long ago, this might have had perf impact, but d64a2d99 added a
      parsing fast path that calls this switch as slow fallback, so it should
      be off the hot path nowadays.
      
      No intended behavior change.
      
      This is the public version of internal change 184824132.
      c66dd6c2
  13. 02 Feb, 2018 1 commit
  14. 01 Feb, 2018 9 commits
  15. 31 Jan, 2018 3 commits
    • Adam Cozzette's avatar
      Merge pull request #4239 from mrpi/master · 6456e5d6
      Adam Cozzette authored
      Create std::string in Arena memory
      6456e5d6
    • David Ostrovsky's avatar
      Bazel: Support building with Java 9 · 85b488f7
      David Ostrovsky authored
      Fixes: #4256.
      
      Bazel@HEAD supports Java 9.
      
      The current code has one single issue with Java 9 compliance: the usage
      of sun.misc package. We add jdk.unsupported module with --add-modules
      compiler option for now. Long term, the usage of non public API should
      be avoided.
      
      To build with Java 9, build custom bazel version and issue:
      
        $ bazel --host_javabase=/usr/lib64/jvm/java-9-openjdk build \
          --javacopt='--release 9' \
          --java_toolchain=@bazel_tools//tools/jdk:toolchain_jdk9 \
         :protobuf_java
      85b488f7
    • Thomas Van Lenten's avatar
      Work around strange error with atomic and swift under Xcode 8.3.3. · cf016a42
      Thomas Van Lenten authored
      Haven't been able to make a repo case, but this should "fix" the problem
      by avoid it completely.
      
      - Move readOnlySemaphore_ into the .m file so it isn't exposed in any
        header.
      - Move GPBGetObjectIvarWithField() also to go with the new limited
        visibility on the readOnlySemaphore_.
      cf016a42