1. 14 Mar, 2018 1 commit
  2. 13 Mar, 2018 4 commits
  3. 12 Mar, 2018 2 commits
  4. 11 Mar, 2018 1 commit
  5. 09 Mar, 2018 5 commits
  6. 06 Mar, 2018 2 commits
  7. 05 Mar, 2018 2 commits
  8. 02 Mar, 2018 1 commit
  9. 26 Feb, 2018 5 commits
  10. 24 Feb, 2018 3 commits
  11. 22 Feb, 2018 1 commit
  12. 21 Feb, 2018 2 commits
  13. 20 Feb, 2018 3 commits
  14. 12 Feb, 2018 1 commit
  15. 09 Feb, 2018 3 commits
  16. 08 Feb, 2018 2 commits
  17. 07 Feb, 2018 2 commits
    • Thomas Van Lenten's avatar
      07f02318
    • Nico Weber's avatar
      Remove use of GOOGLE_FALLTHROUGH_INTENDED from protobuf. · c66dd6c2
      Nico Weber authored
      Chrome is running into two issues with the use of this macro
      in open-source protobuf (https://crbug.com/809157):
      
      1. GOOGLE_FALLTHROUGH_INTENDED is defined to nothing on __APPLE__
         platforms, which blocks us from enabling -Wimplicit-fallthrough
         on Mac and iOS. (We use a hermetic self-built modern clang,
         so whatever Xcode bug that exclusion might be for doesn't apply
         to us.)
      
      2. It's in a public header file, and it's included in a public header file.
         When clang suggests adding [[clang::fallthrough]], it checks if it knows of
         a macro expanding to that and if so, suggests inserting that. Since lots of
         chrome code includes protobuf headers, it often suggests inserting
         GOOGLE_FALLTHROUGH_INTENDED (from protobuf) instead of the correct
         FALLTHROUGH (from chrome's base).
      
      Since the fallthrough doens't do anyting useful, just remove it.
      Long ago, this might have had perf impact, but d64a2d99 added a
      parsing fast path that calls this switch as slow fallback, so it should
      be off the hot path nowadays.
      
      No intended behavior change.
      
      This is the public version of internal change 184824132.
      c66dd6c2