1. 14 Feb, 2019 1 commit
  2. 23 Jan, 2019 1 commit
  3. 17 Jan, 2019 1 commit
  4. 18 Dec, 2018 1 commit
    • Paul Yang's avatar
      Php 7.3 fix (#5434) · d7c44095
      Paul Yang authored
      * Inherit from message instead of implement
      
      When regestering class (implmenets other class) during MINIT, zend_class_implements
      would call zend_class_entry->interface_gets_implemented(). In PHP-7.3 interface_gets_implemented shares the same location with create_object.
      However, during MINIT, the global object storeage hasn't been initialized. And thus, caused segment fault in php 7.3.
      
      * Use zend_string_init where interned string may be the value.
      zend_string_dup will keep using the existing interned string.
      In php 7.3, interned string cannot be destroyed from user's code.
      
      * Uncommment debug code
      
      * Use latest phpunit for each php versions
      
      * Revert change in Dockerfile
      
      * Update php test to use the new docker image
      
      * Update composer
      
      * Change docker organization
      
      * Update phpunit
      
      * Debug phpunit
      
      * Store phpunit into bin dir in docker image
      
      * Install valgrind to docker
      
      * Fix compatibility test
      
      * Remove generated_service_test from compatibility c extension test
      
      * Update 32bit php test to the new docker image
      
      * Install bison
      
      * Fix build.sh
      
      * Fix DOCKERIMAGE_PREFIX
      
      * Fix basename
      
      * Add comment to build_and_run_docker2.sh
      
      * Remove commented code
      
      * Fix comments
      d7c44095
  5. 29 Nov, 2018 1 commit
    • michaelbausor's avatar
      PHP: Add Enum methods for converting to/from strings (#5342) · 0b9af83d
      michaelbausor authored
      * adds string-to-int and int-to-string methods to enums
      
      * remove check for valueToName property in EnumTrait
      
      * Remove unused imports
      
      * Update to avoid using EnumTrait
      
      * Remove EnumTrait
      
      * Update enum types
      
      * Move name and value methods into generated classes
      
      * Remove functions from GPBUtil
      
      * Test well known enums
      
      * Implement enum value to/from name in c extension
      
      * Only generate use statement when namespace is present
      0b9af83d
  6. 20 Jul, 2018 1 commit
  7. 25 May, 2018 2 commits
    • Brent Shaffer's avatar
      PHP namespaces for nested messages and enums (#4536) · 2774e544
      Brent Shaffer authored
      * uses namespaces for nested messages and enums
      
      * fixes namespaces for PHP dist
      
      * fixes namespace for Descriptors, adds Cardinality and Kind
      
      * fixes nested namespaces for reserved words and adds tests
      
      * adds tests and generator fix for php class prefixes
      
      * fixes escaping of protobuf packages, enum comments, misc others
      
      * nice refactor of generated code
      
      * adds class files for backwards compatibility
      
      * simplifies code with templates
      
      * adds compatibility files to makefile
      
      * cleanup of generator and fixes nested namespace bug
      
      * regenerates proto types
      
      * remove internal BC classes
      
      * adds deprecated warning, adds methods back
      
      * simplifies if statement
      
      * fixes dist files
      
      * addresses review comments
      
      * adds back TYPE_URL_PREFIX constant
      
      * adds @deprecated to old nested class files
      
      * skips tests which require a separate process when protobuf.so is enabled
      
      * Adds tests for legacy nested classes that do not require separate processes to test
      
      * uses legacy names for GPBUtil message check
      
      * adds block for IDE @deprecated message
      
      * Namespace for nested message/enum in c extension
      
      * Remove unused code
      2774e544
    • Bo Yang's avatar
      Implement array constructor in php c extension. · 8b336f8c
      Bo Yang authored
      8b336f8c
  8. 24 May, 2018 2 commits
    • Brent Shaffer's avatar
      PHP namespaces for nested messages and enums (#4536) · 67379546
      Brent Shaffer authored
      * uses namespaces for nested messages and enums
      
      * fixes namespaces for PHP dist
      
      * fixes namespace for Descriptors, adds Cardinality and Kind
      
      * fixes nested namespaces for reserved words and adds tests
      
      * adds tests and generator fix for php class prefixes
      
      * fixes escaping of protobuf packages, enum comments, misc others
      
      * nice refactor of generated code
      
      * adds class files for backwards compatibility
      
      * simplifies code with templates
      
      * adds compatibility files to makefile
      
      * cleanup of generator and fixes nested namespace bug
      
      * regenerates proto types
      
      * remove internal BC classes
      
      * adds deprecated warning, adds methods back
      
      * simplifies if statement
      
      * fixes dist files
      
      * addresses review comments
      
      * adds back TYPE_URL_PREFIX constant
      
      * adds @deprecated to old nested class files
      
      * skips tests which require a separate process when protobuf.so is enabled
      
      * Adds tests for legacy nested classes that do not require separate processes to test
      
      * uses legacy names for GPBUtil message check
      
      * adds block for IDE @deprecated message
      
      * Namespace for nested message/enum in c extension
      
      * Remove unused code
      67379546
    • Bo Yang's avatar
      Implement array constructor in php c extension. · 839f71e3
      Bo Yang authored
      839f71e3
  9. 12 Sep, 2017 1 commit
  10. 08 Sep, 2017 1 commit
  11. 21 Aug, 2017 1 commit
  12. 04 Aug, 2017 1 commit
    • Paul Yang's avatar
      Fix the bug in php c extension that setting one field can change another field's value. (#3455) · 49b44bff
      Paul Yang authored
      * Fix the bug in php c extension that setting one field can change another
      field's value.
      
      The reason is that previously, in c extension, it was assumed that the
      order that fields were declared in php is the same as the order of
      fields in upb. This is not true. Now, for every field in upb, we will
      look up the actual property that is corresponding to the upb field.
      
      * Cleanup pull request
      
      * Fix indentation
      
      * Port to php5
      
      * Port with php7.1
      
      * Port to zts
      49b44bff
  13. 30 Jun, 2017 1 commit
  14. 20 Jun, 2017 2 commits
    • Paul Yang's avatar
      Add ARRAY for reserved name (#3150) · dba8928f
      Paul Yang authored
      dba8928f
    • Ryan Gordon's avatar
      Switch to addEnumType to fix fatal error (#3225) · 703cd8e1
      Ryan Gordon authored
      * Switch to addEnumType to fix fatal error
      
      * Fixing more cases of HHVM incompatibility
      
      * Updating tests to be hhvm compatible
      
      * Fixing tests
      
      * Fixing merge
      
      * Don't use call_user_func, should hopefully fix tests
      
      * Fixing spelling
      
      * Fixing another misspelling in a test
      
      * Fixing placement of append and kvUpdate functions
      
      * Actually fix function helpers
      
      * Remove double addEnumType. How did this ever work?
      
      * Fixing a couple more tests
      
      * Only use the setter if the return value isn't an object
      703cd8e1
  15. 05 Jun, 2017 1 commit
    • Paul Yang's avatar
      Add new file option php_namespace. (#3162) · 6f325805
      Paul Yang authored
      * Add new file option php_namespace.
      
      Use this option to change the namespace of php generated classes.
      Default is empty. When this option is empty, the package name will be
      used for determining the namespace.
      
      * Uncomment commented tests
      
      * Revert gdb test change
      
      * Update csharp descriptor.
      
      * Add test for empty php_namespace.
      6f325805
  16. 29 May, 2017 2 commits
  17. 24 Apr, 2017 1 commit
  18. 20 Apr, 2017 3 commits
  19. 17 Mar, 2017 1 commit
  20. 10 Mar, 2017 1 commit
    • Paul Yang's avatar
      Repeated/Map field setter should accept a regular PHP array (#2817) · 616e68ec
      Paul Yang authored
      Accept regular PHP array for repeated/map setter. Existing map/repeated
      field will be swapped by a clean map/repeated field. Then, elements in
      the array will be added to the map/repeated field. All elements will be
      type checked before adding.
      
      See #2686 for detail.
      616e68ec
  21. 01 Mar, 2017 1 commit
    • Paul Yang's avatar
      Add mergeFrom method on Message (#2766) · bcbaabe5
      Paul Yang authored
      This method merges the contents of the specified message into the
      current message. Singular fields that are set in the specified message
      overwrite the corresponding fields in the current message.  Repeated
      fields are appended. Map fields key-value pairs are overritten.
      Singular/Oneof sub-messages are recursively merged. All overritten
      sub-messages are deep-copied.
      bcbaabe5
  22. 12 Feb, 2017 1 commit
  23. 31 Jan, 2017 1 commit
    • Paul Yang's avatar
      Merge 3.2.x branch into master (#2648) · 7f3e2370
      Paul Yang authored
      * Down-integrate internal changes to github.
      
      * Update conformance test failure list.
      
      * Explicitly import used class in nano test to avoid random test fail.
      
      * Update _GNUC_VER to use the correct implementation of atomic operation
      on Mac.
      
      * maps_test.js: check whether Symbol is defined before using it (#2524)
      
      Symbol is not yet available on older versions of Node.js and so this
      test fails with them. This change just directly checks whether Symbol is
      available before we try to use it.
      
      * Added well_known_types_embed.cc to CLEANFILES so that it gets cleaned up
      
      * Updated Makefile.am to fix out-of-tree builds
      
      * Added Bazel genrule for generating well_known_types_embed.cc
      
      In pull request #2517 I made this change for the CMake and autotools
      builds but forgot to do it for the Bazel build.
      
      * Update _GNUC_VER to use the correct implementation of atomic operation on Mac.
      
      * Add new js file in extra dist.
      
      * Bump version number to 3.2.0
      
      * Fixed issue with autoloading - Invalid paths (#2538)
      
      * PHP fix int64 decoding (#2516)
      
      * fix int64 decoding
      
      * fix int64 decoding + tests
      
      * Fix int64 decoding on 32-bit machines.
      
      * Fix warning in compiler/js/embed.cc
      
      embed.cc: In function ‘std::string CEscape(const string&)’:
      embed.cc:51:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
         for (int i = 0; i < str.size(); ++i) {
                                      ^
      
      * Fix include in auto-generated well_known_types_embed.cc
      
      Restore include style fix (e3da722b) that has been trampled by
      auto-generation of well_known_types_embed.cc
      
      * Fixed cross compilations with the Autotools build
      
      Pull request #2517 caused cross compilations to start failing, because
      the js_embed binary was being built to run on the target platform
      instead of on the build machine. This change updates the Autotools build
      to use the AX_PROG_CXX_FOR_BUILD macro to find a suitable compiler for
      the build machine and always use that when building js_embed.
      
      * Minor fix for autocreated object repeated fields and maps.
      
      - If setting/clearing a repeated field/map that was objects, check the class
        before checking the autocreator.
      - Just to be paranoid, don’t mutate within copy/mutableCopy for the autocreated
        classes to ensure there is less chance of issues if someone does something
        really crazy threading wise.
      - Some more tests for the internal AutocreatedArray/AutocreatedDictionary
        classes to ensure things are working as expected.
      - Add Xcode 8.2 to the full_mac_build.sh supported list.
      
      * Fix generation of extending nested messages in JavaScript (#2439)
      
      * Fix generation of extending nested messages in JavaScript
      
      * Added missing test8.proto to build
      
      * Fix generated code when there is no namespace but there is enum definition.
      
      * Decoding unknown field should succeed.
      
      * Add embed.cc in src/Makefile.am to fix dist check.
      
      * Fixed "make distcheck" for the Autotools build
      
      To make the test pass I needed to fix out-of-tree builds and update
      EXTRA_DIST and CLEANFILES.
      
      * Remove redundent embed.cc from src/Makefile.am
      
      * Update version number to 3.2.0-rc.1 (#2578)
      
      * Change protoc-artifacts version to 3.2.0-rc.1
      
      * Update version number to 3.2.0rc2
      
      * Update change logs for 3.2.0 release.
      
      * Update php README
      
      * Update upb, fixes some bugs (including a hash table problem). (#2611)
      
      * Update upb, fixes some bugs (including a hash table problem).
      
      * Ruby: added a test for the previous hash table corruption.
      
      Verified that this triggers the bug in the currently released
      version.
      
      * Ruby: bugfix for SEGV.
      
      * Ruby: removed old code for dup'ing defs.
      
      * Reverting deployment target to 7.0 (#2618)
      
      The Protobuf library doesn’t require the 7.1 deployment target so
      reverting it back to 7.0
      
      * Fix typo that breaks builds on big-endian (#2632)
      
      * Bump version number to 3.2.0
      7f3e2370
  24. 27 Jan, 2017 1 commit
  25. 08 Dec, 2016 1 commit
  26. 26 Oct, 2016 1 commit
  27. 11 Oct, 2016 1 commit
  28. 15 Sep, 2016 1 commit
    • Paul Yang's avatar
      Check in php implementation. (#2052) · e0e54661
      Paul Yang authored
      This pull request includes two implementation: C extension and PHP
      package. Both implementations support encode/decode of singular,
      repeated and map fields.
      e0e54661