- 21 Feb, 2019 1 commit
-
-
Xiang Dai authored
Signed-off-by:
Xiang Dai <764524258@qq.com>
-
- 10 Feb, 2017 1 commit
-
-
Jie Luo authored
All the files are copied from 3.0.0 (JosnFormaterTest was deleted)
-
- 20 Apr, 2016 1 commit
-
-
Jon Skeet authored
JSON tests fail, as we're not using OriginalNameAttribute yet.
-
- 22 Nov, 2015 1 commit
-
-
Jon Skeet authored
There are corner cases where MessageDescriptor.{ClrType,Parser} will return null, and these are now documented. However, normally they *should* be implemented, even for descriptors of for dynamic messages. Ditto FieldDescriptor.Accessor. We'll still need a fair amount of work to implement dynamic messages, but this change means that the public API will be remain intact. Additionally, this change starts making use of C# 6 features in the files that it touches. This is far from exhaustive, and later PRs will have more. Generated code changes coming in the next commit.
-
- 19 Nov, 2015 1 commit
-
-
Jon Skeet authored
-
- 09 Nov, 2015 1 commit
-
-
Jon Skeet authored
-
- 14 Aug, 2015 1 commit
-
-
Jan Tattermusch authored
-
- 31 Jul, 2015 1 commit
-
-
Jon Skeet authored
(Shows the benefit of unit testing even code "too simple to fail"...)
-
- 25 Jul, 2015 1 commit
-
-
Jan Tattermusch authored
-
- 22 Jul, 2015 3 commits
-
-
Jon Skeet authored
I think Jan was actually suggesting keeping both, but that feels redundant to me. The test diff is misleading here IMO, because I wouldn't expect real code using reflection to use several accessors one after another like this, unless it was within a loop. Evidence to the contrary would be welcome :) This change also incidentally goes part way to fixing the issue of the JSON formatter not writing out the fields in field number order - with this change, it does except for oneofs, which we can fix in a follow-up change. I haven't actually added a test with a message with fields deliberately out of order - I'm happy to do so though. It feels like it would make sense to be in google/src/protobuf, but it's not entirely clear what the rules of engagement are for adding new messages there. (unittest_proto3.proto?)
-
Jon Skeet authored
-
Jon Skeet authored
This is definitely not ready to ship - I'm "troubled" by the disconnect between a list of fields in declaration order, and a mapping of field accessors by field number/name. Discussion required, but I find that easier when we've got code to look at :)
-
- 21 Jul, 2015 1 commit
-
-
Jon Skeet authored
Changes in brief: 1. Descriptor is now the entry point for all reflection. 2. IReflectedMessage has gone; there's now a Descriptor property in IMessage, which is explicitly implemented (due to the static property). 3. FieldAccessorTable has gone away 4. IFieldAccessor and OneofFieldAccessor still exist; we *could* put the functionality straight into FieldDescriptor and OneofDescriptor... I'm unsure about that. 5. There's a temporary property MessageDescriptor.FieldAccessorsByFieldNumber to make the test changes small - we probably want this to go away 6. Discovery for delegates is now via attributes applied to properties and the Clear method of a oneof I'm happy with 1-3. 4 I'm unsure about - feedback welcome. 5 will go away 6 I'm unsure about, both in design and implementation. Should we have a ProtobufMessageAttribute too? Should we find all the relevant attributes in MessageDescriptor and pass them down, to avoid an O(N^2) scenario? Generated code changes coming in the next commit.
-
- 17 Jul, 2015 1 commit
-
-
Jon Skeet authored
We'll see what I've missed when CI fails...
-
- 14 Jul, 2015 1 commit
-
-
Jon Skeet authored
- Move types into Google.Protobuf.Reflection - Change codegen to reflect that in generated types Generated code changes coming in part 2
-
- 09 Jul, 2015 1 commit
-
-
Jon Skeet authored
- The protos are no longer publicly exposed at all - Oneof detection now works (as we default to -1, not 0) - OneofDescriptor exposes the fields in the oneof - Removed unnecessary code for replacing protos - remnant of extensions - There's now just the non-generic form of IDescriptor
-
- 30 Jun, 2015 1 commit
-
-
Jon Skeet authored
Everything should now be consistent - the only difference between files is the year (aside from generated files). Fixes issue #531.
-
- 26 Jun, 2015 1 commit
-
-
Jon Skeet authored
-
- 09 Jun, 2015 1 commit
-
-
Jon Skeet authored
-
- 12 May, 2015 1 commit
-
-
Jon Skeet authored
This includes the NUnit test adapter which allows NUnit tests to be run under VS without any extra plugins. Unfortunate the compatibility tests using the abstract test fixture class show up as "external" tests, and aren't well presented - but they do run.
-
- 30 Apr, 2015 1 commit
-
-
Jon Skeet authored
This includes fetching the VS unit test runner package, so that tests can be run from Visual Studio's Test Explorer.
-
- 28 Apr, 2015 1 commit
-
-
Jon Skeet authored
This commit includes changes to the C#-specific protos, and rebuilt versions of the "stock" protos. The stock protos have been locally updated to have a specific C# namespace, but this is expected to change soon, so hasn't been committed. Four areas are currently not tested: 1) Serialization - we may restore this at some point, possibly optionally. 2) Services - currently nothing is generated for this; will need to see how it interacts with GRPC 3) Fields beginning with _{digit} - see https://github.com/google/protobuf/issues/308 4) Fields with names which conflict with the declaring type in nasty ways - see https://github.com/google/protobuf/issues/309
-