1. 21 Aug, 2015 1 commit
    • Douglas Heriot's avatar
      Define GOOGLE_ATTRIBUTE_NOINLINE for MSVC. Workaround for VS2015 Release build compiler bug. · 5021c4d8
      Douglas Heriot authored
      See issue #240 - MSVC in VS2015 seems to inline a function it shouldn't. My original workaround was to disable inlining for the whole file, but I found a way to do it on just this specific function using __declspec(noinline).
      Unfortunately __declspec has to go at the start of the function declaration, while __attribute in GCC can go either before or after. I had to move lots of GOOGLE_ATTRIBUTE_NOLINE to make it compile. I have not yet tested this change with GCC.
      
      Will there be other side effects of defining this, given it wasn't previously?
      
      I also noticed a few functions marked with both the 'inline' keyword, and GOOGLE_ATTRIBUTE_NOINLINE - huh? Is there an explanation for this, or is it an oversight?
      5021c4d8
  2. 14 Aug, 2015 6 commits
  3. 13 Aug, 2015 5 commits
  4. 12 Aug, 2015 2 commits
  5. 11 Aug, 2015 3 commits
  6. 10 Aug, 2015 6 commits
  7. 09 Aug, 2015 1 commit
  8. 08 Aug, 2015 9 commits
  9. 07 Aug, 2015 3 commits
  10. 06 Aug, 2015 4 commits