1. 31 Jan, 2018 1 commit
    • Thomas Van Lenten's avatar
      Don't assume c-strings are 4 byte aligned. · d570d486
      Thomas Van Lenten authored
      The Undefined Behavior sanitizer flags one part of the unittests for this.
      For default values for `bytes` we write a length on the front of a c-string
      in the static data, apparently the compiler/linker doesn't always make this
      4 byte aligned, so it get flagged for undefined/degraded performance. Avoid
      this by using memcpy instead.
      d570d486
  2. 03 Oct, 2017 1 commit
  3. 08 Sep, 2016 1 commit
    • Thomas Van Lenten's avatar
      Add ObjC helpers for Any WKT. · 337ec306
      Thomas Van Lenten authored
      - Capture the ObjC prefix used when generating the the file.
      - Track the containing type on descriptors.
      - Mark descriptors where the message class name got a suffix added to it.
      - Expose a fullName property on Descriptors.
      - Add helpers for packing/unpacking Any messages.
      - Bump the ObjC runtime version number. Since we added methods and invoke them
        in the generated code, ensure the code is running against a matching version.
        Otherwise, someone could compile against headers, but run with a framework
        that is older and get unknown selector failures.  This should trip clearer
        messaging.
      
      Fixes https://github.com/google/protobuf/issues/1674
      337ec306
  4. 07 Jul, 2016 1 commit
    • Thomas Van Lenten's avatar
      Don't #import the .m files. · be0d7f66
      Thomas Van Lenten authored
      As bazel folks are looking at getting auto generation of module maps going and
      the importing of sources files causes issues there.  We were only do it to
      hack around some of the apple linker behaviors around objc classes and
      categories, but even that isn't complete and CocoaPods was already doing -ObjC,
      and developers not using pods could have still needed it to ensure everything
      was linked anyways; so drop the hack of importing sources.
      be0d7f66
  5. 26 Jun, 2016 1 commit
  6. 14 Jun, 2016 1 commit
  7. 25 May, 2016 1 commit
    • Thomas Van Lenten's avatar
      Add more warnings to for the ObjC runtime build · c8a440df
      Thomas Van Lenten authored
      Working on https://github.com/google/protobuf/issues/1599, specifically:
      - Turn on more warnings that the Xcode UI calls out with individual controls.
      - Manually add:
        -Wundef
        -Wswitch-enum
      - Manually add and then diable in the unittests because of XCTest's headers:
        -Wreserved-id-macro
        -Wdocumentation-unknown-command
      - Manually add -Wdirect-ivar-access, but disable it for the unittests and in
        the library code (via #pragmas to suppress it). This is done so proto users
        can enable the warning.
      c8a440df
  8. 17 Mar, 2016 1 commit
    • Thomas Van Lenten's avatar
      Shrink ObjC overhead (generated size and some runtime sizes) · 79a23c43
      Thomas Van Lenten authored
      NOTE: This is a binary breaking change as structure sizes have changed size
      and/or order.
      
      - Drop capturing field options, no other options were captured and other mobile
        targeted languages don't try to capture this sort information (saved 8
        bytes for every field defined (in static data and again in field descriptor
        instance size data).
      - No longer generate/compile in the messages/enums in descriptor.proto. If
        developers need it, they should generate it and compile it in. Reduced the
        overhead of the core library.
      - Compute the number of has_bits actually needs to avoid over reserving.
      - Let the boolean single fields store via a has_bit to avoid storage, makes
        the common cases of the instance size smaller.
      - Reorder some flags and down size the enums to contain the bits needed.
      - Reorder the items in the structures to manually ensure they are are packed
        better (especially when generating 64bit code - 8 bytes for every field,
        16 bytes for every extension, instance sizes 8 bytes also).
      - Split off the structure initialization so when the default is zero, the
        generated static storage doesn't need to reserve the space. This is batched
        at the message level, so all the fields for the message have to have zero
        defaults to get the saves. By definition all proto3 syntax  files fall into
        this case but it also saves space for the proto2 that use the standard
        defaults. (saves 8 bytes of static data for every field that had a zero
        default)
      - Don't track the enums defined by a message. Nothing in the runtime needs it
        and it was just generation and runtime overhead. (saves 8 bytes per enum)
      - Ensure EnumDescriptors are started up threadsafe in all cases.
      - Split some of the Descriptor initialization into multiple methods so the
        generated code isn't padded with lots of zero/nil args.
      - Change how oneof info is feed to the runtime enabling us to generate less
        static data (8 bytes saved per oneof for 64bit).
      - Change how enum value informat is capture to pack the data and only decode
        it if it ends up being needed. Avoids padding issues causing bloat of 64bit,
        and removes the needs for extra pointers in addition to the data (just the
        data and one pointer now).
      79a23c43
  9. 08 Jun, 2015 1 commit
    • Thomas Van Lenten's avatar
      Beta quality drop of Objective C Support. · d846b0b0
      Thomas Van Lenten authored
      - Add more to the ObjC dir readme.
      - Merge the ExtensionField and ExtensionDescriptor to reduce overhead.
      - Fix an initialization race.
      - Clean up the Xcode schemes.
      - Remove the class/enum filter.
      - Remove some forced inline that were bloating things without proof of performance wins.
      - Rename some internal types to avoid conflicts with the well know types protos.
      - Drop the use of ApplyFunctions to the compiler/optimizer can do what it wants.
      - Better document some possible future improvements.
      - Add missing support for parsing repeated primitive fields in packed or unpacked forms.
      - Improve -hash.
      - Add *Count for repeated and map<> fields to avoid auto create when checking for them being set.
      d846b0b0
  10. 22 May, 2015 1 commit
    • Thomas Van Lenten's avatar
      Objective C Second Alpha Drop · 1dcc3294
      Thomas Van Lenten authored
      - Style fixups in the code.
      - map<> serialization fixes and more tests.
      - Autocreation of map<> fields (to match repeated fields).
      - @@protoc_insertion_point(global_scope|imports).
      - Fixup proto2 syntax extension support.
      - Move all startup code to +initialize so it happen on class usage and not app startup.
      - Have generated headers use forward declarations and move imports into generated code, reduces what is need at compile time to speed up compiled and avoid pointless rippling of rebuilds.
      1dcc3294
  11. 06 May, 2015 1 commit