1. 09 Nov, 2018 4 commits
  2. 08 Nov, 2018 2 commits
    • Adam Cozzette's avatar
      Merge pull request #5316 from zmodem/dllexport_build_fix · ce72041c
      Adam Cozzette authored
      Add wire_format_lite_inl.h include to implicit_weak_message.cc
      ce72041c
    • Dave MacLachlan's avatar
      Fix bugs in our keyword conversion support for objectivec · be83b29b
      Dave MacLachlan authored
      We have code for converting C/C++/Objc keywords that appear in protos
      to convert them so that they can be compiled.
      One of the things we need to be careful of is accidentally overriding methods
      that Apple declares in NSObject. It turns out that we have run into issues
      where we conflict with "hidden" methods in NSObject or methods added by
      categories. method_dump.sh collects all of the methods we care about for
      macOS and iOS and dumps them into objectivec_nsobject_methods.h which
      is then included in objectivec_helpers.cc as part of the build.
      
      Added a pile of tests to verify that conversions are happening as expected.
      be83b29b
  3. 06 Nov, 2018 4 commits
    • gerben-s's avatar
      Merge pull request #5261 from szakarias/dartExample · cd95c791
      gerben-s authored
      Add Dart example.
      cd95c791
    • Hans Wennborg's avatar
      Add wire_format_lite_inl.h include to implicit_weak_message.cc · 5d8dd6b0
      Hans Wennborg authored
      This unbreaks the Windows shared-library build of Chrome when using
      Clang versions based on r344987 or later, see https://crbug.com/901776
      
      implicit_weak_message.cc is part of protobuf_lite.dll, and it includes
      wire_format_lite.h, which includes the dllexport inline function
      WireFormatLite::WriteGroupToArray which will therefore be emitted.
      
      WriteGroupToArray in turn calls the inline function
      InternalWriteGroupToArray, however that definition is provided in the
      _inl file. To make sure the definition is available, the _inl file must
      be included.
      
      Before Clang r344987 the build worked anyway due to luck, because
      InternalWriteGroupToArray was emitted into other object files (e.g. in
      wire_format_lite.obj). After that Clang revision, those definitions
      started getting inlined, and so are longer available and cause a link
      failure for the reference from implicit_weak_message.obj.
      5d8dd6b0
    • Adam Cozzette's avatar
      Merge pull request #5314 from nilslice/patch-1 · eaf672fd
      Adam Cozzette authored
      3rd-party: include Protolock utility
      eaf672fd
    • Steve Manuel's avatar
      include Protolock utility · 6b10b916
      Steve Manuel authored
      6b10b916
  4. 05 Nov, 2018 1 commit
  5. 04 Nov, 2018 1 commit
  6. 02 Nov, 2018 1 commit
    • Thomas Van Lenten's avatar
      Let the 9.4 migrator migrate the Swift source. · eecccdc8
      Thomas Van Lenten authored
      No changes were needed, but since the Xcode projects pick up the updated
      setting, the tests require a newer Xcode that supports Swift 4.
      
      This is being done because Xcode 10 starting warning about Swift 3 support
      going away in the future, so we might as well do the updates since most
      folks shouldn't be on those really old Xcode versions any more.
      eecccdc8
  7. 01 Nov, 2018 3 commits
  8. 31 Oct, 2018 1 commit
  9. 29 Oct, 2018 3 commits
  10. 23 Oct, 2018 3 commits
  11. 22 Oct, 2018 3 commits
  12. 18 Oct, 2018 2 commits
  13. 17 Oct, 2018 1 commit
  14. 16 Oct, 2018 2 commits
  15. 15 Oct, 2018 3 commits
  16. 13 Oct, 2018 1 commit
  17. 12 Oct, 2018 2 commits
  18. 11 Oct, 2018 2 commits
  19. 10 Oct, 2018 1 commit