1. 10 Aug, 2015 2 commits
  2. 08 Aug, 2015 2 commits
  3. 06 Aug, 2015 1 commit
    • Jon Skeet's avatar
      Skip groups properly. · e7f88ff1
      Jon Skeet authored
      Now the generated code doesn't need to check for end group tags, as it will skip whole groups at a time.
      Currently it will ignore extraneous end group tags, which may or may not be a good thing.
      Renamed ConsumeLastField to SkipLastField as it felt more natural.
      Removed WireFormat.IsEndGroupTag as it's no longer useful.
      
      This mostly fixes issue 688.
      
      (Generated code changes coming in next commit.)
      e7f88ff1
  4. 05 Aug, 2015 1 commit
  5. 04 Aug, 2015 1 commit
  6. 30 Jul, 2015 4 commits
  7. 27 Jul, 2015 1 commit
    • Jon Skeet's avatar
      First attempt at using profile 259 for Google.Protobuf. · 0dbd5ec8
      Jon Skeet authored
      This requires .NET 4.5, and there are a few compatibility changes required around reflection.
      Creating a PR from this to see how our CI systems handle it. Will want to add more documentation,
      validation and probably tests before merging.
      
      This is in aid of issue #590.
      0dbd5ec8
  8. 21 Jul, 2015 1 commit
    • Jon Skeet's avatar
      Revamp to reflection. · 53c399a1
      Jon Skeet authored
      Changes in brief:
      1. Descriptor is now the entry point for all reflection.
      2. IReflectedMessage has gone; there's now a Descriptor property in IMessage, which is explicitly implemented (due to the static property).
      3. FieldAccessorTable has gone away
      4. IFieldAccessor and OneofFieldAccessor still exist; we *could* put the functionality straight into FieldDescriptor and OneofDescriptor... I'm unsure about that.
      5. There's a temporary property MessageDescriptor.FieldAccessorsByFieldNumber to make the test changes small - we probably want this to go away
      6. Discovery for delegates is now via attributes applied to properties and the Clear method of a oneof
      
      I'm happy with 1-3.
      4 I'm unsure about - feedback welcome.
      5 will go away
      6 I'm unsure about, both in design and implementation. Should we have a ProtobufMessageAttribute too? Should we find all the relevant attributes in MessageDescriptor and pass them down, to avoid an O(N^2) scenario?
      
      Generated code changes coming in the next commit.
      53c399a1
  9. 17 Jul, 2015 1 commit