- 22 Aug, 2018 1 commit
-
-
Feng Xiao authored
-
- 30 Apr, 2018 1 commit
-
-
Hiroshi Ichikawa authored
* Fix memory leak of exceptions raised by RaiseException() Currently exceptions raised by RaiseException() is never deallocated because: * ARC is disabled for this library: https://github.com/google/protobuf/blob/master/BUILD#L913 * It is constructed with `+alloc` but is never `-release`d. This change fixes the issue by using `-[NSException exceptionWithName:...]` instead, which returns an autoreleased instance, so it is deallocated properly. * Fix format.
-
- 31 Jan, 2018 1 commit
-
-
Thomas Van Lenten authored
Fixes #4246 Fixes #4247
-
- 24 Oct, 2017 1 commit
-
-
Sergio Campama authored
-
- 06 Jun, 2017 1 commit
-
-
Thomas Van Lenten authored
-
- 28 Mar, 2017 1 commit
-
-
Thomas Van Lenten authored
-
- 27 Oct, 2016 1 commit
-
-
Sergio Campamá authored
Adds pushLimit: and popLimit: into GPBCodedInputStream
-
- 29 Jun, 2016 1 commit
-
-
Thomas Van Lenten authored
There was a twist code path (that some times showed up due to what happened to be in memory in failure cases), that would cast a bogus wire type into the enum, and then fall through switch statements. Resolve this by validating all wire types when parsing tags and throwing the error at that point so it can't enter the system. As added safety, stick in a few asserts for apis that get passed tags to ensure they also are only seeing valid data. Bonus: Tweak the parsing loop to skip some work when we get the end marker (zero tag) instead of still looping through all the fields.
-
- 02 Jun, 2016 1 commit
-
-
Sergio Campamá authored
Add more context to GPBCodedInputStream failures. Have GPBMessage parsing apis extract out the GPBCodedInputStream information and expose it. Update HeaderDocs with pointers to all error domains/codes. Expand the unittests to cover the full set of errors reported. Fixes https://github.com/google/protobuf/issues/1618
-
- 25 May, 2016 1 commit
-
-
Thomas Van Lenten authored
Working on https://github.com/google/protobuf/issues/1599, specifically: - Turn on more warnings that the Xcode UI calls out with individual controls. - Manually add: -Wundef -Wswitch-enum - Manually add and then diable in the unittests because of XCTest's headers: -Wreserved-id-macro -Wdocumentation-unknown-command - Manually add -Wdirect-ivar-access, but disable it for the unittests and in the library code (via #pragmas to suppress it). This is done so proto users can enable the warning.
-
- 05 Apr, 2016 1 commit
-
-
Thomas Van Lenten authored
This seems to be some code evolution side effects. Back when there was a custom string class, we couldn't really error when we finally saw the string was bad so we had to return the empty string, but now that full validation is done up front, it can error out.
-
- 01 Apr, 2016 1 commit
-
-
Thomas Van Lenten authored
-
- 17 Dec, 2015 1 commit
-
-
Thomas Van Lenten authored
Apple engineers have pointed out that OSSpinLocks are vulnerable to live locking on iOS in cases of priority inversion: . http://mjtsai.com/blog/2015/12/16/osspinlock-is-unsafe/ . https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20151214/000372.html - Use a dispatch_semaphore_t within the extension registry. - Use a dispatch_semaphore_t for protecting autocreation within messages. - Drop the custom/internal GPBString class since we don't have really good numbers to judge the locking replacements and it isn't required. We can always bring it back with real data in the future.
-
- 23 Nov, 2015 1 commit
-
-
Thomas Van Lenten authored
- Mark all conformance tests as now passing.
-
- 08 Jun, 2015 1 commit
-
-
Thomas Van Lenten authored
- Add more to the ObjC dir readme. - Merge the ExtensionField and ExtensionDescriptor to reduce overhead. - Fix an initialization race. - Clean up the Xcode schemes. - Remove the class/enum filter. - Remove some forced inline that were bloating things without proof of performance wins. - Rename some internal types to avoid conflicts with the well know types protos. - Drop the use of ApplyFunctions to the compiler/optimizer can do what it wants. - Better document some possible future improvements. - Add missing support for parsing repeated primitive fields in packed or unpacked forms. - Improve -hash. - Add *Count for repeated and map<> fields to avoid auto create when checking for them being set.
-
- 06 May, 2015 1 commit
-
-
Thomas Van Lenten authored
-