1. 13 May, 2015 2 commits
    • Chris Fallin's avatar
      Merge pull request #383 from cfallin/ruby-travis · 2fe04838
      Chris Fallin authored
      Add Ruby to Travis testing
      2fe04838
    • Chris Fallin's avatar
      Added Ruby to Travis testing. · eb37551a
      Chris Fallin authored
      - Added RVM-based Ruby test driver that tests MRI and JRuby.
      - Fixed JRuby compilation (at least in my current setup): force source
        version to 1.6 (Java 6) to allow generics and annotations.
      - Modify the skipped JRuby JSON tests so that the exit code is 0 (skip()
        results in a failing exit code from `rake test`). An upcoming PR
        should fix JSON under JRuby in general soon.
      eb37551a
  2. 12 May, 2015 4 commits
  3. 08 May, 2015 1 commit
  4. 07 May, 2015 7 commits
  5. 06 May, 2015 7 commits
  6. 05 May, 2015 1 commit
  7. 03 May, 2015 2 commits
  8. 02 May, 2015 2 commits
  9. 01 May, 2015 4 commits
  10. 30 Apr, 2015 2 commits
  11. 29 Apr, 2015 2 commits
  12. 28 Apr, 2015 6 commits
    • Jeff Davidson's avatar
      Generate a CREATOR for each Parcelable message. · 9d546c85
      Jeff Davidson authored
      This is less ideal from a dex count perspective because it requires a
      new variable for each message, and because most apps have proguard
      rules that will ensure that CREATOR classes are retained.
      
      However, it is required to be able to use nano protos inside of AIDL
      files, as the autogenerated AIDL code fails to compile otherwise. This
      is a substantial benefit as it allows for backwards-compatible
      parameters and return types in AIDL methods along the lines of
      safeparcel.
      
      Bug: 19084705
      Change-Id: I66a2c0424b96cf8ff6b631b186cc4f9407dfc1f4
      9d546c85
    • Charles Munger's avatar
      Throw OutOfSpaceException instead of IllegalArgumentException. · 6732dd7e
      Charles Munger authored
      When a MessageNano containing a String is serialized into a buffer that
      is too small to contain it, and the buffer's boundary happens to be
      where the string field's length delimiting varint is serialized,
      and the string's length and 3*length have the same length when
      encoded as a varint, an IllegalArgumentException is thrown rather than
      an OutOfSpaceException.
      
      Github issue: https://github.com/google/protobuf/issues/292
      
      Change-Id: If478d68cf15bfd0662252d008e42b2bf1ff1c75e
      6732dd7e
    • Brian Duff's avatar
      Inline unknownFieldData{Equals,HashCode} to generated code. · a69b461e
      Brian Duff authored
      It turns out dex (apparently) was inlining these protected final
      methods from ExtendableMessageNano into every message class. Removing
      these methods from the base class and inlining their code reduces
      the method count by 2 methods / message when the store_unknown_fields
      option is on.
      
      Change-Id: I0aa09f2016d39939c4c8b8219601793b8fab301f
      a69b461e
    • Brian Duff's avatar
      Expose generate_clear as an option. · dac7e02d
      Brian Duff authored
      I wasn't able to get the clear() method to inline into the
      constructor when optimizations are on in proguard. As a result,
      every message has an extra superfluous kept method assuming the
      app never uses clear() directly.
      
      There are a couple of instances where setting this option false is
      necessary in order to get code dexing successfully without hitting
      the method limit, e.g. https://goto.google.com/tltzq
      
      In this example, I tried turning on the method/inlining/unique and
      method/inlining/short optimizations before resorting to adding the
      generate_clear option, but the method count did not decrease. The
      clear() methods were contributing over a thousand extra methods.
      
      Change-Id: If6a9651d6a59cdf70b1040d8248779710ac73105
      dac7e02d
    • Jeff Davidson's avatar
      Generate @IntDef annotations for nanoproto enums. · ec19be2f
      Jeff Davidson authored
      @IntDef is a support library annotation which allows build tools to
      determine the valid set of values for a given integer field when that
      field is intended to be restricted like an enum. This avoids the
      overhead of enums while still allowing for compile-time type checking
      in most circumstances.
      
      Change-Id: Iee02e0b49a8e069f6456572f538e0a0d301fdfd5
      ec19be2f
    • Shai Barack's avatar
      Add reset() and position() to CodedOutputByteBufferNano. · 41f0294c
      Shai Barack authored
      Change-Id: Ie2a9e36276ac35e10b3f8d379b5742d50a0374e9
      41f0294c