1. 23 Aug, 2019 5 commits
  2. 21 Feb, 2019 1 commit
  3. 20 Apr, 2016 1 commit
  4. 08 Aug, 2015 1 commit
    • Jon Skeet's avatar
      Make FieldDescriptor.IsPacked work appropriately. · 547d8e82
      Jon Skeet authored
      This is a bit of a grotty hack, as we need to sort of fake proto2 field presence, but with only a proto3 version of the descriptor messages (a bit like oneof detection).
      Should be okay, but will need to be careful of this if we ever implement proto2.
      547d8e82
  5. 22 Jul, 2015 2 commits
    • Jon Skeet's avatar
      Implemented Jan's suggestion of FieldCollection, replacing FieldAccessorCollection. · c1c6b2d0
      Jon Skeet authored
      I think Jan was actually suggesting keeping both, but that feels redundant to me. The test diff is misleading here IMO, because I wouldn't expect real code using reflection to use several accessors one after another like this, unless it was within a loop. Evidence to the contrary would be welcome :)
      
      This change also incidentally goes part way to fixing the issue of the JSON formatter not writing out the fields in field number order - with this change, it does except for oneofs, which we can fix in a follow-up change.
      
      I haven't actually added a test with a message with fields deliberately out of order - I'm happy to do so though. It feels like it would make sense to be in google/src/protobuf, but it's not entirely clear what the rules of engagement are for adding new messages there. (unittest_proto3.proto?)
      c1c6b2d0
    • Jon Skeet's avatar
      First pass at making field access simpler. · 20bf6a56
      Jon Skeet authored
      This is definitely not ready to ship - I'm "troubled" by the disconnect between a list of fields in declaration order, and a mapping of field accessors by field number/name. Discussion required, but I find that easier when we've got code to look at :)
      20bf6a56