- 28 Jan, 2019 2 commits
-
-
Bo Yang authored
json_decode automatically convert numeric string to integer, so that we need to convert it back. However, this will suceed to parse invalid json data with string field set as integer even though it should have failed. Because, the failure case is less often than the succeeding case, we decided to make this change. Users should make sure their data don't use integer for string fields by themselves.
-
Paul Yang authored
-
- 23 Jan, 2019 1 commit
-
-
Paul Yang authored
* Fix more issues for reference values * Revert change in gdb test * Add more tests
-
- 22 Jan, 2019 2 commits
- 17 Jan, 2019 1 commit
-
-
Paul Yang authored
* Fix field mask for php in json * Update byte size
-
- 08 Jan, 2019 1 commit
-
-
Paul Yang authored
* Fix Empty ListValue/Struct json encoding * Add test for empty ListValue
-
- 26 Dec, 2018 1 commit
-
-
Paul Yang authored
* Fix Any json encoding/decoding in php * Fix comments
-
- 18 Dec, 2018 1 commit
-
-
Paul Yang authored
* Inherit from message instead of implement When regestering class (implmenets other class) during MINIT, zend_class_implements would call zend_class_entry->interface_gets_implemented(). In PHP-7.3 interface_gets_implemented shares the same location with create_object. However, during MINIT, the global object storeage hasn't been initialized. And thus, caused segment fault in php 7.3. * Use zend_string_init where interned string may be the value. zend_string_dup will keep using the existing interned string. In php 7.3, interned string cannot be destroyed from user's code. * Uncommment debug code * Use latest phpunit for each php versions * Revert change in Dockerfile * Update php test to use the new docker image * Update composer * Change docker organization * Update phpunit * Debug phpunit * Store phpunit into bin dir in docker image * Install valgrind to docker * Fix compatibility test * Remove generated_service_test from compatibility c extension test * Update 32bit php test to the new docker image * Install bison * Fix build.sh * Fix DOCKERIMAGE_PREFIX * Fix basename * Add comment to build_and_run_docker2.sh * Remove commented code * Fix comments
-
- 29 Nov, 2018 1 commit
-
-
michaelbausor authored
* adds string-to-int and int-to-string methods to enums * remove check for valueToName property in EnumTrait * Remove unused imports * Update to avoid using EnumTrait * Remove EnumTrait * Update enum types * Move name and value methods into generated classes * Remove functions from GPBUtil * Test well known enums * Implement enum value to/from name in c extension * Only generate use statement when namespace is present
-
- 12 Oct, 2018 1 commit
-
-
Paul Yang authored
-
- 07 Oct, 2018 1 commit
-
-
michaelbausor authored
* Add support for primitive types in setters * Update to address PR feedback * Add tests and fixes for repeated fields * Remove repeated field code, add getters * Cleanup, test getters and oneofs * Move boxing logic into separate class * Add tests for wrapper type constructor args * Update to add new setXXXValue methods * Fix tests for invalid values * Fix c extension for wrapper accessors * Fix the bug that well known types didn't call Message_construct * Address PR comments * Refactoring init message with array logic * Add include path to protoc * Add missing TSRM_LS defintion * Fix TSRM_LS * Fix dist check
-
- 23 Sep, 2018 1 commit
-
-
Paul Yang authored
* Adopt upb change for timestamp and duration json to php * Remove unused code * Re-sync upb * Fix php implementation timestamp json parsing * Fix strptime use local timezone on mac. * Remove succeeding tests * Resync * Add tests for values * Fix php tests * Fix encoder handlers change default value Previously, oneofsubmsg_handler and submsg_handler change zval's default value directly. The fix use REPLACE_ZVAL_VALUE which create a copy of parsed value and assign it to zval.
-
- 31 Aug, 2018 1 commit
-
-
Paul Yang authored
* Fix well known type class not inheriting Message Previously, well known types only implement Message interface but not inhert it. Fix the problem by calling zend_do_inheritance * Add back commented tests
-
- 22 Aug, 2018 1 commit
-
-
Feng Xiao authored
-
- 10 Aug, 2018 1 commit
-
-
Bo Yang authored
-
- 20 Jul, 2018 2 commits
-
-
Leonard Hecker authored
* php: Added nanosecond support for Timestamp * php: Fixed compatibility test
-
Paul Yang authored
This change only makes assertEquals pass for message in c extension. However, it actually does nothing. This is the same behavior before 3.6.0 release.
-
- 16 Jul, 2018 2 commits
- 13 Jul, 2018 2 commits
- 25 Jun, 2018 1 commit
-
-
Pat Moroney authored
the testMessageSetNullFail function was declared twice. So I renamed one to testMessageSetNullFailMap
-
- 08 Jun, 2018 1 commit
-
-
Paul Yang authored
* Use legacy name in php runtime Old generated code cannot work with new runtime, because the new runtime assumes new class name for nested message. For details see #4738. * Remove unused method
-
- 29 May, 2018 2 commits
- 25 May, 2018 4 commits
-
-
Brent Shaffer authored
* uses namespaces for nested messages and enums * fixes namespaces for PHP dist * fixes namespace for Descriptors, adds Cardinality and Kind * fixes nested namespaces for reserved words and adds tests * adds tests and generator fix for php class prefixes * fixes escaping of protobuf packages, enum comments, misc others * nice refactor of generated code * adds class files for backwards compatibility * simplifies code with templates * adds compatibility files to makefile * cleanup of generator and fixes nested namespace bug * regenerates proto types * remove internal BC classes * adds deprecated warning, adds methods back * simplifies if statement * fixes dist files * addresses review comments * adds back TYPE_URL_PREFIX constant * adds @deprecated to old nested class files * skips tests which require a separate process when protobuf.so is enabled * Adds tests for legacy nested classes that do not require separate processes to test * uses legacy names for GPBUtil message check * adds block for IDE @deprecated message * Namespace for nested message/enum in c extension * Remove unused code
-
Bo Yang authored
-
Brent Shaffer authored
* PHP array constructors for protobuf messages * removes Descriptor from error message * allows mergeFrom to accept an array * only use initWithDescriptor if instanceof MapEntry * adds doc comments * removes ability for constructors to take arrays for submessages * Revert "allows mergeFrom to accept an array" This reverts commit b7b72182d561634af12c5c5c56a7cda3b33241f9. * makes mergeFromArray protected and fixes mergeFrom whitespace * Separates merging from JSON and merging from PHP array * removes well-known types and json keys from array construction * Addresses PR review comments * cleans up tests * fixes exception messages
-
Paul Yang authored
* Adopt php_metadata_namespace in php code generator The php_metadata_namespace is corresponded to the relative directory of the metadata file. e.g., previously, the metadata file of foo.proto was GPBMetadata/Foo.php. If the php_metadata_namespace is "Metadata\\Bar", the metadata file will be Metadata/Bar/Foo.php. * Handle empty php_metadata_namespace
-
- 24 May, 2018 3 commits
-
-
Brent Shaffer authored
* uses namespaces for nested messages and enums * fixes namespaces for PHP dist * fixes namespace for Descriptors, adds Cardinality and Kind * fixes nested namespaces for reserved words and adds tests * adds tests and generator fix for php class prefixes * fixes escaping of protobuf packages, enum comments, misc others * nice refactor of generated code * adds class files for backwards compatibility * simplifies code with templates * adds compatibility files to makefile * cleanup of generator and fixes nested namespace bug * regenerates proto types * remove internal BC classes * adds deprecated warning, adds methods back * simplifies if statement * fixes dist files * addresses review comments * adds back TYPE_URL_PREFIX constant * adds @deprecated to old nested class files * skips tests which require a separate process when protobuf.so is enabled * Adds tests for legacy nested classes that do not require separate processes to test * uses legacy names for GPBUtil message check * adds block for IDE @deprecated message * Namespace for nested message/enum in c extension * Remove unused code
-
Bo Yang authored
-
Brent Shaffer authored
* PHP array constructors for protobuf messages * removes Descriptor from error message * allows mergeFrom to accept an array * only use initWithDescriptor if instanceof MapEntry * adds doc comments * removes ability for constructors to take arrays for submessages * Revert "allows mergeFrom to accept an array" This reverts commit b7b72182d561634af12c5c5c56a7cda3b33241f9. * makes mergeFromArray protected and fixes mergeFrom whitespace * Separates merging from JSON and merging from PHP array * removes well-known types and json keys from array construction * Addresses PR review comments * cleans up tests * fixes exception messages
-
- 14 May, 2018 1 commit
-
-
Paul Yang authored
* Adopt php_metadata_namespace in php code generator The php_metadata_namespace is corresponded to the relative directory of the metadata file. e.g., previously, the metadata file of foo.proto was GPBMetadata/Foo.php. If the php_metadata_namespace is "Metadata\\Bar", the metadata file will be Metadata/Bar/Foo.php. * Handle empty php_metadata_namespace
-
- 10 May, 2018 1 commit
-
-
Paul Yang authored
* Throw error if user want to access message properties * Fix typo
-
- 25 Jan, 2018 1 commit
-
-
Paul Yang authored
* Fix more memory leak for php c extension * Fix memory leak for php5.5
-
- 13 Dec, 2017 1 commit
-
-
Bo Yang authored
This changes the linking error if php extension is not statically linked to a runtime error. In this way, users who don't need Timestamp can still use protobuf even if date extension is not statically linked in php.
-
- 12 Dec, 2017 2 commits
- 07 Dec, 2017 1 commit
-
-
Paul Yang authored
* Recursively clear unknown fields in submessages. * Recursively discard unknown fields in submsg for c extension * Fix zts build * Add comment for tests * Add a TODO to add a util for encoding varint for better readability. * Add test for oneof message field.
-