Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
P
protobuf
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
protobuf
Commits
ffa18ad2
Commit
ffa18ad2
authored
Dec 19, 2017
by
Ubuntu
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
resolve issue 4032 and added a unit test
parent
860d693c
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
17 additions
and
1 deletion
+17
-1
json_util.cc
src/google/protobuf/util/json_util.cc
+2
-1
json_util_test.cc
src/google/protobuf/util/json_util_test.cc
+15
-0
No files found.
src/google/protobuf/util/json_util.cc
View file @
ffa18ad2
...
...
@@ -50,7 +50,8 @@ namespace util {
namespace
internal
{
ZeroCopyStreamByteSink
::~
ZeroCopyStreamByteSink
()
{
stream_
->
BackUp
(
buffer_size_
);
if
(
buffer_size_
>
0
)
stream_
->
BackUp
(
buffer_size_
);
}
void
ZeroCopyStreamByteSink
::
Append
(
const
char
*
bytes
,
size_t
len
)
{
...
...
src/google/protobuf/util/json_util_test.cc
View file @
ffa18ad2
...
...
@@ -40,6 +40,7 @@
#include <google/protobuf/util/json_format_proto3.pb.h>
#include <google/protobuf/util/type_resolver.h>
#include <google/protobuf/util/type_resolver_util.h>
#include <google/protobuf/io/zero_copy_stream_impl.h>
#include <gtest/gtest.h>
namespace
google
{
...
...
@@ -457,6 +458,20 @@ TEST(ZeroCopyStreamByteSinkTest, TestAllInputOutputPatterns) {
}
}
TEST_F
(
JsonUtilTest
,
TestWronJsonInput
)
{
const
char
json
[]
=
"{
\"
unknown_field
\"
:
\"
some_value
\"
}"
;
google
::
protobuf
::
io
::
ArrayInputStream
input_stream
(
json
,
strlen
(
json
));
char
protoBuffer
[
10000
];
google
::
protobuf
::
io
::
ArrayOutputStream
output_stream
(
protoBuffer
,
sizeof
(
protoBuffer
));
const
char
*
messageType
=
"type.googleapis.com/proto3.TestMessage"
;
TypeResolver
*
resolver
=
NewTypeResolverForDescriptorPool
(
"type.googleapis.com"
,
DescriptorPool
::
generated_pool
());
util
::
Status
resultStatus
=
util
::
JsonToBinaryStream
(
resolver
,
messageType
,
&
input_stream
,
&
output_stream
);
EXPECT_FALSE
(
resultStatus
.
ok
());
EXPECT_EQ
(
resultStatus
.
error_code
(),
google
::
protobuf
::
util
::
error
::
INVALID_ARGUMENT
);
}
}
// namespace
}
// namespace util
}
// namespace protobuf
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment