Commit f7bb8477 authored by Adam Cozzette's avatar Adam Cozzette Committed by Bo Yang

Fixed quadratic behavior in JSPB deserialization of repeated fields (#2117) (#2146)

Currently deserialization of a non-packed binary repeated field is quadratic in
the number of elements, because each time we parse a new element we copy over
all elements we have parsed so far. This CL fixes the performance problem by
having the generated deserialization code just call addX() instead of using
getX() and setX().
parent 31dd4998
......@@ -2850,13 +2850,9 @@ void Generator::GenerateClassDeserializeBinaryField(
}
if (field->is_repeated() && !field->is_packed()) {
// Repeated fields receive a |value| one at at a time; append to array
// returned by get$name$(). Annoyingly, we have to call 'set' after
// changing the array.
printer->Print(" msg.get$name$().push(value);\n", "name",
JSGetterName(options, field));
printer->Print(" msg.set$name$(msg.get$name$());\n", "name",
JSGetterName(options, field));
printer->Print(
" msg.add$name$(value);\n", "name",
JSGetterName(options, field, BYTES_DEFAULT, /* drop_list = */ true));
} else {
// Singular fields, and packed repeated fields, receive a |value| either
// as the field's value or as the array of all the field's values; set
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment