Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
P
protobuf
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
protobuf
Commits
f21d4d68
Unverified
Commit
f21d4d68
authored
6 years ago
by
Yilun Chong
Committed by
GitHub
6 years ago
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #4903 from BSBandme/fix_js_build
fix commonjs js provide GOOGLE_CHECK
parents
84752ff3
f42ddff0
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
1 deletion
+1
-1
js_generator.cc
src/google/protobuf/compiler/js/js_generator.cc
+1
-1
No files found.
src/google/protobuf/compiler/js/js_generator.cc
View file @
f21d4d68
...
...
@@ -1681,7 +1681,7 @@ void Generator::GenerateProvides(const GeneratorOptions& options,
if
(
options
.
import_style
==
GeneratorOptions
::
kImportCommonJsStrict
)
{
string
namespaceObject
=
*
it
;
// Remove "proto." from the namespace object
GOOGLE_CHECK
(
namespaceObject
.
compare
(
0
,
6
,
"proto."
));
GOOGLE_CHECK
(
namespaceObject
.
compare
(
0
,
6
,
"proto."
)
==
0
);
namespaceObject
.
erase
(
0
,
6
);
printer
->
Print
(
"goog.exportSymbol('$name$', null, proto);
\n
"
,
"name"
,
namespaceObject
);
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment