Fixed a memory leak in python CPP implementation.

e8e6eed0 · liujisi@google.com · 7a6de000 · e8e6eed0
Commit e8e6eed0 authored Jun 07, 2011 by liujisi@google.com
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

python-proto2.cc python/google/protobuf/pyext/python-proto2.cc +3 -1

No files found.
--- a/python/google/protobuf/pyext/python-proto2.cc
+++ b/python/google/protobuf/pyext/python-proto2.cc
@@ -1099,10 +1099,12 @@ static PyObject* CMessage_AssignRepeatedScalar(CMessage* self, PyObject* args) {
  PyObject* next;
  while ((next = PyIter_Next(iter)) != NULL) {
    if (InternalAddRepeatedScalar(
-        message, cfield_descriptor->descriptor, next) == NULL) {
+            message, cfield_descriptor->descriptor, next) == NULL) {
+      Py_DECREF(next);
      Py_DECREF(iter);
      return NULL;
    }
+    Py_DECREF(next);
  }
  Py_DECREF(iter);
  Py_RETURN_NONE;